Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 11 Projects Releases Packages Wiki Activity Actions

Test | Fix missing updateSuperProperties impl

Browse source
This commit is contained in:
Valere 2024-05-31 00:08:30 +02:00
parent 85c8823e30
commit bcf4e27d6f
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt
View file

@ -19,6 +19,7 @@ package io.element.android.services.analytics.noop
import com.squareup.anvil.annotations.ContributesBinding import com.squareup.anvil.annotations.ContributesBinding
import im.vector.app.features.analytics.itf.VectorAnalyticsEvent import im.vector.app.features.analytics.itf.VectorAnalyticsEvent
import im.vector.app.features.analytics.itf.VectorAnalyticsScreen import im.vector.app.features.analytics.itf.VectorAnalyticsScreen
import im.vector.app.features.analytics.plan.SuperProperties
import im.vector.app.features.analytics.plan.UserProperties import im.vector.app.features.analytics.plan.UserProperties
import io.element.android.libraries.di.AppScope import io.element.android.libraries.di.AppScope
import io.element.android.libraries.di.SingleIn import io.element.android.libraries.di.SingleIn
@ -43,4 +44,5 @@ class NoopAnalyticsService @Inject constructor() : AnalyticsService {
override fun screen(screen: VectorAnalyticsScreen) = Unit override fun screen(screen: VectorAnalyticsScreen) = Unit
override fun updateUserProperties(userProperties: UserProperties) = Unit override fun updateUserProperties(userProperties: UserProperties) = Unit
override fun trackError(throwable: Throwable) = Unit override fun trackError(throwable: Throwable) = Unit
override fun updateSuperProperties(updatedProperties: SuperProperties) = Unit
} }

5
services/analytics/test/src/main/kotlin/io/element/android/services/analytics/test/FakeAnalyticsService.kt
View file

@ -18,6 +18,7 @@ package io.element.android.services.analytics.test
import im.vector.app.features.analytics.itf.VectorAnalyticsEvent import im.vector.app.features.analytics.itf.VectorAnalyticsEvent
import im.vector.app.features.analytics.itf.VectorAnalyticsScreen import im.vector.app.features.analytics.itf.VectorAnalyticsScreen
import im.vector.app.features.analytics.plan.SuperProperties
import im.vector.app.features.analytics.plan.UserProperties import im.vector.app.features.analytics.plan.UserProperties
import io.element.android.services.analytics.api.AnalyticsService import io.element.android.services.analytics.api.AnalyticsService
import io.element.android.services.analyticsproviders.api.AnalyticsProvider import io.element.android.services.analyticsproviders.api.AnalyticsProvider
@ -70,6 +71,10 @@ class FakeAnalyticsService(
trackedErrors += throwable trackedErrors += throwable
} }
override fun updateSuperProperties(updatedProperties: SuperProperties) {
// No op
}
override suspend fun reset() { override suspend fun reset() {
didAskUserConsentFlow.value = false didAskUserConsentFlow.value = false
} }