Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Rename Developer -> ViewSource

Browse source
This commit is contained in:
Benoit Marty 2023-09-14 11:35:58 +02:00 • committed by Benoit Marty
parent f55e8a6ad8
commit bf67c6e349
6 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt
View file

@ -213,7 +213,7 @@ class MessagesPresenter @AssistedInject constructor(
TimelineItemAction.Edit -> handleActionEdit(targetEvent, composerState, enableTextFormatting) TimelineItemAction.Edit -> handleActionEdit(targetEvent, composerState, enableTextFormatting)
TimelineItemAction.Reply, TimelineItemAction.Reply,
TimelineItemAction.ReplyInThread -> handleActionReply(targetEvent, composerState) TimelineItemAction.ReplyInThread -> handleActionReply(targetEvent, composerState)
TimelineItemAction.Developer -> handleShowDebugInfoAction(targetEvent) TimelineItemAction.ViewSource -> handleShowDebugInfoAction(targetEvent)
TimelineItemAction.Forward -> handleForwardAction(targetEvent) TimelineItemAction.Forward -> handleForwardAction(targetEvent)
TimelineItemAction.ReportContent -> handleReportAction(targetEvent) TimelineItemAction.ReportContent -> handleReportAction(targetEvent)
TimelineItemAction.EndPoll -> handleEndPollAction(targetEvent) TimelineItemAction.EndPoll -> handleEndPollAction(targetEvent)

8
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenter.kt
View file

@ -86,7 +86,7 @@ class ActionListPresenter @Inject constructor(
when (timelineItem.content) { when (timelineItem.content) {
is TimelineItemRedactedContent -> { is TimelineItemRedactedContent -> {
if (buildMeta.isDebuggable) { if (buildMeta.isDebuggable) {
listOf(TimelineItemAction.Developer) listOf(TimelineItemAction.ViewSource)
} else { } else {
emptyList() emptyList()
} }
@ -95,7 +95,7 @@ class ActionListPresenter @Inject constructor(
buildList { buildList {
add(TimelineItemAction.Copy) add(TimelineItemAction.Copy)
if (buildMeta.isDebuggable) { if (buildMeta.isDebuggable) {
add(TimelineItemAction.Developer) add(TimelineItemAction.ViewSource)
} }
} }
} }
@ -116,7 +116,7 @@ class ActionListPresenter @Inject constructor(
add(TimelineItemAction.Copy) add(TimelineItemAction.Copy)
} }
if (buildMeta.isDebuggable) { if (buildMeta.isDebuggable) {
add(TimelineItemAction.Developer) add(TimelineItemAction.ViewSource)
} }
if (!timelineItem.isMine) { if (!timelineItem.isMine) {
add(TimelineItemAction.ReportContent) add(TimelineItemAction.ReportContent)
@ -145,7 +145,7 @@ class ActionListPresenter @Inject constructor(
add(TimelineItemAction.Copy) add(TimelineItemAction.Copy)
} }
if (buildMeta.isDebuggable) { if (buildMeta.isDebuggable) {
add(TimelineItemAction.Developer) add(TimelineItemAction.ViewSource)
} }
if (!timelineItem.isMine) { if (!timelineItem.isMine) {
add(TimelineItemAction.ReportContent) add(TimelineItemAction.ReportContent)

4
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListStateProvider.kt
View file

@ -111,7 +111,7 @@ fun aTimelineItemActionList(): ImmutableList<TimelineItemAction> {
TimelineItemAction.Edit, TimelineItemAction.Edit,
TimelineItemAction.Redact, TimelineItemAction.Redact,
TimelineItemAction.ReportContent, TimelineItemAction.ReportContent,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
) )
} }
fun aTimelineItemPollActionList(): ImmutableList<TimelineItemAction> { fun aTimelineItemPollActionList(): ImmutableList<TimelineItemAction> {
@ -119,7 +119,7 @@ fun aTimelineItemPollActionList(): ImmutableList<TimelineItemAction> {
TimelineItemAction.EndPoll, TimelineItemAction.EndPoll,
TimelineItemAction.Reply, TimelineItemAction.Reply,
TimelineItemAction.Copy, TimelineItemAction.Copy,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
TimelineItemAction.ReportContent, TimelineItemAction.ReportContent,
TimelineItemAction.Redact, TimelineItemAction.Redact,
) )

2
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/model/TimelineItemAction.kt
View file

@ -34,7 +34,7 @@ sealed class TimelineItemAction(
data object Reply : TimelineItemAction(CommonStrings.action_reply, VectorIcons.Reply) data object Reply : TimelineItemAction(CommonStrings.action_reply, VectorIcons.Reply)
data object ReplyInThread : TimelineItemAction(CommonStrings.action_reply_in_thread, VectorIcons.Reply) data object ReplyInThread : TimelineItemAction(CommonStrings.action_reply_in_thread, VectorIcons.Reply)
data object Edit : TimelineItemAction(CommonStrings.action_edit, VectorIcons.Edit) data object Edit : TimelineItemAction(CommonStrings.action_edit, VectorIcons.Edit)
data object Developer : TimelineItemAction(CommonStrings.action_view_source, VectorIcons.DeveloperMode) data object ViewSource : TimelineItemAction(CommonStrings.action_view_source, VectorIcons.DeveloperMode)
data object ReportContent : TimelineItemAction(CommonStrings.action_report_content, VectorIcons.ReportContent, destructive = true) data object ReportContent : TimelineItemAction(CommonStrings.action_report_content, VectorIcons.ReportContent, destructive = true)
data object EndPoll : TimelineItemAction(CommonStrings.action_end_poll, VectorIcons.PollEnd) data object EndPoll : TimelineItemAction(CommonStrings.action_end_poll, VectorIcons.PollEnd)
} }

2
features/messages/impl/src/test/kotlin/io/element/android/features/messages/MessagesPresenterTest.kt
View file

@ -365,7 +365,7 @@ class MessagesPresenterTest {
presenter.present() presenter.present()
}.test { }.test {
val initialState = awaitItem() val initialState = awaitItem()
initialState.eventSink.invoke(MessagesEvents.HandleAction(TimelineItemAction.Developer, aMessageEvent())) initialState.eventSink.invoke(MessagesEvents.HandleAction(TimelineItemAction.ViewSource, aMessageEvent()))
assertThat(awaitItem().actionListState.target).isEqualTo(ActionListState.Target.None) assertThat(awaitItem().actionListState.target).isEqualTo(ActionListState.Target.None)
assertThat(navigator.onShowEventDebugInfoClickedCount).isEqualTo(1) assertThat(navigator.onShowEventDebugInfoClickedCount).isEqualTo(1)
} }

16
features/messages/impl/src/test/kotlin/io/element/android/features/messages/actionlist/ActionListPresenterTest.kt
View file

@ -71,7 +71,7 @@ class ActionListPresenterTest {
ActionListState.Target.Success( ActionListState.Target.Success(
messageEvent, messageEvent,
persistentListOf( persistentListOf(
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
) )
) )
) )
@ -96,7 +96,7 @@ class ActionListPresenterTest {
ActionListState.Target.Success( ActionListState.Target.Success(
messageEvent, messageEvent,
persistentListOf( persistentListOf(
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
) )
) )
) )
@ -127,7 +127,7 @@ class ActionListPresenterTest {
TimelineItemAction.Reply, TimelineItemAction.Reply,
TimelineItemAction.Forward, TimelineItemAction.Forward,
TimelineItemAction.Copy, TimelineItemAction.Copy,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
TimelineItemAction.ReportContent, TimelineItemAction.ReportContent,
) )
) )
@ -158,7 +158,7 @@ class ActionListPresenterTest {
persistentListOf( persistentListOf(
TimelineItemAction.Forward, TimelineItemAction.Forward,
TimelineItemAction.Copy, TimelineItemAction.Copy,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
TimelineItemAction.ReportContent, TimelineItemAction.ReportContent,
) )
) )
@ -188,7 +188,7 @@ class ActionListPresenterTest {
TimelineItemAction.Reply, TimelineItemAction.Reply,
TimelineItemAction.Forward, TimelineItemAction.Forward,
TimelineItemAction.Copy, TimelineItemAction.Copy,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
TimelineItemAction.ReportContent, TimelineItemAction.ReportContent,
TimelineItemAction.Redact, TimelineItemAction.Redact,
) )
@ -222,7 +222,7 @@ class ActionListPresenterTest {
TimelineItemAction.Forward, TimelineItemAction.Forward,
TimelineItemAction.Edit, TimelineItemAction.Edit,
TimelineItemAction.Copy, TimelineItemAction.Copy,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
TimelineItemAction.Redact, TimelineItemAction.Redact,
) )
) )
@ -253,7 +253,7 @@ class ActionListPresenterTest {
persistentListOf( persistentListOf(
TimelineItemAction.Reply, TimelineItemAction.Reply,
TimelineItemAction.Forward, TimelineItemAction.Forward,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
TimelineItemAction.Redact, TimelineItemAction.Redact,
) )
) )
@ -283,7 +283,7 @@ class ActionListPresenterTest {
stateEvent, stateEvent,
persistentListOf( persistentListOf(
TimelineItemAction.Copy, TimelineItemAction.Copy,
TimelineItemAction.Developer, TimelineItemAction.ViewSource,
) )
) )
) )