Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Upload app id and clean version to bug reports (#2829)

Browse source 
* Upload app id and clean version to bug reports

* Add changelog
This commit is contained in:
Jorge Martin Espinosa 2024-05-10 12:15:33 +02:00 • committed by GitHub
parent a99f30fbd7
commit c64ead11c8
3 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/2829.bugfix Normal file
View file

@ -0,0 +1 @@
Add missing `app_id` and `Version` properties to bug reports.

3
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt
View file

@ -161,6 +161,9 @@ class DefaultBugReporter @Inject constructor(
.addFormDataPart("sdk_sha", sdkMetadata.sdkGitSha) .addFormDataPart("sdk_sha", sdkMetadata.sdkGitSha)
.addFormDataPart("local_time", LocalDateTime.now().format(DateTimeFormatter.ISO_DATE_TIME)) .addFormDataPart("local_time", LocalDateTime.now().format(DateTimeFormatter.ISO_DATE_TIME))
.addFormDataPart("utc_time", LocalDateTime.ofInstant(Instant.now(), ZoneOffset.UTC).format(DateTimeFormatter.ISO_DATE_TIME)) .addFormDataPart("utc_time", LocalDateTime.ofInstant(Instant.now(), ZoneOffset.UTC).format(DateTimeFormatter.ISO_DATE_TIME))
.addFormDataPart("app_id", buildMeta.applicationId)
// Nightly versions have a custom version name suffix that we should remove for the bug report
.addFormDataPart("Version", buildMeta.versionName.replace("-nightly", ""))
currentTracingFilter?.let { currentTracingFilter?.let {
builder.addFormDataPart("tracing_filter", it) builder.addFormDataPart("tracing_filter", it)
} }

2
features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporterTest.kt
View file

@ -154,6 +154,6 @@ class DefaultBugReporterTest {
} }
companion object { companion object {
private const val EXPECTED_NUMBER_OF_PROGRESS_VALUE = 15 private const val EXPECTED_NUMBER_OF_PROGRESS_VALUE = 17
} }
} }