Merge pull request #5678 from element-hq/feature/bma/countAccounts

Introduce new query to count accounts

appnav/src/main/kotlin/io/element/android/appnav/RootFlowNode.kt

@@ -349,7 +349,7 @@ class RootFlowNode(
         } else {
             // wait for the current session to be restored
             val loggedInFlowNode = attachSession(latestSessionId)
-            if (sessionStore.getAllSessions().size > 1) {
+            if (sessionStore.numberOfSessions() > 1) {
                 // Several accounts, let the user choose which one to use
                 backstack.push(
                     NavTarget.AccountSelect(
@@ -379,7 +379,7 @@ class RootFlowNode(
                 is PermalinkData.FallbackLink -> Unit
                 is PermalinkData.RoomEmailInviteLink -> Unit
                 else -> {
-                    if (sessionStore.getAllSessions().size > 1) {
+                    if (sessionStore.numberOfSessions() > 1) {
                         // Several accounts, let the user choose which one to use
                         backstack.push(
                             NavTarget.AccountSelect(

features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/onboarding/OnBoardingPresenter.kt

@@ -90,7 +90,7 @@ class OnBoardingPresenter(
         }
         val isAddingAccount by produceState(initialValue = false) {
             // We are adding an account if there is at least one session already stored
-            value = sessionStore.getAllSessions().isNotEmpty()
+            value = sessionStore.numberOfSessions() > 0
         }
 
         val loginMode by loginHelper.collectLoginMode()

features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt

@@ -165,7 +165,7 @@ class DefaultBugReporter(
                     }
                 }
                 val sessionData = sessionStore.getLatestSession()
-                val numberOfAccounts = sessionStore.getAllSessions().size
+                val numberOfAccounts = sessionStore.numberOfSessions()
                 val deviceId = sessionData?.deviceId ?: "undefined"
                 val userId = sessionData?.userId?.let { UserId(it) }
                 // build the multi part request

features/signedout/impl/src/test/kotlin/io/element/android/features/signedout/impl/SignedOutPresenterTest.kt

@@ -58,9 +58,11 @@ class SignedOutPresenterTest {
             val initialState = awaitItem()
             assertThat(initialState.signedOutSession).isEqualTo(aSessionData)
             assertThat(sessionStore.getAllSessions()).isNotEmpty()
+            assertThat(sessionStore.numberOfSessions()).isEqualTo(1)
             initialState.eventSink(SignedOutEvents.SignInAgain)
             assertThat(awaitItem().signedOutSession).isNull()
             assertThat(sessionStore.getAllSessions()).isEmpty()
+            assertThat(sessionStore.numberOfSessions()).isEqualTo(0)
         }
     }
 }

libraries/session-storage/api/src/main/kotlin/io/element/android/libraries/sessionstorage/api/SessionStore.kt

@@ -50,6 +50,11 @@ interface SessionStore {
      */
     suspend fun getAllSessions(): List<SessionData>
 
+    /**
+     * Get the number of sessions.
+     */
+    suspend fun numberOfSessions(): Int
+
     /**
      * Get the latest session, or null if no session exists.
      */

libraries/session-storage/impl/src/main/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStore.kt

@@ -161,6 +161,15 @@ class DatabaseSessionStore(
         }
     }
 
+    override suspend fun numberOfSessions(): Int {
+        return sessionDataMutex.withLock {
+            database.sessionDataQueries.count()
+                .executeAsOneOrNull()
+                ?.toInt()
+                ?: 0
+        }
+    }
+
     override fun sessionsFlow(): Flow<List<SessionData>> {
         return database.sessionDataQueries.selectAll()
             .asFlow()

libraries/session-storage/impl/src/main/sqldelight/io/element/android/libraries/matrix/session/SessionData.sq

@@ -47,6 +47,9 @@ SELECT * FROM SessionData ORDER BY lastUsageIndex DESC LIMIT 1;
 selectAll:
 SELECT * FROM SessionData ORDER BY lastUsageIndex DESC;
 
+count:
+SELECT count(*) FROM SessionData;
+
 selectByUserId:
 SELECT * FROM SessionData WHERE userId = ?;
 

libraries/session-storage/impl/src/test/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStoreTest.kt

@@ -52,6 +52,7 @@ class DatabaseSessionStoreTest {
 
         assertThat(database.sessionDataQueries.selectLatest().executeAsOneOrNull()).isEqualTo(aSessionData)
         assertThat(database.sessionDataQueries.selectAll().executeAsList().size).isEqualTo(1)
+        assertThat(database.sessionDataQueries.count().executeAsOneOrNull()).isEqualTo(1)
     }
 
     @Test
@@ -109,6 +110,7 @@ class DatabaseSessionStoreTest {
 
         assertThat(foundSession).isEqualTo(aSessionData)
         assertThat(database.sessionDataQueries.selectAll().executeAsList().size).isEqualTo(2)
+        assertThat(database.sessionDataQueries.count().executeAsOneOrNull()).isEqualTo(2)
     }
 
     @Test
@@ -196,12 +198,16 @@ class DatabaseSessionStoreTest {
                 position = 1,
                 lastUsageIndex = 1,
             )
+            assertThat(database.sessionDataQueries.count().executeAsOneOrNull()).isEqualTo(1)
             databaseSessionStore.addSession(secondSessionData.toApiModel())
             assertThat(awaitItem().size).isEqualTo(2)
+            assertThat(database.sessionDataQueries.count().executeAsOneOrNull()).isEqualTo(2)
             databaseSessionStore.removeSession(aSessionData.userId)
             assertThat(awaitItem().size).isEqualTo(1)
+            assertThat(database.sessionDataQueries.count().executeAsOneOrNull()).isEqualTo(1)
             databaseSessionStore.removeSession(secondSessionData.userId)
             assertThat(awaitItem()).isEmpty()
+            assertThat(database.sessionDataQueries.count().executeAsOneOrNull()).isEqualTo(0)
         }
     }
 

libraries/session-storage/test/src/main/kotlin/io/element/android/libraries/sessionstorage/test/InMemorySessionStore.kt

@@ -67,6 +67,10 @@ class InMemorySessionStore(
         return sessionDataListFlow.value
     }
 
+    override suspend fun numberOfSessions(): Int {
+        return sessionDataListFlow.value.size
+    }
+
     override suspend fun getLatestSession(): SessionData? {
         return sessionDataListFlow.value.firstOrNull()
     }