Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Remove default parameter values.

Browse source 
This improve code coverage since some default value was never used.
This commit is contained in:
Benoit Marty 2024-11-26 09:18:11 +01:00
parent 67274bcc68
commit c88b54fe2b
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/attachments/preview/AttachmentsPreviewPresenter.kt
View file

@ -235,6 +235,7 @@ class AttachmentsPreviewPresenter @AssistedInject constructor(
mediaSender.sendPreProcessedMedia( mediaSender.sendPreProcessedMedia(
mediaUploadInfo = mediaUploadInfo, mediaUploadInfo = mediaUploadInfo,
caption = caption, caption = caption,
formattedCaption = null,
progressCallback = progressCallback progressCallback = progressCallback
).getOrThrow() ).getOrThrow()
}.fold( }.fold(

6
libraries/mediaupload/api/src/main/kotlin/io/element/android/libraries/mediaupload/api/MediaSender.kt
View file

@ -43,9 +43,9 @@ class MediaSender @Inject constructor(
suspend fun sendPreProcessedMedia( suspend fun sendPreProcessedMedia(
mediaUploadInfo: MediaUploadInfo, mediaUploadInfo: MediaUploadInfo,
caption: String? = null, caption: String?,
formattedCaption: String? = null, formattedCaption: String?,
progressCallback: ProgressCallback? = null progressCallback: ProgressCallback?,
): Result<Unit> { ): Result<Unit> {
return room.sendMedia( return room.sendMedia(
uploadInfo = mediaUploadInfo, uploadInfo = mediaUploadInfo,