Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 9 Projects Releases Packages Wiki Activity Actions

Pin create : improve clear validation

Browse source
This commit is contained in:
ganfra 2023-10-19 12:16:30 +02:00
parent 63fbb4412b
commit cbd2ba50e7
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
features/lockscreen/impl/src/main/kotlin/io/element/android/features/lockscreen/impl/create/CreatePinPresenter.kt
View file

@ -59,7 +59,6 @@ class CreatePinPresenter @Inject constructor(
if (confirmPinEntry == choosePinEntry) { if (confirmPinEntry == choosePinEntry) {
//pinCodeManager.savePin(confirmPinEntry.toText()) //pinCodeManager.savePin(confirmPinEntry.toText())
} else { } else {
confirmPinEntry = PinEntry.empty(PIN_SIZE)
creationFailure = PinCreationFailure.ConfirmationPinNotMatching creationFailure = PinCreationFailure.ConfirmationPinNotMatching
} }
} }
@ -68,7 +67,6 @@ class CreatePinPresenter @Inject constructor(
if (choosePinEntry.isPinComplete()) { if (choosePinEntry.isPinComplete()) {
when (val pinValidationResult = pinValidator.isPinValid(choosePinEntry)) { when (val pinValidationResult = pinValidator.isPinValid(choosePinEntry)) {
is PinValidator.Result.Invalid -> { is PinValidator.Result.Invalid -> {
choosePinEntry = PinEntry.empty(PIN_SIZE)
creationFailure = pinValidationResult.failure creationFailure = pinValidationResult.failure
} }
PinValidator.Result.Valid -> isConfirmationStep = true PinValidator.Result.Valid -> isConfirmationStep = true
@ -77,6 +75,17 @@ class CreatePinPresenter @Inject constructor(
} }
} }
CreatePinEvents.OnClearValidationFailure -> { CreatePinEvents.OnClearValidationFailure -> {
when (creationFailure) {
is PinCreationFailure.ConfirmationPinNotMatching -> {
choosePinEntry = PinEntry.empty(PIN_SIZE)
confirmPinEntry = PinEntry.empty(PIN_SIZE)
}
is PinCreationFailure.ChosenPinBlacklisted -> {
choosePinEntry = PinEntry.empty(PIN_SIZE)
}
null -> Unit
}
isConfirmationStep = false
creationFailure = null creationFailure = null
} }
} }