Replace notification permission dialog with a screen (#1223)

* Replace notification permission dialog with a screen

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>

appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInPresenter.kt

@@ -16,8 +16,6 @@
 
 package io.element.android.appnav.loggedin
 
-import android.Manifest
-import android.os.Build
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.collectAsState
@@ -30,8 +28,6 @@ import io.element.android.features.networkmonitor.api.NetworkStatus
 import io.element.android.libraries.architecture.Presenter
 import io.element.android.libraries.matrix.api.MatrixClient
 import io.element.android.libraries.matrix.api.roomlist.RoomListService
-import io.element.android.libraries.permissions.api.PermissionsPresenter
-import io.element.android.libraries.permissions.noop.NoopPermissionsPresenter
 import io.element.android.libraries.push.api.PushService
 import kotlinx.coroutines.delay
 import javax.inject.Inject
@@ -40,20 +36,10 @@ private const val DELAY_BEFORE_SHOWING_SYNC_SPINNER_IN_MILLIS = 1500L
 
 class LoggedInPresenter @Inject constructor(
     private val matrixClient: MatrixClient,
-    private val permissionsPresenterFactory: PermissionsPresenter.Factory,
     private val networkMonitor: NetworkMonitor,
     private val pushService: PushService,
 ) : Presenter<LoggedInState> {
 
-    private val postNotificationPermissionsPresenter by lazy {
-        // Ask for POST_NOTIFICATION PERMISSION on Android 13+
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
-            permissionsPresenterFactory.create(Manifest.permission.POST_NOTIFICATIONS)
-        } else {
-            NoopPermissionsPresenter()
-        }
-    }
-
     @Composable
     override fun present(): LoggedInState {
         LaunchedEffect(Unit) {
@@ -66,7 +52,6 @@ class LoggedInPresenter @Inject constructor(
 
         val roomListState by matrixClient.roomListService.state.collectAsState()
         val networkStatus by networkMonitor.connectivity.collectAsState()
-        val permissionsState = postNotificationPermissionsPresenter.present()
         var showSyncSpinner by remember {
             mutableStateOf(false)
         }
@@ -82,7 +67,6 @@ class LoggedInPresenter @Inject constructor(
         }
         return LoggedInState(
             showSyncSpinner = showSyncSpinner,
-            permissionsState = permissionsState,
         )
     }
 }

appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInState.kt

@@ -16,9 +16,6 @@
 
 package io.element.android.appnav.loggedin
 
-import io.element.android.libraries.permissions.api.PermissionsState
-
 data class LoggedInState(
     val showSyncSpinner: Boolean,
-    val permissionsState: PermissionsState,
 )

appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInStateProvider.kt

@@ -17,7 +17,6 @@
 package io.element.android.appnav.loggedin
 
 import androidx.compose.ui.tooling.preview.PreviewParameterProvider
-import io.element.android.libraries.permissions.api.createDummyPostNotificationPermissionsState
 
 open class LoggedInStateProvider : PreviewParameterProvider<LoggedInState> {
     override val values: Sequence<LoggedInState>
@@ -32,5 +31,4 @@ fun aLoggedInState(
     showSyncSpinner: Boolean = true,
 ) = LoggedInState(
     showSyncSpinner = showSyncSpinner,
-    permissionsState = createDummyPostNotificationPermissionsState(),
 )

appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInView.kt

@@ -23,21 +23,16 @@ import androidx.compose.foundation.layout.systemBarsPadding
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.tooling.preview.PreviewParameter
 import androidx.compose.ui.unit.dp
-import io.element.android.libraries.androidutils.system.openAppSettingsPage
 import io.element.android.libraries.designsystem.preview.DayNightPreviews
 import io.element.android.libraries.designsystem.preview.ElementPreview
-import io.element.android.libraries.permissions.api.PermissionsView
 
 @Composable
 fun LoggedInView(
     state: LoggedInState,
     modifier: Modifier = Modifier
 ) {
-    val context = LocalContext.current
-
     Box(
         modifier = modifier
             .fillMaxSize()
@@ -49,10 +44,6 @@ fun LoggedInView(
                 .align(Alignment.TopCenter),
             isVisible = state.showSyncSpinner,
         )
-        PermissionsView(
-            state = state.permissionsState,
-            openSystemSettings = context::openAppSettingsPage
-        )
     }
 }
 

appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt

@@ -26,8 +26,6 @@ import io.element.android.libraries.matrix.api.MatrixClient
 import io.element.android.libraries.matrix.api.roomlist.RoomListService
 import io.element.android.libraries.matrix.test.FakeMatrixClient
 import io.element.android.libraries.matrix.test.roomlist.FakeRoomListService
-import io.element.android.libraries.permissions.api.PermissionsPresenter
-import io.element.android.libraries.permissions.noop.NoopPermissionsPresenter
 import io.element.android.libraries.push.api.PushService
 import io.element.android.libraries.pushproviders.api.Distributor
 import io.element.android.libraries.pushproviders.api.PushProvider
@@ -43,7 +41,7 @@ class LoggedInPresenterTest {
             presenter.present()
         }.test {
             val initialState = awaitItem()
-            assertThat(initialState.permissionsState.permission).isEmpty()
+            assertThat(initialState.showSyncSpinner).isFalse()
         }
     }
 
@@ -68,11 +66,6 @@ class LoggedInPresenterTest {
     ): LoggedInPresenter {
         return LoggedInPresenter(
             matrixClient = FakeMatrixClient(roomListService = roomListService),
-            permissionsPresenterFactory = object : PermissionsPresenter.Factory {
-                override fun create(permission: String): PermissionsPresenter {
-                    return NoopPermissionsPresenter()
-                }
-            },
             networkMonitor = FakeNetworkMonitor(networkStatus),
             pushService = object : PushService {
                 override fun notificationStyleChanged() {