Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Enable detekt rules AlsoCouldBeApply and fix existing issues.

Browse source
This commit is contained in:
Benoit Marty 2023-07-26 11:10:30 +02:00 • committed by Benoit Marty
parent 1d3aa2cd05
commit d433c3cbaa
4 changed files with 8 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/oidc/customtab/CustomTabHandler.kt
View file

@ -41,8 +41,7 @@ class CustomTabHandler @Inject constructor(
if (packageName != null) { if (packageName != null) {
customTabsServiceConnection = object : CustomTabsServiceConnection() { customTabsServiceConnection = object : CustomTabsServiceConnection() {
override fun onCustomTabsServiceConnected(name: ComponentName, client: CustomTabsClient) { override fun onCustomTabsServiceConnected(name: ComponentName, client: CustomTabsClient) {
customTabsClient = client customTabsClient = client.apply { warmup(0L) }
.also { it.warmup(0L) }
prefetchUrl(url) prefetchUrl(url)
} }

2
libraries/dateformatter/impl/src/test/kotlin/io/element/android/libraries/dateformatter/impl/DefaultLastMessageTimestampFormatterTest.kt
View file

@ -101,7 +101,7 @@ class DefaultLastMessageTimestampFormatterTest {
* Create DefaultLastMessageFormatter and set current time to the provided date. * Create DefaultLastMessageFormatter and set current time to the provided date.
*/ */
private fun createFormatter(@Suppress("SameParameterValue") currentDate: String): LastMessageTimestampFormatter { private fun createFormatter(@Suppress("SameParameterValue") currentDate: String): LastMessageTimestampFormatter {
val clock = FakeClock().also { it.givenInstant(Instant.parse(currentDate)) } val clock = FakeClock().apply { givenInstant(Instant.parse(currentDate)) }
val localDateTimeProvider = LocalDateTimeProvider(clock, TimeZone.UTC) val localDateTimeProvider = LocalDateTimeProvider(clock, TimeZone.UTC)
val dateFormatters = DateFormatters(Locale.US, clock, TimeZone.UTC) val dateFormatters = DateFormatters(Locale.US, clock, TimeZone.UTC)
return DefaultLastMessageTimestampFormatter(localDateTimeProvider, dateFormatters) return DefaultLastMessageTimestampFormatter(localDateTimeProvider, dateFormatters)

11
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/avatar/AvatarDataProvider.kt
View file

@ -20,19 +20,16 @@ import androidx.compose.ui.tooling.preview.PreviewParameterProvider
open class AvatarDataProvider : PreviewParameterProvider<AvatarData> { open class AvatarDataProvider : PreviewParameterProvider<AvatarData> {
override val values: Sequence<AvatarData> override val values: Sequence<AvatarData>
get() { get() = AvatarSize.values()
AvatarSize.values() .asSequence()
.also { it.sortBy { item -> item.name } } .map {
.asSequence()
return AvatarSize.values().asSequence().map {
sequenceOf( sequenceOf(
anAvatarData(size = it), anAvatarData(size = it),
anAvatarData(size = it).copy(name = null), anAvatarData(size = it).copy(name = null),
anAvatarData(size = it).copy(url = "aUrl"), anAvatarData(size = it).copy(url = "aUrl"),
) )
} }
.flatten() .flatten()
}
} }
fun anAvatarData( fun anAvatarData(

2
tools/detekt/detekt.yml
View file

@ -1,6 +1,8 @@
# Default rules: https://github.com/detekt/detekt/blob/main/detekt-core/src/main/resources/default-detekt-config.yml # Default rules: https://github.com/detekt/detekt/blob/main/detekt-core/src/main/resources/default-detekt-config.yml
style: style:
AlsoCouldBeApply:
active: true
CascadingCallWrapping: CascadingCallWrapping:
active: true active: true
includeElvis: true includeElvis: true