Fix test and add tests.

This commit is contained in:
Benoit Marty 2024-12-12 17:37:57 +01:00 committed by Benoit Marty
parent 8966e64e50
commit d9e28816bc
4 changed files with 31 additions and 4 deletions

View file

@ -50,6 +50,7 @@ import io.element.android.libraries.matrix.test.timeline.anEventTimelineItem
import io.element.android.libraries.mediaviewer.api.MediaInfo import io.element.android.libraries.mediaviewer.api.MediaInfo
import io.element.android.libraries.mediaviewer.test.util.FileExtensionExtractorWithoutValidation import io.element.android.libraries.mediaviewer.test.util.FileExtensionExtractorWithoutValidation
import kotlinx.collections.immutable.persistentListOf import kotlinx.collections.immutable.persistentListOf
import kotlinx.collections.immutable.toImmutableList
import org.junit.Test import org.junit.Test
import kotlin.time.Duration.Companion.seconds import kotlin.time.Duration.Companion.seconds
@ -163,6 +164,7 @@ class DefaultEventItemFactoryTest {
senderAvatar = null, senderAvatar = null,
dateSent = "0 Day false", dateSent = "0 Day false",
dateSentFull = "0 Full false", dateSentFull = "0 Full false",
waveform = null,
), ),
mediaSource = MediaSource(""), mediaSource = MediaSource(""),
) )
@ -211,6 +213,7 @@ class DefaultEventItemFactoryTest {
senderAvatar = null, senderAvatar = null,
dateSent = "0 Day false", dateSent = "0 Day false",
dateSentFull = "0 Full false", dateSentFull = "0 Full false",
waveform = null,
), ),
mediaSource = MediaSource(""), mediaSource = MediaSource(""),
thumbnailSource = null, thumbnailSource = null,
@ -242,7 +245,7 @@ class DefaultEventItemFactoryTest {
) )
) )
assertThat(result).isEqualTo( assertThat(result).isEqualTo(
MediaItem.File( MediaItem.Audio(
id = A_UNIQUE_ID, id = A_UNIQUE_ID,
eventId = AN_EVENT_ID, eventId = AN_EVENT_ID,
mediaInfo = MediaInfo( mediaInfo = MediaInfo(
@ -256,8 +259,11 @@ class DefaultEventItemFactoryTest {
senderAvatar = null, senderAvatar = null,
dateSent = "0 Day false", dateSent = "0 Day false",
dateSentFull = "0 Full false", dateSentFull = "0 Full false",
waveform = null,
), ),
mediaSource = MediaSource(""), mediaSource = MediaSource(""),
duration = "7:36",
waveform = null,
) )
) )
} }
@ -305,6 +311,7 @@ class DefaultEventItemFactoryTest {
senderAvatar = null, senderAvatar = null,
dateSent = "0 Day false", dateSent = "0 Day false",
dateSentFull = "0 Full false", dateSentFull = "0 Full false",
waveform = null,
), ),
mediaSource = MediaSource(""), mediaSource = MediaSource(""),
thumbnailSource = null, thumbnailSource = null,
@ -333,7 +340,7 @@ class DefaultEventItemFactoryTest {
), ),
details = AudioDetails( details = AudioDetails(
duration = 456.seconds, duration = 456.seconds,
waveform = persistentListOf(), waveform = persistentListOf(1f, 2f),
) )
) )
) )
@ -341,7 +348,7 @@ class DefaultEventItemFactoryTest {
) )
) )
assertThat(result).isEqualTo( assertThat(result).isEqualTo(
MediaItem.File( MediaItem.Audio(
id = A_UNIQUE_ID, id = A_UNIQUE_ID,
eventId = AN_EVENT_ID, eventId = AN_EVENT_ID,
mediaInfo = MediaInfo( mediaInfo = MediaInfo(
@ -355,8 +362,11 @@ class DefaultEventItemFactoryTest {
senderAvatar = null, senderAvatar = null,
dateSent = "0 Day false", dateSent = "0 Day false",
dateSentFull = "0 Full false", dateSentFull = "0 Full false",
waveform = listOf(1f, 2f).toImmutableList(),
), ),
mediaSource = MediaSource(""), mediaSource = MediaSource(""),
duration = "7:36",
waveform = listOf(1f, 2f).toImmutableList(),
) )
) )
} }
@ -403,6 +413,7 @@ class DefaultEventItemFactoryTest {
senderAvatar = null, senderAvatar = null,
dateSent = "0 Day false", dateSent = "0 Day false",
dateSentFull = "0 Full false", dateSentFull = "0 Full false",
waveform = null,
), ),
mediaSource = MediaSource(""), mediaSource = MediaSource(""),
thumbnailSource = null, thumbnailSource = null,

View file

@ -11,6 +11,7 @@ import com.google.common.truth.Truth.assertThat
import io.element.android.libraries.architecture.AsyncData import io.element.android.libraries.architecture.AsyncData
import io.element.android.libraries.matrix.api.core.UniqueId import io.element.android.libraries.matrix.api.core.UniqueId
import io.element.android.libraries.matrix.test.AN_EXCEPTION import io.element.android.libraries.matrix.test.AN_EXCEPTION
import io.element.android.libraries.mediaviewer.impl.gallery.ui.aMediaItemAudio
import io.element.android.libraries.mediaviewer.impl.gallery.ui.aMediaItemDateSeparator import io.element.android.libraries.mediaviewer.impl.gallery.ui.aMediaItemDateSeparator
import io.element.android.libraries.mediaviewer.impl.gallery.ui.aMediaItemFile import io.element.android.libraries.mediaviewer.impl.gallery.ui.aMediaItemFile
import io.element.android.libraries.mediaviewer.impl.gallery.ui.aMediaItemImage import io.element.android.libraries.mediaviewer.impl.gallery.ui.aMediaItemImage
@ -23,6 +24,9 @@ class MediaItemsPostProcessorTest {
private val file1 = aMediaItemFile(id = UniqueId("1")) private val file1 = aMediaItemFile(id = UniqueId("1"))
private val file2 = aMediaItemFile(id = UniqueId("2")) private val file2 = aMediaItemFile(id = UniqueId("2"))
private val file3 = aMediaItemFile(id = UniqueId("3")) private val file3 = aMediaItemFile(id = UniqueId("3"))
private val audio1 = aMediaItemAudio(id = UniqueId("1"))
private val audio2 = aMediaItemAudio(id = UniqueId("2"))
private val audio3 = aMediaItemAudio(id = UniqueId("3"))
private val image1 = aMediaItemImage(id = UniqueId("1")) private val image1 = aMediaItemImage(id = UniqueId("1"))
private val image2 = aMediaItemImage(id = UniqueId("2")) private val image2 = aMediaItemImage(id = UniqueId("2"))
private val image3 = aMediaItemImage(id = UniqueId("3")) private val image3 = aMediaItemImage(id = UniqueId("3"))
@ -68,6 +72,7 @@ class MediaItemsPostProcessorTest {
fun `process will reorder files`() { fun `process will reorder files`() {
test( test(
mediaItems = listOf( mediaItems = listOf(
audio1,
file3, file3,
file2, file2,
file1, file1,
@ -79,6 +84,7 @@ class MediaItemsPostProcessorTest {
file1, file1,
file2, file2,
file3, file3,
audio1,
), ),
) )
} }
@ -106,6 +112,7 @@ class MediaItemsPostProcessorTest {
fun `process will split images, videos and files`() { fun `process will split images, videos and files`() {
test( test(
mediaItems = listOf( mediaItems = listOf(
audio1,
file1, file1,
image1, image1,
video1, video1,
@ -119,6 +126,7 @@ class MediaItemsPostProcessorTest {
expectedFileItems = listOf( expectedFileItems = listOf(
date1, date1,
file1, file1,
audio1,
), ),
) )
} }
@ -155,6 +163,9 @@ class MediaItemsPostProcessorTest {
fun `process will handle complex case`() { fun `process will handle complex case`() {
test( test(
mediaItems = listOf( mediaItems = listOf(
audio3,
audio2,
audio1,
file1, file1,
image1, image1,
video1, video1,
@ -178,6 +189,9 @@ class MediaItemsPostProcessorTest {
expectedFileItems = listOf( expectedFileItems = listOf(
date1, date1,
file1, file1,
audio1,
audio2,
audio3,
date3, date3,
file3, file3,
loading1, loading1,

View file

@ -48,7 +48,8 @@ class AndroidLocalMediaFactoryTest {
senderName = A_USER_NAME, senderName = A_USER_NAME,
senderAvatar = null, senderAvatar = null,
dateSent = "12:34", dateSent = "12:34",
dateSentFull = "full" dateSentFull = "full",
waveform = null,
) )
) )
} }

View file

@ -42,6 +42,7 @@ class FakeLocalMediaFactory(
senderAvatar = null, senderAvatar = null,
dateSent = null, dateSent = null,
dateSentFull = null, dateSentFull = null,
waveform = null,
) )
return aLocalMedia(uri, mediaInfo) return aLocalMedia(uri, mediaInfo)
} }