Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable SyncNotificationsWithWorkManager in nightly and debug builds (#5573)

Browse source 
* Enable `SyncNotificationsWithWorkManager` in nightly and debug builds

* Fix tests
This commit is contained in:
Jorge Martin Espinosa 2025-10-22 16:55:40 +02:00 • committed by GitHub
parent e9bd9a86ed
commit dd395a5214
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlags.kt
View file

@ -114,7 +114,8 @@ enum class FeatureFlags(
title = "Sync notifications with WorkManager",
description = "Use WorkManager to schedule notification sync tasks when a push is received." +
" This should improve reliability and battery usage.",
defaultValue = { false },
// Enable by default on nightly and debug builds so we can get feedback before enabling it for everyone.
defaultValue = { meta -> meta.buildType != BuildType.RELEASE },
isFinished = false,
),
}

2
libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/push/DefaultPushHandlerTest.kt
View file

@ -690,7 +690,7 @@ class DefaultPushHandlerTest {
notificationChannels: FakeNotificationChannels = FakeNotificationChannels(),
pushHistoryService: PushHistoryService = FakePushHistoryService(),
syncOnNotifiableEvent: SyncOnNotifiableEvent = SyncOnNotifiableEvent {},
featureFlagService: FakeFeatureFlagService = FakeFeatureFlagService(),
featureFlagService: FakeFeatureFlagService = FakeFeatureFlagService(initialState = mapOf(FeatureFlags.SyncNotificationsWithWorkManager.key to false)),
workManagerScheduler: FakeWorkManagerScheduler = FakeWorkManagerScheduler(),
): DefaultPushHandler {
return DefaultPushHandler(