Improve FeatureFlagService API.

libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlagService.kt

@@ -35,7 +35,12 @@ interface FeatureFlagService {
     suspend fun setFeatureEnabled(feature: Feature, enabled: Boolean): Boolean
 
     /**
-     * @return the list of available (not finished) features that can be toggled.
+     * @return the list of available features that can be toggled.
+     * @param includeFinishFeatures whether to include finished features, default is false
+     * @param isInLabs whether the user is in labs (to include lab features), default is false
      */
-    fun getAvailableFeatures(): List<Feature>
+    fun getAvailableFeatures(
+        includeFinishFeatures: Boolean = false,
+        isInLabs: Boolean = false,
+    ): List<Feature>
 }

libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagService.kt

@@ -40,7 +40,13 @@ class DefaultFeatureFlagService(
             ?: false
     }
 
-    override fun getAvailableFeatures(): List<Feature> {
-        return FeatureFlags.entries.filter { !it.isFinished }
+    override fun getAvailableFeatures(
+        includeFinishFeatures: Boolean,
+        isInLabs: Boolean,
+    ): List<Feature> {
+        return FeatureFlags.entries.filter { flag ->
+            (includeFinishFeatures || !flag.isFinished) &&
+                flag.isInLabs == isInLabs
+        }
     }
 }

libraries/featureflag/test/src/main/java/io/element/android/libraries/featureflag/test/FakeFeatureFlagService.kt

@@ -33,7 +33,10 @@ class FakeFeatureFlagService(
         return enabledFeatures.getOrPut(feature.key) { MutableStateFlow(feature.defaultValue(buildMeta)) }
     }
 
-    override fun getAvailableFeatures(): List<Feature> {
+    override fun getAvailableFeatures(
+        includeFinishFeatures: Boolean,
+        isInLabs: Boolean,
+    ): List<Feature> {
         return providedAvailableFeatures
     }
 }