Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2957 from element-hq/feature/bma/konsistClassName

Browse source 
Konsist class name
This commit is contained in:
Benoit Marty 2024-05-31 13:02:01 +02:00 • committed by GitHub
commit e29f919abc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
39 changed files with 131 additions and 143 deletions
Download patch file Download diff file Expand all files Collapse all files

41
tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistClassNameTest.kt
View file

@ -20,8 +20,12 @@ import androidx.compose.ui.tooling.preview.PreviewParameterProvider
import com.bumble.appyx.core.node.Node
import com.lemonappdev.konsist.api.Konsist
import com.lemonappdev.konsist.api.ext.list.withAllParentsOf
import com.lemonappdev.konsist.api.ext.list.withAnnotationNamed
import com.lemonappdev.konsist.api.ext.list.withNameContaining
import com.lemonappdev.konsist.api.ext.list.withNameEndingWith
import com.lemonappdev.konsist.api.ext.list.withoutName
import com.lemonappdev.konsist.api.ext.list.withoutNameStartingWith
import com.lemonappdev.konsist.api.verify.assertEmpty
import com.lemonappdev.konsist.api.verify.assertTrue
import io.element.android.libraries.architecture.Presenter
import org.junit.Test
@ -81,4 +85,41 @@ class KonsistClassNameTest {
it.parents().any { parent -> parent.name.replace(".", "") == interfaceName }
}
}
@Test
fun `Class implementing interface should have name not end with 'Impl' but start with 'Default'`() {
Konsist.scopeFromProject()
.classes()
.withNameEndingWith("Impl")
.withoutName("MediaUploadHandlerImpl")
.assertEmpty(additionalMessage = "Class implementing interface should have name not end with 'Impl' but start with 'Default'")
}
@Test
fun `Class with 'ContributeBinding' annotation should have allowed prefix`() {
Konsist.scopeFromProject()
.classes()
.withAnnotationNamed("ContributesBinding")
.withoutName(
"Factory",
"TimelineController",
)
.withoutNameStartingWith(
"Accompanist",
"AES",
"Android",
"Database",
"DBov",
"Default",
"DataStore",
"FileExtensionExtractor",
"KeyStore",
"Matrix",
"Noop",
"Preferences",
"Rust",
"SharedPreferences",
)
.assertEmpty()
}
}