Remove context(parentNode: Node) and provide the parent Node as a parameter.
This commit is contained in:
parent
45400d70d2
commit
e70d767183
161 changed files with 668 additions and 436 deletions
|
|
@ -16,8 +16,12 @@ import io.element.android.libraries.matrix.api.core.RoomAlias
|
|||
import io.element.android.libraries.matrix.api.room.alias.ResolvedRoomAlias
|
||||
|
||||
interface RoomAliasResolverEntryPoint : FeatureEntryPoint {
|
||||
context(parentNode: Node)
|
||||
fun createNode(buildContext: BuildContext, params: Params, callback: Callback): Node
|
||||
fun createNode(
|
||||
parentNode: Node,
|
||||
buildContext: BuildContext,
|
||||
params: Params,
|
||||
callback: Callback,
|
||||
): Node
|
||||
|
||||
interface Callback : Plugin {
|
||||
fun onAliasResolved(data: ResolvedRoomAlias)
|
||||
|
|
|
|||
|
|
@ -16,8 +16,8 @@ import io.element.android.libraries.architecture.createNode
|
|||
|
||||
@ContributesBinding(AppScope::class)
|
||||
class DefaultRoomAliasResolverEntryPoint : RoomAliasResolverEntryPoint {
|
||||
context(parentNode: Node)
|
||||
override fun createNode(
|
||||
parentNode: Node,
|
||||
buildContext: BuildContext,
|
||||
params: RoomAliasResolverEntryPoint.Params,
|
||||
callback: RoomAliasResolverEntryPoint.Callback,
|
||||
|
|
|
|||
|
|
@ -43,13 +43,12 @@ class DefaultRoomAliasResolverEntryPointTest {
|
|||
val params = RoomAliasResolverEntryPoint.Params(
|
||||
roomAlias = A_ROOM_ALIAS
|
||||
)
|
||||
val result = with(parentNode) {
|
||||
entryPoint.createNode(
|
||||
buildContext = BuildContext.root(null),
|
||||
params = params,
|
||||
callback = callback,
|
||||
)
|
||||
}
|
||||
val result = entryPoint.createNode(
|
||||
parentNode = parentNode,
|
||||
buildContext = BuildContext.root(null),
|
||||
params = params,
|
||||
callback = callback,
|
||||
)
|
||||
assertThat(result).isInstanceOf(RoomAliasResolverNode::class.java)
|
||||
assertThat(result.plugins).contains(params)
|
||||
assertThat(result.plugins).contains(callback)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue