From eafac31ccce1556b218a267e432143c5706435c1 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Wed, 1 Feb 2023 15:08:31 +0100 Subject: [PATCH] No need to use a dispatcher. Fix issue detected by sonar: `Remove this dispatcher. It is pointless when used with only suspending functions.` --- .../io/element/android/libraries/matrix/RustMatrixClient.kt | 2 +- .../libraries/matrix/sync/SlidingSyncObserverProxy.kt | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/RustMatrixClient.kt b/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/RustMatrixClient.kt index b9631cd6ca..c6b9bef6e0 100644 --- a/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/RustMatrixClient.kt +++ b/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/RustMatrixClient.kt @@ -87,7 +87,7 @@ internal class RustMatrixClient internal constructor( .addView(slidingSyncView) .build() - private val slidingSyncObserverProxy = SlidingSyncObserverProxy(coroutineScope, dispatchers) + private val slidingSyncObserverProxy = SlidingSyncObserverProxy(coroutineScope) private val roomSummaryDataSource: RustRoomSummaryDataSource = RustRoomSummaryDataSource( slidingSyncObserverProxy.updateSummaryFlow, diff --git a/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/sync/SlidingSyncObserverProxy.kt b/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/sync/SlidingSyncObserverProxy.kt index 5774e23cb4..148880f320 100644 --- a/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/sync/SlidingSyncObserverProxy.kt +++ b/libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/sync/SlidingSyncObserverProxy.kt @@ -16,7 +16,6 @@ package io.element.android.libraries.matrix.sync -import io.element.android.libraries.core.coroutine.CoroutineDispatchers import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.flow.MutableSharedFlow import kotlinx.coroutines.flow.SharedFlow @@ -30,7 +29,6 @@ private const val BUFFER_SIZE = 64 class SlidingSyncObserverProxy( private val coroutineScope: CoroutineScope, - private val coroutineDispatchers: CoroutineDispatchers ) : SlidingSyncObserver { private val updateSummaryMutableFlow = @@ -39,8 +37,8 @@ class SlidingSyncObserverProxy( override fun didReceiveSyncUpdate(summary: UpdateSummary) { if (summary.rooms.isEmpty()) return - coroutineScope.launch(coroutineDispatchers.io) { - updateSummaryMutableFlow.emit(summary) + coroutineScope.launch { + updateSummaryMutableFlow.tryEmit(summary) } } }