Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Avoid hard-coded number and update the related test.

Browse source
This commit is contained in:
Benoit Marty 2023-09-05 14:55:53 +02:00 • committed by Benoit Marty
parent 9e1c8279b2
commit eb2810e467
2 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/colors/AvatarColors.kt
View file

@ -42,6 +42,6 @@ fun avatarColors(userId: String): AvatarColors {
} }
internal fun String.toHash(): Int { internal fun String.toHash(): Int {
return toList().sumOf { it.code } % 8 return toList().sumOf { it.code } % avatarColorsLight.size
} }

7
libraries/designsystem/src/test/kotlin/io/element/android/libraries/designsystem/colors/AvatarColorsTest.kt
View file

@ -24,11 +24,8 @@ import org.junit.Test
class AvatarColorsTest { class AvatarColorsTest {
@Test @Test
fun `ensure list size`() { fun `ensure the size of the avatar color are equal for light and dark theme`() {
// avatarColorsDark and avatarColorsLight size must not be modified. assertThat(avatarColorsDark.size).isEqualTo(avatarColorsLight.size)
// 8 is used as a hard-coded modulo in `String.toHash()` extension.
assertThat(avatarColorsDark.size).isEqualTo(8)
assertThat(avatarColorsLight.size).isEqualTo(8)
} }
@Test @Test