Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Always use the latest... fix.

Browse source
This commit is contained in:
Benoit Marty 2024-01-23 18:13:02 +01:00 • committed by Benoit Marty
parent 3ced570b3c
commit eb51b49aef
9 changed files with 49 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

7
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/async/AsyncActionView.kt
View file

@ -18,6 +18,8 @@ package io.element.android.libraries.designsystem.components.async
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.rememberUpdatedState
import androidx.compose.ui.tooling.preview.PreviewParameter
import io.element.android.libraries.architecture.AsyncAction
import io.element.android.libraries.designsystem.components.ProgressDialog
@ -67,8 +69,9 @@ fun <T> AsyncActionView(
}
}
is AsyncAction.Success -> {
LaunchedEffect(async, onSuccess) {
onSuccess(async.data)
val latestOnSuccess by rememberUpdatedState(onSuccess)
LaunchedEffect(async) {
latestOnSuccess(async.data)
}
}
}

5
libraries/textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/SoftKeyboardEffect.kt
View file

@ -43,8 +43,9 @@ internal fun <T> SoftKeyboardEffect(
) {
val view = LocalView.current
val latestOnRequestFocus by rememberUpdatedState(onRequestFocus)
LaunchedEffect(key, predicate) {
if (predicate(key)) {
val latestPredicate by rememberUpdatedState(predicate)
LaunchedEffect(key) {
if (latestPredicate(key)) {
// Await window focus in case returning from a dialog
view.awaitWindowFocus()