Replace notification permission dialog with a screen (#1223)

* Replace notification permission dialog with a screen

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>

libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/AccompanistPermissionStateProvider.kt

@@ -26,13 +26,13 @@ import com.squareup.anvil.annotations.ContributesBinding
 import io.element.android.libraries.di.AppScope
 import javax.inject.Inject
 
-interface PermissionStateProvider {
+interface ComposablePermissionStateProvider {
     @Composable
     fun provide(permission: String, onPermissionResult: (Boolean) -> Unit): PermissionState
 }
 
 @ContributesBinding(AppScope::class)
-class AccompanistPermissionStateProvider @Inject constructor() : PermissionStateProvider {
+class AccompanistPermissionStateProvider @Inject constructor() : ComposablePermissionStateProvider {
     @Composable
     override fun provide(permission: String, onPermissionResult: (Boolean) -> Unit): PermissionState {
         return rememberPermissionState(

libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/DefaultPermissionStateProvider.kt

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2023 New Vector Ltd
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.element.android.libraries.permissions.impl
+
+import android.content.Context
+import com.squareup.anvil.annotations.ContributesBinding
+import io.element.android.libraries.di.AppScope
+import io.element.android.libraries.di.ApplicationContext
+import io.element.android.libraries.di.SingleIn
+import io.element.android.libraries.permissions.api.PermissionStateProvider
+import io.element.android.libraries.permissions.api.PermissionsStore
+import kotlinx.coroutines.flow.Flow
+import javax.inject.Inject
+
+@SingleIn(AppScope::class)
+@ContributesBinding(AppScope::class)
+class DefaultPermissionStateProvider @Inject constructor(
+    @ApplicationContext private val context: Context,
+    private val permissionsStore: PermissionsStore,
+): PermissionStateProvider {
+    override fun isPermissionGranted(permission: String): Boolean {
+        return context.checkSelfPermission(permission) == android.content.pm.PackageManager.PERMISSION_GRANTED
+    }
+
+    override suspend fun setPermissionDenied(permission: String, value: Boolean) = permissionsStore.setPermissionDenied(permission, value)
+
+    override fun isPermissionDenied(permission: String): Flow<Boolean> = permissionsStore.isPermissionDenied(permission)
+
+    override suspend fun setPermissionAsked(permission: String, value: Boolean) = permissionsStore.setPermissionAsked(permission, value)
+
+    override fun isPermissionAsked(permission: String): Flow<Boolean> = permissionsStore.isPermissionAsked(permission)
+
+    override suspend fun resetPermission(permission: String) = permissionsStore.resetPermission(permission)
+}

libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/DefaultPermissionsPresenter.kt

@@ -38,6 +38,7 @@ import io.element.android.libraries.di.AppScope
 import io.element.android.libraries.permissions.api.PermissionsEvents
 import io.element.android.libraries.permissions.api.PermissionsPresenter
 import io.element.android.libraries.permissions.api.PermissionsState
+import io.element.android.libraries.permissions.api.PermissionsStore
 import kotlinx.coroutines.launch
 import timber.log.Timber
 
@@ -46,7 +47,7 @@ private val loggerTag = LoggerTag("DefaultPermissionsPresenter")
 class DefaultPermissionsPresenter @AssistedInject constructor(
     @Assisted val permission: String,
     private val permissionsStore: PermissionsStore,
-    private val permissionStateProvider: PermissionStateProvider,
+    private val composablePermissionStateProvider: ComposablePermissionStateProvider,
 ) : PermissionsPresenter {
 
     @AssistedFactory
@@ -90,7 +91,7 @@ class DefaultPermissionsPresenter @AssistedInject constructor(
             }
         }
 
-        permissionState = permissionStateProvider.provide(
+        permissionState = composablePermissionStateProvider.provide(
             permission = permission,
             onPermissionResult = ::onPermissionResult
         )

libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/DefaultPermissionsStore.kt

@@ -26,6 +26,7 @@ import com.squareup.anvil.annotations.ContributesBinding
 import io.element.android.libraries.core.bool.orFalse
 import io.element.android.libraries.di.AppScope
 import io.element.android.libraries.di.ApplicationContext
+import io.element.android.libraries.permissions.api.PermissionsStore
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.map
 import javax.inject.Inject
@@ -34,7 +35,7 @@ private val Context.dataStore: DataStore<Preferences> by preferencesDataStore(na
 
 @ContributesBinding(AppScope::class)
 class DefaultPermissionsStore @Inject constructor(
-    @ApplicationContext context: Context,
+    @ApplicationContext private val context: Context,
 ) : PermissionsStore {
     private val store = context.dataStore
 

libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/FakePermissionStateProvider.kt

@@ -0,0 +1,53 @@
+/*
+ * Copyright (c) 2023 New Vector Ltd
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.element.android.libraries.permissions.impl
+
+import io.element.android.libraries.permissions.api.PermissionStateProvider
+import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.flow.MutableStateFlow
+
+class FakePermissionStateProvider(
+    private var permissionGranted: Boolean = true,
+    permissionDenied: Boolean = false,
+    permissionAsked: Boolean = false,
+): PermissionStateProvider {
+    private val permissionDeniedFlow = MutableStateFlow(permissionDenied)
+    private val permissionAskedFlow = MutableStateFlow(permissionAsked)
+
+    fun setPermissionGranted() {
+        permissionGranted = true
+    }
+
+    override fun isPermissionGranted(permission: String): Boolean = permissionGranted
+
+    override suspend fun setPermissionDenied(permission: String, value: Boolean) {
+        permissionDeniedFlow.value = value
+    }
+
+    override fun isPermissionDenied(permission: String): Flow<Boolean> = permissionDeniedFlow
+
+    override suspend fun setPermissionAsked(permission: String, value: Boolean) {
+        permissionAskedFlow.value = value
+    }
+
+    override fun isPermissionAsked(permission: String): Flow<Boolean> = permissionAskedFlow
+
+    override suspend fun resetPermission(permission: String) {
+        setPermissionAsked(permission, false)
+        setPermissionDenied(permission, false)
+    }
+}

libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/PermissionsStore.kt

@@ -1,32 +0,0 @@
-/*
- * Copyright (c) 2023 New Vector Ltd
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package io.element.android.libraries.permissions.impl
-
-import kotlinx.coroutines.flow.Flow
-
-interface PermissionsStore {
-    suspend fun setPermissionDenied(permission: String, value: Boolean)
-    fun isPermissionDenied(permission: String): Flow<Boolean>
-
-    suspend fun setPermissionAsked(permission: String, value: Boolean)
-    fun isPermissionAsked(permission: String): Flow<Boolean>
-
-    suspend fun resetPermission(permission: String)
-
-    // To debug
-    suspend fun resetStore()
-}