Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 9 Projects Releases Packages Wiki Activity Actions

Put developer settings at the end of the view

Browse source 
It used to be before "Sign out" which once the developer setting was
enabled went over the build version. So clicking 8 times on the build
version instead of 7 to enable dev settings was signing out the user.
This commit is contained in:
sim 2025-09-22 09:01:41 +02:00
parent 0ed32a9227
commit efa3a2fc3a
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/root/PreferencesRootView.kt
View file

@ -214,9 +214,6 @@ private fun ColumnScope.GeneralSection(
leadingContent = ListItemContent.Icon(IconSource.Vector(CompoundIcons.Settings())), leadingContent = ListItemContent.Icon(IconSource.Vector(CompoundIcons.Settings())),
onClick = onOpenAdvancedSettings, onClick = onOpenAdvancedSettings,
) )
if (state.showDeveloperSettings) {
DeveloperPreferencesView(onOpenDeveloperSettings)
}
ListItem( ListItem(
headlineContent = { Text(stringResource(id = CommonStrings.action_signout)) }, headlineContent = { Text(stringResource(id = CommonStrings.action_signout)) },
leadingContent = ListItemContent.Icon(IconSource.Vector(CompoundIcons.SignOut())), leadingContent = ListItemContent.Icon(IconSource.Vector(CompoundIcons.SignOut())),
@ -231,6 +228,10 @@ private fun ColumnScope.GeneralSection(
onClick = onDeactivateClick, onClick = onDeactivateClick,
) )
} }
// Put developer settings at the end, so nothing bad happens if the user clicks 8 times to enable the entry
if (state.showDeveloperSettings) {
DeveloperPreferencesView(onOpenDeveloperSettings)
}
} }
@Composable @Composable