Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Remove useless try catch.

Browse source
This commit is contained in:
Benoit Marty 2023-11-27 10:47:19 +01:00 • committed by Benoit Marty
parent 0fe93ded92
commit f1ec4b68fc
1 changed files with 9 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

25
libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/RoomGroupMessageCreator.kt
View file

@ -30,7 +30,6 @@ import io.element.android.libraries.push.impl.notifications.debug.annotateForDeb
import io.element.android.libraries.push.impl.notifications.factories.NotificationCreator import io.element.android.libraries.push.impl.notifications.factories.NotificationCreator
import io.element.android.libraries.push.impl.notifications.model.NotifiableMessageEvent import io.element.android.libraries.push.impl.notifications.model.NotifiableMessageEvent
import io.element.android.services.toolbox.api.strings.StringProvider import io.element.android.services.toolbox.api.strings.StringProvider
import timber.log.Timber
import javax.inject.Inject import javax.inject.Inject
class RoomGroupMessageCreator @Inject constructor( class RoomGroupMessageCreator @Inject constructor(
@ -133,22 +132,16 @@ class RoomGroupMessageCreator @Inject constructor(
} }
private fun createRoomMessagesGroupSummaryLine(events: List<NotifiableMessageEvent>, roomName: String, roomIsDirect: Boolean): CharSequence { private fun createRoomMessagesGroupSummaryLine(events: List<NotifiableMessageEvent>, roomName: String, roomIsDirect: Boolean): CharSequence {
return try { return when (events.size) {
when (events.size) { 1 -> createFirstMessageSummaryLine(events.first(), roomName, roomIsDirect)
1 -> createFirstMessageSummaryLine(events.first(), roomName, roomIsDirect) else -> {
else -> { stringProvider.getQuantityString(
stringProvider.getQuantityString( R.plurals.notification_compat_summary_line_for_room,
R.plurals.notification_compat_summary_line_for_room, events.size,
events.size, roomName,
roomName, events.size
events.size )
)
}
} }
} catch (e: Throwable) {
// String not found or bad format
Timber.v("%%%%%%%% REFRESH NOTIFICATION DRAWER failed to resolve string")
roomName
} }
} }