Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rename Event for clarity

Browse source
This commit is contained in:
Benoit Marty 2023-09-21 11:29:29 +02:00
parent 4b928af21b
commit f3456cafa7
9 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/DefaultPermissionsPresenter.kt
View file

@ -110,7 +110,7 @@ class DefaultPermissionsPresenter @AssistedInject constructor(
PermissionsEvents.CloseDialog -> {
showDialog.value = false
}
PermissionsEvents.OpenSystemDialog -> {
PermissionsEvents.AskPermissionToUser -> {
if (permissionState.status !is PermissionStatus.Granted && isAlreadyDenied) {
showDialog.value = true
} else {

10
libraries/permissions/impl/src/test/kotlin/io/element/android/libraries/permissions/impl/DefaultPermissionsPresenterTest.kt
View file

@ -91,7 +91,7 @@ class DefaultPermissionsPresenterTest {
}.test {
skipItems(1)
val initialState = awaitItem()
initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
val withDialogState = awaitItem()
assertThat(withDialogState.showDialog).isTrue()
withDialogState.eventSink.invoke(PermissionsEvents.CloseDialog)
@ -120,7 +120,7 @@ class DefaultPermissionsPresenterTest {
}.test {
val initialState = awaitItem()
assertThat(initialState.showDialog).isFalse()
initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
assertThat(permissionState.launchPermissionRequestCalled).isTrue()
// User does not grant permission
permissionStateProvider.userGiveAnswer(answer = false, firstTime = true)
@ -154,7 +154,7 @@ class DefaultPermissionsPresenterTest {
}.test {
val initialState = awaitItem()
assertThat(initialState.showDialog).isFalse()
initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
assertThat(permissionState.launchPermissionRequestCalled).isTrue()
// User does not grant permission
permissionStateProvider.userGiveAnswer(answer = false, firstTime = false)
@ -192,7 +192,7 @@ class DefaultPermissionsPresenterTest {
}.test {
skipItems(1)
val initialState = awaitItem()
initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
val withDialogState = awaitItem()
assertThat(withDialogState.showDialog).isTrue()
assertThat(withDialogState.permissionGranted).isFalse()
@ -222,7 +222,7 @@ class DefaultPermissionsPresenterTest {
}.test {
val initialState = awaitItem()
assertThat(initialState.showDialog).isFalse()
initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
assertThat(permissionState.launchPermissionRequestCalled).isTrue()
// User grants permission
permissionStateProvider.userGiveAnswer(answer = true, firstTime = true)