Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix crash when recording long voice message.

Browse source
This commit is contained in:
Benoit Marty 2025-11-26 17:14:33 +01:00
parent e3315406c5
commit f5dacb7b2f
4 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/composer/DefaultVoiceMessageComposerPresenter.kt
View file

@ -192,7 +192,10 @@ class DefaultVoiceMessageComposerPresenter(
voiceMessageState = when (val state = recorderState) { voiceMessageState = when (val state = recorderState) {
is VoiceRecorderState.Recording -> VoiceMessageState.Recording( is VoiceRecorderState.Recording -> VoiceMessageState.Recording(
duration = state.elapsedTime, duration = state.elapsedTime,
levels = state.levels.toImmutableList(), levels = state.levels
// Keep only the last 128 samples for display, else we can have a crash
.takeLast(128)
.toImmutableList(),
) )
is VoiceRecorderState.Finished -> is VoiceRecorderState.Finished ->
previewState( previewState(

5
libraries/textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt
View file

@ -299,7 +299,10 @@ fun TextComposer(
onSeek = onSeekVoiceMessage, onSeek = onSeekVoiceMessage,
) )
is VoiceMessageState.Recording -> is VoiceMessageState.Recording ->
VoiceMessageRecording(voiceMessageState.levels, voiceMessageState.duration) VoiceMessageRecording(
levels = voiceMessageState.levels,
duration = voiceMessageState.duration,
)
VoiceMessageState.Idle -> {} VoiceMessageState.Idle -> {}
} }
} }

2
libraries/textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/components/LiveWaveformView.kt
View file

@ -54,7 +54,7 @@ fun LiveWaveformView(
var parentWidth by remember { mutableIntStateOf(0) } var parentWidth by remember { mutableIntStateOf(0) }
val waveformWidth by remember(levels, lineWidth, linePadding) { val waveformWidth by remember(levels.size, lineWidth, linePadding) {
derivedStateOf { derivedStateOf {
levels.size * (lineWidth.value + linePadding.value) levels.size * (lineWidth.value + linePadding.value)
} }

2
libraries/textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/components/VoiceMessageRecording.kt
View file

@ -74,7 +74,7 @@ internal fun VoiceMessageRecording(
modifier = Modifier modifier = Modifier
.height(26.dp) .height(26.dp)
.weight(1f), .weight(1f),
levels = levels levels = levels,
) )
} }
} }