Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix Poll history 'Load more' button alignment (#2577)

Browse source 
* Fix Poll history 'Load more' button alignment

* Update screenshots

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
This commit is contained in:
Jorge Martin Espinosa 2024-03-21 12:51:43 +01:00 • committed by GitHub
parent d6cd4ef37c
commit fb5ab95401
4 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryStateProvider.kt
View file

@ -41,6 +41,11 @@ class PollHistoryStateProvider : PreviewParameterProvider<PollHistoryState> {
activeFilter = PollHistoryFilter.PAST, activeFilter = PollHistoryFilter.PAST,
currentItems = emptyList(), currentItems = emptyList(),
), ),
aPollHistoryState(
activeFilter = PollHistoryFilter.PAST,
currentItems = emptyList(),
hasMoreToLoad = true,
),
) )
} }

1
features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryView.kt
View file

@ -191,6 +191,7 @@ private fun PollHistoryList(
Column( Column(
modifier = Modifier.fillParentMaxSize().padding(bottom = 24.dp), modifier = Modifier.fillParentMaxSize().padding(bottom = 24.dp),
verticalArrangement = Arrangement.Center, verticalArrangement = Arrangement.Center,
horizontalAlignment = Alignment.CenterHorizontally,
) { ) {
val emptyStringResource = if (filter == PollHistoryFilter.PAST) { val emptyStringResource = if (filter == PollHistoryFilter.PAST) {
stringResource(R.string.screen_polls_history_empty_past) stringResource(R.string.screen_polls_history_empty_past)

3
tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Day-1_2_null_4,NEXUS_5,1.0,en].png Normal file
View file

@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:821058570014a0418b22eb4119122b595f802cabeffcabe30c9085b1485ab2c2
size 19568

3
tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Night-1_3_null_4,NEXUS_5,1.0,en].png Normal file
View file

@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:a174fd40ab7fa21541c6cf2e25edbe3f286c5aaf7103ec8cf6c4dbc94bba373e
size 18512