Fix sonar issue: do not ignore result of File:delete().

This commit is contained in:
Benoit Marty 2023-02-01 14:46:00 +01:00
parent 68dff27326
commit fce1569ee3
6 changed files with 44 additions and 6 deletions

View file

@ -0,0 +1,34 @@
/*
* Copyright (c) 2023 New Vector Ltd
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.element.android.libraries.androidutils.file
import io.element.android.libraries.core.data.tryOrNull
import timber.log.Timber
import java.io.File
fun File.safeDelete() {
tryOrNull(
onError = {
Timber.e(it, "Error, unable to delete file $path")
},
operation = {
if (delete().not()) {
Timber.w("Warning, unable to delete file $path")
}
}
)
}

View file

@ -32,7 +32,7 @@ fun compressFile(file: File): File? {
val dstFile = file.resolveSibling(file.name + ".gz")
if (dstFile.exists()) {
dstFile.delete()
dstFile.safeDelete()
}
return try {