Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Add more preview for Destructive ListItem. It reveals some errors.

Browse source
This commit is contained in:
Benoit Marty 2024-10-18 12:38:16 +02:00 • committed by Benoit Marty
parent 35aefedc41
commit fe896883e2
1 changed files with 66 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

72
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/ListItem.kt
View file

@ -147,8 +147,8 @@ fun ListItem(
headlineContent = decoratedHeadlineContent, headlineContent = decoratedHeadlineContent,
modifier = if (onClick != null) { modifier = if (onClick != null) {
Modifier Modifier
.clickable(enabled = enabled, onClick = onClick) .clickable(enabled = enabled, onClick = onClick)
.then(modifier) .then(modifier)
} else { } else {
modifier modifier
}, },
@ -377,15 +377,75 @@ internal fun ListItemPrimaryActionWithIconPreview() = PreviewItems.OneLineListIt
// endregion // endregion
// region: Error state // region: Error state
@Preview(name = "List item - Error", group = PreviewGroup.ListItems) @Preview(name = "List item (2 lines) - Simple - Error", group = PreviewGroup.ListItems)
@Composable @Composable
internal fun ListItemErrorPreview() = PreviewItems.OneLineListItemPreview(style = ListItemStyle.Destructive) internal fun ListItemTwoLinesSimpleErrorPreview() = PreviewItems.TwoLinesListItemPreview(
style = ListItemStyle.Destructive
)
@Preview(name = "List item - Error & Icon", group = PreviewGroup.ListItems) @Preview(name = "List item (2 lines) - Trailing Checkbox - Error", group = PreviewGroup.ListItems)
@Composable @Composable
internal fun ListItemErrorWithIconPreview() = PreviewItems.OneLineListItemPreview( internal fun ListItemTwoLinesTrailingCheckBoxErrorPreview() = PreviewItems.TwoLinesListItemPreview(
trailingContent = PreviewItems.checkbox(),
style = ListItemStyle.Destructive, style = ListItemStyle.Destructive,
)
@Preview(name = "List item (2 lines) - Trailing RadioButton - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesTrailingRadioButtonErrorPreview() = PreviewItems.TwoLinesListItemPreview(
trailingContent = PreviewItems.radioButton(),
style = ListItemStyle.Destructive,
)
@Preview(name = "List item (2 lines) - Trailing Switch - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesTrailingSwitchErrorPreview() = PreviewItems.TwoLinesListItemPreview(
trailingContent = PreviewItems.switch(),
style = ListItemStyle.Destructive,
)
@Preview(name = "List item (2 lines) - Trailing Icon - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesTrailingIconErrorPreview() = PreviewItems.TwoLinesListItemPreview(
trailingContent = PreviewItems.icon(),
style = ListItemStyle.Destructive,
)
// region: Leading Checkbox
@Preview(name = "List item (2 lines) - Leading Checkbox - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesLeadingCheckboxErrorPreview() = PreviewItems.TwoLinesListItemPreview(
leadingContent = PreviewItems.checkbox(),
style = ListItemStyle.Destructive,
)
@Preview(name = "List item (2 lines) - Leading RadioButton - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesLeadingRadioButtonErrorPreview() = PreviewItems.TwoLinesListItemPreview(
leadingContent = PreviewItems.radioButton(),
style = ListItemStyle.Destructive,
)
@Preview(name = "List item (2 lines) - Leading Switch - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesLeadingSwitchErrorPreview() = PreviewItems.TwoLinesListItemPreview(
leadingContent = PreviewItems.switch(),
style = ListItemStyle.Destructive,
)
@Preview(name = "List item (2 lines) - Leading Icon - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesLeadingIconErrorPreview() = PreviewItems.TwoLinesListItemPreview(
leadingContent = PreviewItems.icon(), leadingContent = PreviewItems.icon(),
style = ListItemStyle.Destructive,
)
@Preview(name = "List item (2 lines) - Both Icons - Error", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemTwoLinesBothIconsErrorPreview() = PreviewItems.TwoLinesListItemPreview(
leadingContent = PreviewItems.icon(),
trailingContent = PreviewItems.icon(),
style = ListItemStyle.Destructive,
) )
// endregion // endregion