Commit graph

1414 commits

Author SHA1 Message Date
Marco Romano
2a82e1b4e4 Async API improvements "v2" (#672)
* Async API improvements "v2"

**NB: This PR actually changes only 3 files in `libraries/architecture/`. All the other changes are automated refactors to fix the calling code.**

This is a proposal for improvements to our `Async` type as discussed in: https://github.com/vector-im/element-x-android/pull/598/files#r1230664392 and in other chats.

Please bear in mind it is just a proposal, I'd love to hear your feedback about it, especially when it comes to naming: I've tried to make parameter and function names use a terminology similar to what we find in the Kotlin stdlib and its `Result` type.

I'm inclined to like more the non-extension flavours of the new `run*` APIs, though I'd also like your feedback about what API shape you prefer.

### Summary of the changes:
#### Functional
- Adds `exceptionOrNull()` API to complement the existing `dataOrNull()` API.
- Adds `isFailure()`, `isLoading()`, `isSuccess()` and `isUninitialized()` courtesy APIs.
- Renames `executeResult()` to `runUpdatingState()`:
	- Becomes the base API to which all the other similarly named APIs call into.
	- Makes it inline.
	- Adds contract.
	- Passes over any `prevData` to newre Async states.
	- Passes through the `block`s return value.
	- Adds unit tests.
- Renames `execute` to `runCatchingUpdatingState()` and makes it just call into `runUpdatingState()`
- Adds extension function overloads to the `run*` functions to accept `MutableState` as receiver

#### Cosmetics
- Reorders classes and methods in alphabetic order.
- Reorder parameter names to mimic conventions in Kotlin stdlib.
- Adds docstrings where useful.

* Use `fold()`

* rename pop to popFirst

* Add docstrings

* Please Detekt

* Rename exception to error.

* Please detekt

* Update existing usages.
2023-06-27 13:37:23 +02:00
Benoit Marty
4cb9843415 Now that the composer as been removed, we do not need element resource module anymore. 2023-06-27 13:34:55 +02:00
ganfra
dc06b5266f RoomList: branch invites 2023-06-27 12:52:06 +02:00
ganfra
2a24d0196e Merge branch 'develop' into feature/fga/room_list_api 2023-06-27 10:47:50 +02:00
ganfra
c64608e03e RoomList/Timeline: makes sure initial values are set before computing diff/update 2023-06-27 10:47:14 +02:00
Benoit Marty
287328f7df More cleanup 2023-06-27 09:51:33 +02:00
Benoit Marty
4a8c49fa28 Use CommonStrings everywhere 2023-06-27 09:45:00 +02:00
Benoit Marty
90c39f5253 Introduce handy aliases to avoid writing this: import io.element.android.libraries.ui.strings.R as StringR 2023-06-27 09:45:00 +02:00
Marco Romano
8101f42979 Add sendLocation API to Rust Room (#681)
Will be used by the location sharing feature.
2023-06-27 09:12:17 +02:00
renovate[bot]
ff135352d8 Update dependency org.matrix.rustcomponents:sdk-android to v0.1.24 (#675)
* Update dependency org.matrix.rustcomponents:sdk-android to v0.1.24

* Add new `filterByPushRules`.
Only existing usage of this API will set this param to `true` in order to not change the current behavior.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marco Romano <marcor@element.io>
2023-06-27 08:29:36 +02:00
ganfra
208850c0f5 RoomList: fix small error in update processing 2023-06-26 22:58:54 +02:00
ganfra
7ba14b3014 RoomList/Timeline : Add Buffer(Unlimited) to avoid blocking rust listener thread 2023-06-26 22:32:59 +02:00
ganfra
5090bff06a RoomList: update LoadingState and fix a crash 2023-06-26 22:30:12 +02:00
ganfra
e2772fb292 Timeline: refactor a bit 2023-06-26 18:18:48 +02:00
ganfra
e5c86675a4 RoomList: more rework on RoomSummaryDataSource 2023-06-26 18:02:53 +02:00
Marco Romano
ffc9d1e82e Refine handleSnackbarMessage API (#676)
As per our offline convos during a PR review.
2023-06-26 16:29:50 +02:00
Benoit Marty
a226580c8c Move FileSizeFormatter to module :libraries:androidutils 2023-06-26 11:14:53 +02:00
Benoit Marty
f1019f3444 Move cache management to a dedicated class and in the setting module, for clarity. 2023-06-26 11:07:53 +02:00
Benoit Marty
375ac17e14 Move content to to File.kt. Also remove deleteAllFiles, we have deleteRecursively now. 2023-06-26 11:07:53 +02:00
Benoit Marty
b563b1ec95 Idx -> Index 2023-06-26 11:07:53 +02:00
Benoit Marty
fc61d452c6 Fix typo in comment. 2023-06-26 11:07:53 +02:00
Benoit Marty
32ddc7e6f7 Ensure all file about sqlite are deleted. 2023-06-26 11:07:53 +02:00
Benoit Marty
89d4969833 Implement missing methods in Fake class. 2023-06-26 11:07:53 +02:00
Benoit Marty
12e54ac080 Lazy usage of OkHttpClient 2023-06-26 11:07:53 +02:00
Benoit Marty
5fe186f9de var -> val 2023-06-26 11:07:53 +02:00
Benoit Marty
1c06943530 Close the client before removing its data. Probably safer. 2023-06-26 11:07:22 +02:00
Benoit Marty
58860a9440 Close the client before deleting data, and ensure the app is restarted, using a cache Index. 2023-06-26 11:07:22 +02:00
Benoit Marty
df4bc3d7ce Improve rendering of cache size (and fix compilation issue) 2023-06-26 11:07:22 +02:00
Benoit Marty
2809d6fc2f Improve FileSizeFormatter.format API. 2023-06-26 11:06:36 +02:00
Benoit Marty
ac60ef0cbe Move FileSizeFormatter to a new module for injectable Android utilities. 2023-06-26 11:06:36 +02:00
Benoit Marty
5d8adb25ae Display cache size in the developer settings (#643) 2023-06-26 11:06:36 +02:00
Benoit Marty
bf80c251aa Add clear cache action in the developer settings (#643) 2023-06-26 11:06:36 +02:00
Benoit Marty
ee033a2aa4 Improve PreferenceText rendering, in particular center the test on the right vertically, add padding in add more previews. 2023-06-26 11:06:36 +02:00
bmarty
9c5c578c67 Sync Strings from Localazy 2023-06-26 00:10:53 +00:00
ganfra
e392f15872 Merge branch 'develop' into feature/fga/room_list_api 2023-06-23 18:14:09 +02:00
ganfra
6489d4bbfd Merge pull request #667 from vector-im/update-rust-sdk-0.1.23
Update rust sdk 0.1.23
2023-06-23 17:40:23 +02:00
ganfra
d85ef79f20 Rust sdk update: make the project compiling 2023-06-23 17:22:08 +02:00
ganfra
bb4f61fe12 RoomList: try syncing when network is back and inError state 2023-06-23 17:07:27 +02:00
Jorge Martin Espinosa
95f65e2031 [Message Actions] Copy events to clipboard (#665)
* Add `Copy` action for text events

* Remove 'Copy' action from the list for non-text events

* Use `@ContributesBinding` to inject `AndroidClipboardHelper`.
2023-06-23 14:39:07 +00:00
Jorge Martin Espinosa
bdb1841e44 [Message Actions] Report messages (#642)
* Add report messages feature

* Try to improve how snackbars are delivered

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-06-23 10:44:47 +02:00
Marco Romano
898985cb9b Expose new windowInsets param from ModalBottomSheet (#662)
Part of new public API in compose.material3:1.1.1
2023-06-23 09:57:21 +02:00
ganfra
3176cad7e2 RoomList: introduces a SyncService 2023-06-22 16:50:53 +02:00
Jorge Martin Espinosa
de7bbbd5cf [Message Actions] Forward messages (#635)
* Add forwarding messages base

* Make forwarding single-selection

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-06-22 13:27:59 +02:00
ganfra
8ce65b4429 RoomList: change a bit the api of RoomSummaryDataSource 2023-06-22 12:34:07 +02:00
ganfra
6446f2f6a7 RoomList: start/stop sync in resume/pause callbacks 2023-06-22 12:21:10 +02:00
ganfra
5a9f0caed7 Merge branch 'develop' into feature/fga/room_list_api 2023-06-22 11:31:49 +02:00
ganfra
0d0a5571af Rust sdk update: make the app compile 2023-06-22 09:50:17 +02:00
ganfra
b3e11d184a CanSendEvent default to true and branch refresh mechanism... 2023-06-21 17:43:08 +02:00
ganfra
7c8df186f6 Room/Timeline: simplify the apis 2023-06-21 16:25:18 +02:00
Benoit Marty
4b55641aae Merge pull request #631 from vector-im/feature/bma/sendPermission
Take into acount send permission (power level)
2023-06-21 11:35:33 +02:00