Commit graph

229 commits

Author SHA1 Message Date
Jorge Martin Espinosa
a5bad53c62
Iterate design on several screens: update icons, replace PreferenceTexts (#1771)
- Batch import new icons from the design team.
- Rename _september icons since they're just extra icons that need to be integrated in Compound in the future, and it should be ok if we don't distinguish between ic_september_*, ic_november_* etc., so all icons are now simply ic_* in the designsystem module.
- Create a new CompoundIconListPreviewProvider to add chunked lists of icons for previews. Add an exception for it to Konsist.
- Move some icons to use Compound icons.
- Remove most PreferenceText usages, use ListItem instead.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-15 10:52:37 +01:00
Benoit Marty
2cb0060f96 Add a View to show the beginning of the timeline (parity with iOS) 2023-11-14 17:31:42 +01:00
Benoit Marty
74c13a7f79 Cleanup 2023-11-14 14:11:34 +01:00
Benoit Marty
0adc3b1f1d Localazy: move screen_notification_settings_ strings to the :features:preferences:impl module.
Need to also import `screen_notification_settings_edit_failed_updating_default_mode` to the module `:features:roomdetails:impl`.
2023-11-14 11:12:35 +01:00
ElementBot
3bf34eae01
Sync Strings (#1789)
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
2023-11-13 12:31:34 +01:00
Benoit Marty
64b7c906db
Merge pull request #1742 from vector-im/sync-localazy
Sync Strings
2023-11-06 16:05:01 +01:00
Benoit Marty
8cd4ac3303 Use AsyncView in RoomNotificationSettingsView and UserDefinedRoomNotificationSettingsView 2023-11-06 10:09:41 +01:00
Benoit Marty
fb4216c827 Use AsyncView in RoomDetailsEditView 2023-11-06 10:09:41 +01:00
bmarty
2fca8412b2 Sync Strings from Localazy 2023-11-06 08:23:40 +00:00
bmarty
ffd02b831e Sync Strings from Localazy 2023-10-30 14:50:36 +00:00
ganfra
ca6a30d6cc PIN : fix quality 2023-10-26 15:25:40 +02:00
David Langley
75e95333a8 Unit and Snapshot tests for error and loading states. 2023-10-24 21:39:53 +01:00
David Langley
1239edb4a6 Merge branch 'dla/feature/custom_room_notification_settings_list' of https://github.com/vector-im/element-x-android into dla/feature/custom_room_notification_settings_list 2023-10-24 19:15:18 +01:00
David Langley
02de87235a Fix indentation 2023-10-24 19:15:14 +01:00
David Langley
4784235f8d
Merge branch 'develop' into dla/feature/custom_room_notification_settings_list 2023-10-24 17:20:15 +01:00
David Langley
117614d59d Fix compile error. 2023-10-24 17:14:48 +01:00
David Langley
03315ae77b Merge branch 'dla/feature/custom_room_notification_settings_list' of https://github.com/vector-im/element-x-android into dla/feature/room_notification_settings_ui_update 2023-10-24 16:36:27 +01:00
David Langley
5324eb0f1a Address comments
- Add additional states to preview.
- Add TODO description for commented code
- Move showUserDefinedSettingStyle from the node to the view for testability.
2023-10-24 16:27:26 +01:00
Benoit Marty
aadfb79945 Test coverage: Add missing preview for RoomDetailsView. 2023-10-24 17:17:15 +02:00
David Langley
5adcaef569 Add new ui for room notifications screen
- Add new ui for room notifications screen
- Fix error when changing default notification setting.
2023-10-20 21:08:44 +01:00
David Langley
f1cf9b6e31 Fix typo and preview 2023-10-19 16:57:35 +01:00
David Langley
7505ac8eda Fix tests and lint 2023-10-19 16:17:57 +01:00
David Langley
b5ca65ed0f Fix enabled state and ClearError events. 2023-10-18 22:30:29 +01:00
David Langley
87b8bfe99d Merge branch 'develop' of https://github.com/vector-im/element-x-android into dla/feature/custom_room_notification_settings_list 2023-10-18 22:07:14 +01:00
David Langley
8d6ef153d9 Fix switch and radio buttons toggling to invalid intermediate states. 2023-10-18 21:44:37 +01:00
David Langley
895a5332f2 Add tests 2023-10-17 16:08:35 +01:00
David Langley
eadaa2f65c List user define room notification settings
- List user define room notification settings
- Add new user defined style of the room notification settings view
- Add navigation to expose room notification settings ui to the global settings
- Add Progress indicators
- Improve error handing
2023-10-17 16:08:08 +01:00
bmarty
586a53653d Sync Strings from Localazy 2023-10-16 00:09:47 +00:00
Benoit Marty
a2601c0388 Remove unused import 2023-10-12 14:15:22 +02:00
Benoit Marty
4338d821e5 Konsist: improve test about no default value for State classes, and fix new detected issues. 2023-10-10 21:42:18 +02:00
Benoit Marty
97fea4e6dd data object 2023-10-10 17:31:04 +02:00
Benoit Marty
0bc2020411 Konsist: add test Function which creates Presenter in test MUST be named 'createPresenterName', and fix existing issues 2023-10-10 17:31:04 +02:00
Benoit Marty
d55df22db2 Konsist: add test Data class state MUST not have default value, and fix existing issues 2023-10-10 17:31:04 +02:00
Benoit Marty
8929a90970 Konsist: add test to ensure filename match top level Composable View, and fix existing issue 2023-10-10 15:39:22 +02:00
Benoit Marty
de39179b9d
Merge pull request #1465 from vector-im/feature/bma/codeCoverage
Improve code coverage
2023-10-02 10:18:31 +02:00
bmarty
7e3b9d8d3b Sync Strings from Localazy 2023-10-02 00:09:47 +00:00
Benoit Marty
10366e7445 Follow naming convention and cleanup the module. 2023-09-29 17:06:58 +02:00
Benoit Marty
9e251f618d Use generic common_people 2023-09-28 16:40:44 +02:00
bmarty
c72bb92ef2 Sync Strings from Localazy 2023-09-25 00:09:17 +00:00
Benoit Marty
0255ec6771
Merge pull request #1400 from vector-im/feature/bma/fixCrashPhoto
Fix crash when user wants to use the camera
2023-09-21 16:31:36 +02:00
Benoit Marty
d19b624c6f Rename Event for clarity 2023-09-21 15:33:03 +02:00
Benoit Marty
1b5aa7adaa Test that permission is requested, instead of giving the permission directly. 2023-09-21 15:00:47 +02:00
Benoit Marty
dd5d67d186 Move open system setting to the PermissionsPresenter 2023-09-21 14:20:41 +02:00
Benoit Marty
08b455afd3 Create FakePermissionsPresenterFactory, to reduce boilerplate. 2023-09-21 12:54:15 +02:00
Benoit Marty
e4ca2484ba Resume action once persmission has been granted. 2023-09-21 12:16:30 +02:00
Benoit Marty
dcb1677bf1 Open app settings from the permission dialog. 2023-09-21 11:37:59 +02:00
Benoit Marty
f3456cafa7 Rename Event for clarity 2023-09-21 11:29:29 +02:00
Benoit Marty
31eca73e8d Request Camera permission before launching the external Camera app (#1395) 2023-09-21 10:54:02 +02:00
Benoit Marty
0e4c146e87 Detekt: Rename DayNightPreviews to PreviewsDayNight to follow naming convention.
MultiPreview annotations should start with `Previews` as prefix
2023-09-21 08:30:36 +02:00
Benoit Marty
97f2d211ae Detekt: Rename LargeHeightPreview to PreviewWithLargeHeight to follow naming convention.
MultiPreview annotations should start with `Preview` as prefix

Detekt: Rename `LargeHeightPreview` to `PreviewWithLargeHeight` to follow naming convention.
Custom Preview annotations should start with `Preview` as prefix
2023-09-21 08:30:15 +02:00