Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions
5668 commits 21 branches 0 tags 84 MiB
Commit graph

284 commits

Author SHA1 Message Date
Benoit Marty
72b89338b3 Remove Modifier parameter in private function when only default value is used. 
This will improve the code coverage metrics, and this also fixes a few potential bug, where the Modifier was used several times.
 2024-02-08 11:06:06 +01:00
bmarty
7911a26003 Sync Strings from Localazy 2024-02-05 00:09:59 +00:00
Jorge Martin Espinosa
7686fbbd07 Make the whole items in advanced settings screen clickable, standarize paddings (#2314) 
* Make sure the whole item in advanced settings screen triggers the toggle action

* Fix UI changes when setting `onChecked` actions to null.

* Fix padding in invite member list items

* Remove redundant `CheckableUserRow` alternatives.

* Use 4dp for padding instead

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2024-01-30 11:39:04 +00:00
ElementBot
3a37460814 Sync Strings (#2230) 
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
 2024-01-15 09:21:04 +01:00
Benoit Marty
a926b3d390 Merge branch 'develop' into feature/bma/sxcludePreviewFromCodeCoverage 2024-01-11 16:02:58 +01:00
Benoit Marty
72a363c244 Fix moar ktlint issues 2024-01-11 11:24:10 +01:00
Benoit Marty
378692f743 Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
renovate[bot]
7e9cda3aa9 Update plugin ktlint to v12.1.0 (#2200) 
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2024-01-10 16:22:24 +01:00
Benoit Marty
7fbe848243 Exclude ContentToPreview from coverage, either by using annotation @ExcludeFromCoverage, or by inlining it. 2024-01-09 17:56:01 +01:00
ganfra
c78ce88c53 Rename isFetchingSearchResults to showSearchLoader 2024-01-05 15:54:50 +01:00
ganfra
2f49de1fbb Rename SearchBarResultState.Empty to SearchBarResultState.Initial 2024-01-05 15:40:02 +01:00
ganfra
dbfa9b0dc6 Rename UserSearchResults as UserSearchResultState 2024-01-05 15:34:01 +01:00
ganfra
2a240d2496 Merge branch 'develop' into feature/fga/invite_user_loader 2024-01-05 14:02:58 +01:00
ganfra
60d015596f MatrixUserRepo : fix tests 2024-01-05 13:44:59 +01:00
ganfra
690a165411 User search : show a loader when fetching results 2024-01-04 21:27:44 +01:00
Benoit Marty
1dc6e5edb3 Clean up 2024-01-04 18:45:34 +01:00
Benoit Marty
d78ce21939 Rename AsyncView to AsyncActionView 2024-01-04 17:50:52 +01:00
Benoit Marty
bd91dd64e2 Rename Async to AsyncData 2024-01-04 16:30:56 +01:00
Benoit Marty
88d99d6623 Fix compilation issue with compose compiler 1.5.7 2023-12-28 12:41:02 +01:00
Benoit Marty
d9fb5ce007 Remove now useless ExperimentalLayoutApi opt in 2023-12-28 12:41:02 +01:00
bmarty
ada357b344 Sync Strings from Localazy 2023-12-26 09:39:48 +01:00
ganfra
9f045fc7de Fix detekt 2023-12-19 12:59:13 +01:00
ganfra
280d55bd6e BackstackParentNode now become BaseFlowNode and adds Overlay navModel into it. 2023-12-19 12:55:14 +01:00
Benoit Marty
d31909e049 Sync localazy using fixed script 2023-12-08 19:24:35 +01:00
Benoit Marty
b43ddd36b9 Run the script again. 2023-12-05 12:25:59 +01:00
bmarty
ad2ca01094 Sync Strings from Localazy 2023-12-04 00:09:56 +00:00
ganfra
8ff2454ed0 StartDMAction : small improvements after review 2023-12-01 11:28:29 +01:00
ganfra
cd28687eb4 StartDM : add tests 2023-11-30 18:05:26 +01:00
ganfra
118f1c1459 Add StartDMAction to further share code 2023-11-30 13:07:24 +01:00
ganfra
69d0a5c7b1 Creates a startDM method so we can reuse it for the new flow 2023-11-29 16:16:09 +01:00
Marco Romano
c69d610b6c Rename params in NodeFactories for clarity (#1916) 
- `context` is now `buildContext` to reflect that it's of type `BuildContext` (and not an android `Context`).
- `NODE` generic type param is now `N` to stick with Java convention: https://docs.oracle.com/javase/tutorial/java/generics/types.html.
 2023-11-29 10:01:07 +01:00
Jorge Martin Espinosa
a8b85fb4e6 Extract compound tokens and theming to compound-android library (#1888) 
* Replace tokens & icons with the external Compound ones

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2023-11-27 10:30:07 +01:00
Benoit Marty
d29219169a Merge pull request #1862 from vector-im/feature/bma/moreTests 
Remove lambda default value
 2023-11-24 11:00:34 +01:00
Benoit Marty
4ae0790cc1 Remove default value for lambda. 
We enforce a value to be provided and it's better for code coverage.
 2023-11-22 17:28:23 +01:00
Benoit Marty
5f8e85edc6 Prevent usage of hard-coded string for contentDescription, and fix existing issues. 2023-11-21 15:38:21 +01:00
Jorge Martin Espinosa
14cf2b0440 Iterate design on several screens: update icons, replace PreferenceTexts (#1771) 
- Batch import new icons from the design team.
- Rename _september icons since they're just extra icons that need to be integrated in Compound in the future, and it should be ok if we don't distinguish between ic_september_*, ic_november_* etc., so all icons are now simply ic_* in the designsystem module.
- Create a new CompoundIconListPreviewProvider to add chunked lists of icons for previews. Add an exception for it to Konsist.
- Move some icons to use Compound icons.
- Remove most PreferenceText usages, use ListItem instead.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2023-11-15 10:52:37 +01:00
Benoit Marty
044b6ac018 Use AsyncView in EditUserProfileView 2023-11-06 10:09:41 +01:00
Benoit Marty
ec62907ade Use AsyncView in CreateRoomRootView 2023-11-06 10:09:41 +01:00
Benoit Marty
ed450c49b4 Use AsyncView in ConfigureRoomView 2023-11-06 10:09:41 +01:00
Benoit Marty
c3cf49a5e4 Remove other useless lazy wrapping. 2023-11-02 16:28:50 +01:00
Benoit Marty
308a0c0f57 Konsist: add test to ensure filename match top level Composable View, and fix existing issue 2023-10-10 15:39:22 +02:00
bmarty
cd0a0f7c9a Sync Strings from Localazy 2023-10-02 00:09:47 +00:00
Benoit Marty
5119ca33dd Merge pull request #1400 from vector-im/feature/bma/fixCrashPhoto 
Fix crash when user wants to use the camera
 2023-09-21 16:31:36 +02:00
Benoit Marty
74fc9ad905 Rename Event for clarity 2023-09-21 15:33:03 +02:00
Benoit Marty
e130722b13 Test that permission is requested, instead of giving the permission directly. 2023-09-21 15:00:47 +02:00
Benoit Marty
ffcac2a0da Move open system setting to the PermissionsPresenter 2023-09-21 14:20:41 +02:00
Benoit Marty
9b72992d51 Create FakePermissionsPresenterFactory, to reduce boilerplate. 2023-09-21 12:54:15 +02:00
Benoit Marty
f91ca07a5e Resume action once persmission has been granted. 2023-09-21 12:16:30 +02:00
Benoit Marty
378d3ff9ab Open app settings from the permission dialog. 2023-09-21 11:37:59 +02:00
Benoit Marty
676b2cc66b Rename Event for clarity 2023-09-21 11:29:29 +02:00