Commit graph

924 commits

Author SHA1 Message Date
Benoit Marty
05cc526be9 Fix: ensure the effect is restarted on each sync update. 2024-01-30 10:19:53 +01:00
Benoit Marty
6406477fef Ensure that canUserJoinCall is "live" 2024-01-29 12:15:14 +01:00
Benoit Marty
96bae05184 Remove useless suspend modifier. 2024-01-29 12:13:36 +01:00
Benoit Marty
4f7d26eef0 Cleanup: no need to provide a CurrentSessionIdHolder, the sessionId can be retrieved from the room. 2024-01-29 12:12:52 +01:00
Benoit Marty
bfb6b32740 Send typing notification #2240 2024-01-26 16:30:43 +01:00
Jorge Martin Espinosa
7e58f719fe
Add 'send private read receipts' option in advanced settings (#2290)
* Add 'send private read receipts' option in advanced settings
* Create `SessionPreferencesStore` that stores the settings for the current use separate from those of the app.
* Rename `PreferencesStore` to `AppPreferencesStore` to split the preferences.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-26 10:06:26 +01:00
Jorge Martin Espinosa
15e3ecc88e
Update timeline items read receipts when the room members are loaded (#2194)
* Update timeline items' sender info and read receipts when the room members info is loaded

* Only update this info if we have loaded the room members
2024-01-24 08:07:15 +01:00
Benoit Marty
eb51b49aef Always use the latest... fix. 2024-01-23 18:13:33 +01:00
Benoit Marty
3ced570b3c Fix detekt issue:
Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior.

If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created.
However, if the effect is not to be restarted, you will need to use `rememberUpdatedState` on the parameter and use its result in the effect.

See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information. [LambdaParameterInRestartableEffect]
2024-01-23 18:13:33 +01:00
Benoit Marty
b3accdaa78 Remove unnecessary parenthesis. 2024-01-23 14:27:06 +01:00
Benoit Marty
addc8e3161 @Suppress("LargeClass") for test. 2024-01-23 14:25:16 +01:00
Benoit Marty
dac5a5ae30 Fix complexity error by extracting condition to a val. 2024-01-23 14:24:40 +01:00
Benoit Marty
f844399025 Fix API break: use new methods canUserRedactOwn and canUserRedactOther. 2024-01-23 13:32:13 +01:00
Jorge Martin Espinosa
18fba261e0
Edited text message bubbles should resize when edited (#2272)
* Make `ContentAvoidingLayoutScopeInstance` scope aware so message bubbles are resized when edited.

* Move back to using `Layout` instead of `SubcomposeLayout`
2024-01-22 17:53:10 +01:00
Benoit Marty
c3538e500d
Merge pull request #2130 from element-hq/feature/bma/roomListBadge
Some rework on the codebase
2024-01-22 10:17:38 +01:00
bmarty
4914c512fe Sync Strings from Localazy 2024-01-22 00:10:44 +00:00
Benoit Marty
5e359a4e73
Merge pull request #2221 from element-hq/feature/bma/displayNameAmbiguous
Display name disambiguation
2024-01-19 17:42:32 +01:00
Jorge Martin Espinosa
5d462d5ba9
Remove some state events at the start of DMs (#2252)
* Remove some initial events for DMs
2024-01-19 17:34:27 +01:00
Benoit Marty
b58ac4b02f Remove dead code. 2024-01-19 16:46:42 +01:00
Benoit Marty
2c691d527b Remove RoomSummaryDetails.lastMessageTimestamp and replace by a getter on lastMessage 2024-01-19 16:11:10 +01:00
Benoit Marty
d1c7520065 Rename avatarURLString to avatarUrl 2024-01-19 15:58:37 +01:00
Benoit Marty
4c86126eae Rename aRoomSummaryDetail to aRoomSummaryDetails 2024-01-19 15:55:26 +01:00
Jorge Martin Espinosa
27f55c0bc4
Replace 'leave room' text with 'leave conversation' for DMs (#2231)
* Replace 'leave room' text with 'leave conversation' for DMs

* Add `isDm` property to both `RoomSummary` and `RoomListRoomSummary`

* Remove redundant `leave_conversation_alert_subtitle_*` texts

* Fix maestro flow

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-16 15:49:44 +01:00
ElementBot
6bc080c279
Sync Strings (#2230)
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
2024-01-15 09:21:04 +01:00
Benoit Marty
14d5274d22 Display name disambiguation #2215.
Applied to:
- timeline message
- detail of timeline message
- reply preview of timeline message
- rendering of state Event
Not applied to:
- room last message
- room member list (we display the MatrixId here)
- room member detail page
2024-01-12 15:58:33 +01:00
Benoit Marty
4ba73c0bb1
Merge pull request #2202 from element-hq/feature/bma/removeReadReceiptFlag
Remove ReadReceipts feature flag.
2024-01-11 17:13:35 +01:00
Benoit Marty
9fab53e08c Ensure preview are not impacted when removing the ReadReceipt feature flag. 2024-01-11 15:58:36 +01:00
Benoit Marty
a83eaede1f Remove ReadReceipts feature flag. 2024-01-11 15:57:59 +01:00
Benoit Marty
d01c70a4fd Fix moar ktlint issues 2024-01-11 11:24:10 +01:00
Benoit Marty
5d086ad82d Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
Benoit Marty
a831f05f6e Fix ktlint issues 2024-01-10 19:33:39 +01:00
renovate[bot]
c8bd362397
Update plugin ktlint to v12.1.0 (#2200)
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-10 16:22:24 +01:00
Jorge Martin Espinosa
13e8e954d3
Improve rendering of voice messages in the timeline in large displays (#2199)
* Improve rendering of voice messages in the timeline in large displays

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-09 18:07:23 +01:00
Benoit Marty
2bdf2c0bbd
Merge pull request #1782 from element-hq/feature/bma/upgradeKover
Upgrade kover
2024-01-09 17:52:14 +01:00
Jorge Martin Espinosa
e8c6226586
Fix mention selector getting stuck when quickly deleting the prompt (#2195)
* Fix mention selector getting stuck when quickly deleting the prompt
2024-01-09 11:07:10 +00:00
Benoit Marty
54e499d0d0 Remove empty test module 2024-01-09 10:45:36 +01:00
Jorge Martin Espinosa
afacef0146
Hide keyboard when tapping on a message in the timeline (#2187)
* Hide keyboard when tapping on a message in the timeline if it would result in navigating to another screen
2024-01-08 14:02:57 +01:00
Benoit Marty
0756a2d3e4 exclude items.count(), which is not a valid index for the list. 2024-01-08 11:41:29 +01:00
Benoit Marty
08d78740ab Do not use sublist as it crashes if index > items.count(). Using range is safer.
Fix https://github.com/element-hq/element-x-android-rageshakes/issues/1301
2024-01-08 11:26:50 +01:00
Benoit Marty
b6f88f9792
Merge branch 'develop' into feature/bma/sendImageFromKeyboard 2024-01-08 08:59:00 +01:00
bmarty
9c6e511319 Sync Strings from Localazy 2024-01-08 00:10:36 +00:00
Jorge Martin Espinosa
3a2191ee43
Use SubcomposeLayout for ContentAvoidingLayout (#2171)
Use `SubcomposeLayout` for `ContentAvoidingLayout`
2024-01-05 12:40:25 +00:00
Jorge Martin Espinosa
e04780fbf6
Trim whitespace at the end of messages (#2169)
Trim whitespace at the end of messages
2024-01-05 12:40:10 +01:00
Jorge Martin Espinosa
4776fc5452
Fix crashes for extremely long messages with no line breaks (#2163) 2024-01-05 11:11:49 +00:00
Benoit Marty
49487481ec
Merge pull request #2166 from element-hq/feature/bma/fixFlakyTest
Introduce AsyncAction with a Confirmation state and use it for logout action
2024-01-05 10:30:43 +01:00
Benoit Marty
365c423190 Clean up 2024-01-04 18:45:34 +01:00
Benoit Marty
e42005fc52 Rename AsyncView to AsyncActionView 2024-01-04 17:50:52 +01:00
Benoit Marty
7b2341aec7 Rename Async to AsyncData 2024-01-04 16:30:56 +01:00
Benoit Marty
f5a229dbd4
Merge pull request #2160 from surakin/msc4027
Implement MSC4027 (Custom images in reactions)
2024-01-04 16:23:30 +01:00
Benoit Marty
e752248de1
Merge pull request #2162 from surakin/do-not-forward-stickers
Disable forwarding for stickers (until it can be properly fixed)
2024-01-04 16:17:20 +01:00