Commit graph

438 commits

Author SHA1 Message Date
Jorge Martin Espinosa
9e1ff513e4
[Compound] Implement Snackbars based on designs (#1054)
* Make `InternalButton` internal instead of private so it can be customised.

Also, change the `ButtonColors.contentColor` for text buttons to `LocalContentColor.current` by default.

* Add temporary color for Snackbar action label

* Implement `Snackbar` component based on Compound

* Propagate changes to all other components

* Use right Preview annotation config

* Move `ButtonVisuals` to their own file

* Update screenshots

* Make previews internal

* Update screenshots

* Set a custom token for contentColor in AppBars

* Change 'Label' to 'Action' in the previews

* Add changelog

* Update screenshots

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-08-16 10:38:28 +00:00
David Langley
08a0f710d7
Show selected reactions on the emoji picker. (#1014)
* Show selected reactions on the emoji picker.

* Unused import

* Update screenshots

* Use ImmutableSet

* Fix lint issues.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-08-11 15:47:06 +00:00
ElementBot
38a25dc3e9
Sync Strings from Localazy (#1032)
Co-authored-by: Florian14 <Florian14@users.noreply.github.com>
2023-08-11 14:34:05 +00:00
ganfra
fa51f6eaa7
Feature/fga/sync states (#1042)
* Change RoomSummaryDataSource to RoomListService to better reflects the rust api

* Better Sync management

* Sync: improve sync spinner rendering

* Sync: make test compiles

* Sync: add more test for sync spinner

* Sync: more clean-up

* Sync: pr review

---------

Co-authored-by: ganfra <francoisg@element.io>
2023-08-09 12:37:43 +00:00
Jorge Martin Espinosa
23982dde47
[Compound] Implement components (Button) (#1021)
* Create `CompoundButton`

* Some fixes

* Lint fixes

* Start replacing existing `Button` usages

* Replace button usages

* Remove previous Button composable

* Rename `CompoundButton` to `Button`

* Fix emphasized button being displayed as Text

* Fix cancel button in `WaitListView`

* Update screenshots

* Add shorthand functions for `OutlinedButton` and `TextButton`

* Add changelog

* Fix wrong size used for emphasized button in dialog

* Create a private `ButtonInternal` implementation with the shared logic.

- Make `ButtonStyle` private.
- Rename `title` to `text`.
- Rename `buttonStyle` and `buttonSize` to just `style` and `size`.

* Fix several warnings and lint issues.

* Update screenshots

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-08-08 16:11:37 +00:00
David Langley
a68564b5f0
Reactions ux updates (#1020)
* Fix ordering of reaction count/key label on outgoing messages and fix reaction button height

- Fix ordering of reaction count/key label on outgoing messages
- Fix reaction button height

* Fix emojis circles on action list

* Fix shape of reaction summary button when pressed

* Update screenshots

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-08-02 19:18:16 +00:00
Jorge Martin Espinosa
58ed74607d
Fix sending read receipts when entering a room (#1016)
* Fix sending read receipts when entering a room

* Improve solution for sending a read receipt when opening a room

* Roll back previous solution as it broke unit tests

* Remove dead code
2023-08-02 11:55:04 +00:00
ganfra
62a367520e
RoomList: use same logic than Timeline for caching built items. (#1013)
* RoomList: use same logic than Timeline for caching built items. Extract into reusable components.

* RoomList: fix tests

* Fix `DiffCacheUpdater` docs

---------

Co-authored-by: ganfra <francoisg@element.io>
Co-authored-by: Jorge Martín <jorgem@element.io>
2023-08-01 08:53:41 +00:00
David Langley
0b95ef09b7
Reaction summary view and sorting reactions by count and then timestamp (#942)
* Sort reactions by count and then timestamp

- Sort reactions within an aggregation by timestamp descending. This puts the most recent at the top, useful in cases like the reaction summary view or getting the most recent reaction.
- Sort aggregated reactions by count and then timestamp ascending, using the most recent reaction in the aggregation. This appends new aggregations on the end of the reaction layout.

* Add reaction summary view

* fix warnings

* Fix test unit tests and add sorting tests

- Fix broken build in test code
- Add a test for reaction sorting

* Remove default closure, move logic to presenter and add tests

* Update screenshots

* Fix imports

* Revert Screenshots I didn't update

* Fix imports remove screetshots

* Update screenshots

* Update screenshots

* Address comments.

* Update screenshots

* Remove unnecessary snapshotFlow

* Fix code quality checks

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-07-31 17:39:20 +00:00
ganfra
f1d438e701
Merge pull request #997 from vector-im/feature/fga/remove_from_main_thread
Feature/fga/remove from main thread
2023-07-31 13:39:06 +02:00
ganfra
f26e3b4979 Fix CI 2023-07-31 11:58:49 +02:00
ganfra
d63a3e2d77 Messages: remove some blocking code from main thread 2023-07-28 17:55:43 +02:00
Benoit Marty
792eb687bd
Merge pull request #989 from vector-im/feature/bma/noEmojiForStateEvent
Prevent reaction on state events and deleted events
2023-07-28 16:56:50 +02:00
Benoit Marty
822bb82347
Merge pull request #967 from vector-im/feature/bma/detektConfig
Update detekt config.
2023-07-28 16:47:26 +02:00
Benoit Marty
5b95bd08ba Rewrite the test, maybe the CI will be happier. 2023-07-28 15:33:35 +02:00
Benoit Marty
82e35cda0d Allow user with enough power level to redact other's messages (#969) 2023-07-27 18:42:45 +02:00
Benoit Marty
bcff814945 Prevent reaction on state events and deleted events (#971) 2023-07-27 17:30:19 +02:00
Benoit Marty
036658232b
Merge pull request #983 from vector-im/feature/bma/lintErrors
Update lint rules, remove unused resource and sync strings.
2023-07-27 15:59:38 +02:00
Jorge Martin Espinosa
914235228d
[Compound] Implement platform components (Switch, RadioButton, Checkbox) (#982)
* Create our custom Switch component

* Update RadioButton colors

* Update Checkbox colors

* Fix padding in `ReplyToContent`

* Add `indeterminate` and `hasError` parameters to `CheckBox`.

Improve previews.

* Improve Switch previews.

* Improve RadioButton previews.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-07-27 14:55:58 +02:00
Benoit Marty
8f4b664158 Sync strings. 2023-07-27 12:16:04 +02:00
Jorge Martin Espinosa
05f7037939
Prepare update to Rust SDK 0.1.36 (#966)
* Update to Rust SDK 0.1.36

* Cancel fetching members when the we exit the room
2023-07-26 14:22:09 +00:00
Benoit Marty
c40b75e834 Make some composable private. 2023-07-26 14:01:23 +02:00
ganfra
75c9624f6f Add consumeItemsUntilPredicate to check how it goes... 2023-07-26 13:07:11 +02:00
ganfra
5eb5dcd525 Push to understand test failure in CI 2023-07-26 12:22:41 +02:00
Benoit Marty
0e219200b0 Enable detekt rules OptionalUnit and fix existing issues. 2023-07-26 11:43:48 +02:00
Benoit Marty
e0255777c0 Enable detekt rules CascadingCallWrapping and fix existing issues. 2023-07-26 11:07:25 +02:00
Benoit Marty
b5a5118160 Enable detekt rule ThrowingExceptionsWithoutMessageOrCause and fix existing issues. 2023-07-26 10:33:51 +02:00
Benoit Marty
6aa5239189 Enable detekt rule PreviewPublic and fix existing issues. 2023-07-26 10:08:39 +02:00
ganfra
451cba20d0 Fix tests 2023-07-25 18:37:54 +02:00
ganfra
da57f42fcc Merge branch 'develop' into feature/fga/avoid_deadlocks 2023-07-25 16:09:24 +02:00
ganfra
e0eea67e7a Clean PR 2023-07-25 16:02:33 +02:00
Benoit Marty
caaa1923c7
Merge pull request #952 from vector-im/feature/bma/fixPushStoreCrash
Fix push store crash
2023-07-25 09:43:37 +02:00
Benoit Marty
b2394b6adc alternateText can't be an empty string. #955 2023-07-24 17:15:04 +02:00
Benoit Marty
4312a96851 Cleanup: there are no androidTest on those modules. 2023-07-24 12:41:02 +02:00
bmarty
af2159e98f Sync Strings from Localazy 2023-07-24 00:10:09 +00:00
Benoit Marty
1a1d4c2957 Fix code quality check failures after new rules from #935 has been merged on develop. 2023-07-21 16:04:55 +02:00
ganfra
a3bcb2c4ca Room: avoid calling displayName/avatarData on each recomposition 2023-07-21 15:19:19 +02:00
Benoit Marty
5e2e03f054
Merge branch 'develop' into feature/bma/noWarnings 2023-07-21 12:17:50 +02:00
David Langley
d9be396a04
Merge pull request #912 from vector-im/feature/dla_custom_reactions_layout
Reactions layout improvements
2023-07-21 11:00:43 +01:00
Benoit Marty
6b9f676b12 Test new field canShareLocation 2023-07-20 23:18:18 +02:00
Benoit Marty
3376fe3688 Must skip 1 item due to the location feature flag value emitting 1 item. 2023-07-20 23:17:29 +02:00
Benoit Marty
2ab57f3fc8 canShareLocation must be a MutableState. 2023-07-20 22:23:54 +02:00
Benoit Marty
2c11f472ca Replace FeatureFlags.ShowMediaUploadingFlow by FeatureFlags.LocationSharing because it has more chance to be disabled.
I do not want to remove all our feature flags...
2023-07-20 22:20:38 +02:00
Benoit Marty
c75eabbcb0 Enable detekt rules UnnecessaryParentheses and cleanup the code. 2023-07-20 18:08:08 +02:00
Benoit Marty
2928073e22 Enable detekt rules UnusedImports and cleanup the code. 2023-07-20 18:00:23 +02:00
Benoit Marty
e918d6affd Enable detekt rules TopLevelPropertyNaming and cleanup the code. 2023-07-20 17:52:48 +02:00
Benoit Marty
65ad642ffc Fix warning (bottom sheet still not previewable correctly in screenshot test) 2023-07-20 17:41:18 +02:00
Benoit Marty
e23222591b Fix warning (there is a TODO) 2023-07-20 17:39:55 +02:00
Benoit Marty
e67c7f32c3 Fix warning (keep the same format for all methods) 2023-07-20 17:39:55 +02:00
Benoit Marty
f738864e88 Fix warning (we will handle error case later) 2023-07-20 17:39:55 +02:00