Commit graph

284 commits

Author SHA1 Message Date
Benoit Marty
b104dba845 Remove Modifier parameter in private function when only default value is used.
This will improve the code coverage metrics, and this also fixes a few potential bug, where the Modifier was used several times.
2024-02-08 11:06:06 +01:00
bmarty
03c95555e3 Sync Strings from Localazy 2024-02-05 00:09:59 +00:00
Jorge Martin Espinosa
0f5038af8f
Make the whole items in advanced settings screen clickable, standarize paddings (#2314)
* Make sure the whole item in advanced settings screen triggers the toggle action

* Fix UI changes when setting `onChecked` actions to null.

* Fix padding in invite member list items

* Remove redundant `CheckableUserRow` alternatives.

* Use 4dp for padding instead

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-30 11:39:04 +00:00
ElementBot
6bc080c279
Sync Strings (#2230)
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
2024-01-15 09:21:04 +01:00
Benoit Marty
92d8e4f55b
Merge branch 'develop' into feature/bma/sxcludePreviewFromCodeCoverage 2024-01-11 16:02:58 +01:00
Benoit Marty
d01c70a4fd Fix moar ktlint issues 2024-01-11 11:24:10 +01:00
Benoit Marty
5d086ad82d Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
renovate[bot]
c8bd362397
Update plugin ktlint to v12.1.0 (#2200)
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-10 16:22:24 +01:00
Benoit Marty
371065bfdd Exclude ContentToPreview from coverage, either by using annotation @ExcludeFromCoverage, or by inlining it. 2024-01-09 17:56:01 +01:00
ganfra
44b6a97c90 Rename isFetchingSearchResults to showSearchLoader 2024-01-05 15:54:50 +01:00
ganfra
a0ba83c863 Rename SearchBarResultState.Empty to SearchBarResultState.Initial 2024-01-05 15:40:02 +01:00
ganfra
9fcc50e08a Rename UserSearchResults as UserSearchResultState 2024-01-05 15:34:01 +01:00
ganfra
46c7757ab8 Merge branch 'develop' into feature/fga/invite_user_loader 2024-01-05 14:02:58 +01:00
ganfra
109aea5ede MatrixUserRepo : fix tests 2024-01-05 13:44:59 +01:00
ganfra
c6b3387b62 User search : show a loader when fetching results 2024-01-04 21:27:44 +01:00
Benoit Marty
365c423190 Clean up 2024-01-04 18:45:34 +01:00
Benoit Marty
e42005fc52 Rename AsyncView to AsyncActionView 2024-01-04 17:50:52 +01:00
Benoit Marty
7b2341aec7 Rename Async to AsyncData 2024-01-04 16:30:56 +01:00
Benoit Marty
4f9fc2cfcf Fix compilation issue with compose compiler 1.5.7 2023-12-28 12:41:02 +01:00
Benoit Marty
dd4aa681c6 Remove now useless ExperimentalLayoutApi opt in 2023-12-28 12:41:02 +01:00
bmarty
e6f4a7364f Sync Strings from Localazy 2023-12-26 09:39:48 +01:00
ganfra
c4dc024c63 Fix detekt 2023-12-19 12:59:13 +01:00
ganfra
78bd6915c7 BackstackParentNode now become BaseFlowNode and adds Overlay navModel into it. 2023-12-19 12:55:14 +01:00
Benoit Marty
39cca2ce09 Sync localazy using fixed script 2023-12-08 19:24:35 +01:00
Benoit Marty
24d3981261 Run the script again. 2023-12-05 12:25:59 +01:00
bmarty
fced91addb Sync Strings from Localazy 2023-12-04 00:09:56 +00:00
ganfra
785a27151e StartDMAction : small improvements after review 2023-12-01 11:28:29 +01:00
ganfra
3efbf4747d StartDM : add tests 2023-11-30 18:05:26 +01:00
ganfra
e8eb9c0840 Add StartDMAction to further share code 2023-11-30 13:07:24 +01:00
ganfra
ab2dc827f0 Creates a startDM method so we can reuse it for the new flow 2023-11-29 16:16:09 +01:00
Marco Romano
f186a85ed0
Rename params in NodeFactories for clarity (#1916)
- `context` is now `buildContext` to reflect that it's of type `BuildContext` (and not an android `Context`).
- `NODE` generic type param is now `N` to stick with Java convention: https://docs.oracle.com/javase/tutorial/java/generics/types.html.
2023-11-29 10:01:07 +01:00
Jorge Martin Espinosa
087d2728d5
Extract compound tokens and theming to compound-android library (#1888)
* Replace tokens & icons with the external Compound ones

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-27 10:30:07 +01:00
Benoit Marty
05ba424e75
Merge pull request #1862 from vector-im/feature/bma/moreTests
Remove lambda default value
2023-11-24 11:00:34 +01:00
Benoit Marty
ae0c3edd24 Remove default value for lambda.
We enforce a value to be provided and it's better for code coverage.
2023-11-22 17:28:23 +01:00
Benoit Marty
67ed385e45 Prevent usage of hard-coded string for contentDescription, and fix existing issues. 2023-11-21 15:38:21 +01:00
Jorge Martin Espinosa
a5bad53c62
Iterate design on several screens: update icons, replace PreferenceTexts (#1771)
- Batch import new icons from the design team.
- Rename _september icons since they're just extra icons that need to be integrated in Compound in the future, and it should be ok if we don't distinguish between ic_september_*, ic_november_* etc., so all icons are now simply ic_* in the designsystem module.
- Create a new CompoundIconListPreviewProvider to add chunked lists of icons for previews. Add an exception for it to Konsist.
- Move some icons to use Compound icons.
- Remove most PreferenceText usages, use ListItem instead.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-15 10:52:37 +01:00
Benoit Marty
aaa89afe34 Use AsyncView in EditUserProfileView 2023-11-06 10:09:41 +01:00
Benoit Marty
662b1f8f50 Use AsyncView in CreateRoomRootView 2023-11-06 10:09:41 +01:00
Benoit Marty
c6ee35f567 Use AsyncView in ConfigureRoomView 2023-11-06 10:09:41 +01:00
Benoit Marty
f6d7a014a7 Remove other useless lazy wrapping. 2023-11-02 16:28:50 +01:00
Benoit Marty
8929a90970 Konsist: add test to ensure filename match top level Composable View, and fix existing issue 2023-10-10 15:39:22 +02:00
bmarty
7e3b9d8d3b Sync Strings from Localazy 2023-10-02 00:09:47 +00:00
Benoit Marty
0255ec6771
Merge pull request #1400 from vector-im/feature/bma/fixCrashPhoto
Fix crash when user wants to use the camera
2023-09-21 16:31:36 +02:00
Benoit Marty
d19b624c6f Rename Event for clarity 2023-09-21 15:33:03 +02:00
Benoit Marty
1b5aa7adaa Test that permission is requested, instead of giving the permission directly. 2023-09-21 15:00:47 +02:00
Benoit Marty
dd5d67d186 Move open system setting to the PermissionsPresenter 2023-09-21 14:20:41 +02:00
Benoit Marty
08b455afd3 Create FakePermissionsPresenterFactory, to reduce boilerplate. 2023-09-21 12:54:15 +02:00
Benoit Marty
e4ca2484ba Resume action once persmission has been granted. 2023-09-21 12:16:30 +02:00
Benoit Marty
dcb1677bf1 Open app settings from the permission dialog. 2023-09-21 11:37:59 +02:00
Benoit Marty
f3456cafa7 Rename Event for clarity 2023-09-21 11:29:29 +02:00