Commit graph

1728 commits

Author SHA1 Message Date
Benoit Marty
72b89338b3 Remove Modifier parameter in private function when only default value is used.
This will improve the code coverage metrics, and this also fixes a few potential bug, where the Modifier was used several times.
2024-02-08 11:06:06 +01:00
Benoit Marty
f9599a6a6f Add tests on MessagesView 2024-02-07 23:02:32 +01:00
Benoit Marty
c3f6dbd1c1 Add parameter to functions which create states, to avoid copy. 2024-02-07 23:02:32 +01:00
Benoit Marty
a1f78372d6 Remove LogCompositions.
It was used at the beginning of the project, but is not useful anymore.
2024-02-07 16:33:48 +01:00
Benoit Marty
9e6b6c42f8 Merge remote-tracking branch 'origin/develop' into feature/bma/testTimelineView 2024-02-07 10:38:05 +01:00
Benoit Marty
3359d1b347 Use Kdoc. 2024-02-07 10:31:08 +01:00
Benoit Marty
3c36868f85 Merge pull request #2349 from element-hq/feature/bma/disableTyping
"Share presence" setting
2024-02-07 10:29:43 +01:00
Benoit Marty
28f26b1aae Add test for TimelineItemPollView 2024-02-06 18:30:27 +01:00
Benoit Marty
a13862e7a9 Format file 2024-02-06 17:57:18 +01:00
Benoit Marty
bae47b942e Add type hierarchy on TimelineEvents.
It is not really OK that a Event was able to invoke `LoadMore` for instance.
2024-02-06 17:57:11 +01:00
Benoit Marty
824de9cc11 Add test to ensure that TimelineView loads more Events. 2024-02-06 17:12:14 +01:00
Benoit Marty
6234d6e092 Fix API break and change from SDK 0.1.97 2024-02-06 09:18:35 +01:00
Benoit Marty
3139d80504 Hide Read Receipt if the user set Rended Read Receipt to false (actually disabled the "Share presence" toggle) 2024-02-05 13:07:27 +01:00
Benoit Marty
64229397cb Take into account the setting isSendTypingNotificationsEnabled to not send typing notification when it's been disabled by the user. 2024-02-05 13:07:27 +01:00
bmarty
7911a26003 Sync Strings from Localazy 2024-02-05 00:09:59 +00:00
jmartinesp
697c482b6d Sync Strings from Localazy 2024-01-31 11:38:48 +00:00
Benoit Marty
a22653d7da Fix: ensure the effect is restarted on each sync update. 2024-01-30 10:19:53 +01:00
Benoit Marty
aefad3faa1 Ensure that canUserJoinCall is "live" 2024-01-29 12:15:14 +01:00
Benoit Marty
78da1d6a18 Remove useless suspend modifier. 2024-01-29 12:13:36 +01:00
Benoit Marty
bf9f31afe5 Cleanup: no need to provide a CurrentSessionIdHolder, the sessionId can be retrieved from the room. 2024-01-29 12:12:52 +01:00
Benoit Marty
2ef8f67951 Send typing notification #2240 2024-01-26 16:30:43 +01:00
Jorge Martin Espinosa
17f22d143b Add 'send private read receipts' option in advanced settings (#2290)
* Add 'send private read receipts' option in advanced settings
* Create `SessionPreferencesStore` that stores the settings for the current use separate from those of the app.
* Rename `PreferencesStore` to `AppPreferencesStore` to split the preferences.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-26 10:06:26 +01:00
Jorge Martin Espinosa
14fc747e80 Update timeline items read receipts when the room members are loaded (#2194)
* Update timeline items' sender info and read receipts when the room members info is loaded

* Only update this info if we have loaded the room members
2024-01-24 08:07:15 +01:00
Benoit Marty
30cea9c70a Always use the latest... fix. 2024-01-23 18:13:33 +01:00
Benoit Marty
cff076b508 Fix detekt issue:
Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior.

If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created.
However, if the effect is not to be restarted, you will need to use `rememberUpdatedState` on the parameter and use its result in the effect.

See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information. [LambdaParameterInRestartableEffect]
2024-01-23 18:13:33 +01:00
Benoit Marty
7ed20f9aab Remove unnecessary parenthesis. 2024-01-23 14:27:06 +01:00
Benoit Marty
746719d961 @Suppress("LargeClass") for test. 2024-01-23 14:25:16 +01:00
Benoit Marty
f9aa178388 Fix complexity error by extracting condition to a val. 2024-01-23 14:24:40 +01:00
Benoit Marty
cdbfe8f92c Fix API break: use new methods canUserRedactOwn and canUserRedactOther. 2024-01-23 13:32:13 +01:00
Jorge Martin Espinosa
06439536a8 Edited text message bubbles should resize when edited (#2272)
* Make `ContentAvoidingLayoutScopeInstance` scope aware so message bubbles are resized when edited.

* Move back to using `Layout` instead of `SubcomposeLayout`
2024-01-22 17:53:10 +01:00
Benoit Marty
f42e220d55 Merge pull request #2130 from element-hq/feature/bma/roomListBadge
Some rework on the codebase
2024-01-22 10:17:38 +01:00
bmarty
d2a4c737a6 Sync Strings from Localazy 2024-01-22 00:10:44 +00:00
Benoit Marty
32dc7bca23 Merge pull request #2221 from element-hq/feature/bma/displayNameAmbiguous
Display name disambiguation
2024-01-19 17:42:32 +01:00
Jorge Martin Espinosa
ac3201b317 Remove some state events at the start of DMs (#2252)
* Remove some initial events for DMs
2024-01-19 17:34:27 +01:00
Benoit Marty
49abbfce7f Remove dead code. 2024-01-19 16:46:42 +01:00
Benoit Marty
371aec4427 Remove RoomSummaryDetails.lastMessageTimestamp and replace by a getter on lastMessage 2024-01-19 16:11:10 +01:00
Benoit Marty
603b10264b Rename avatarURLString to avatarUrl 2024-01-19 15:58:37 +01:00
Benoit Marty
47a5c74129 Rename aRoomSummaryDetail to aRoomSummaryDetails 2024-01-19 15:55:26 +01:00
Jorge Martin Espinosa
64a18afc1b Replace 'leave room' text with 'leave conversation' for DMs (#2231)
* Replace 'leave room' text with 'leave conversation' for DMs

* Add `isDm` property to both `RoomSummary` and `RoomListRoomSummary`

* Remove redundant `leave_conversation_alert_subtitle_*` texts

* Fix maestro flow

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-16 15:49:44 +01:00
ElementBot
3a37460814 Sync Strings (#2230)
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
2024-01-15 09:21:04 +01:00
Benoit Marty
3f7e641c2f Display name disambiguation #2215.
Applied to:
- timeline message
- detail of timeline message
- reply preview of timeline message
- rendering of state Event
Not applied to:
- room last message
- room member list (we display the MatrixId here)
- room member detail page
2024-01-12 15:58:33 +01:00
Benoit Marty
d76ee23514 Merge pull request #2202 from element-hq/feature/bma/removeReadReceiptFlag
Remove ReadReceipts feature flag.
2024-01-11 17:13:35 +01:00
Benoit Marty
439c2f191b Ensure preview are not impacted when removing the ReadReceipt feature flag. 2024-01-11 15:58:36 +01:00
Benoit Marty
4dcafb6aa6 Remove ReadReceipts feature flag. 2024-01-11 15:57:59 +01:00
Benoit Marty
72a363c244 Fix moar ktlint issues 2024-01-11 11:24:10 +01:00
Benoit Marty
378692f743 Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
Benoit Marty
d3830af78b Fix ktlint issues 2024-01-10 19:33:39 +01:00
renovate[bot]
7e9cda3aa9 Update plugin ktlint to v12.1.0 (#2200)
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-10 16:22:24 +01:00
Jorge Martin Espinosa
e762584a37 Improve rendering of voice messages in the timeline in large displays (#2199)
* Improve rendering of voice messages in the timeline in large displays

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-09 18:07:23 +01:00
Jorge Martin Espinosa
7008b403c0 Fix mention selector getting stuck when quickly deleting the prompt (#2195)
* Fix mention selector getting stuck when quickly deleting the prompt
2024-01-09 11:07:10 +00:00