Sulkta-OSS/pallas
3
0
Fork 0
Code Issues 1 Pull requests 4 Projects Releases Packages Wiki Activity Actions

fix(codec): Fix flat encoding and decoding of arbitrarily size integers (#378)

Browse source 
This commits fixes the flat encoding and decoding (and consequently,
  the zigzag) for large integers in the following ways:

  - It removes support for encoding and decoding i128 values.

  - It optionally (feature = "num-bigint") introduces encoding and
    decoding of large sized integers through the num-bigint::BigInt
    type.

  Without the feature enabled, it is still possible to encode and decode
  isize values; but the use of i128 is now prohibited (as it would
  overflow on boundaries) in favor of arbitrarily sized integers.

  The commit also introduces a missing property roundtrip for encoding
  and decoding large integers, which was missing and thus, failed to
  identify the overflow problem.

  See related issue: https://github.com/aiken-lang/aiken/issues/796
This commit is contained in:
Matthias Benkort 2024-01-13 14:09:16 +01:00 • committed by GitHub
parent 0c026ef4c9
commit 0b1e5f0231
8 changed files with 133 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

10
pallas-codec/tests/zigzag.rs
View file

@ -1,18 +1,18 @@
use pallas_codec::flat::zigzag::{to_isize, to_usize};
use pallas_codec::flat::zigzag::ZigZag;
use proptest::prelude::*;
proptest! {
#[test]
fn zigzag(i: isize) {
let u = to_usize(i);
let converted_i = to_isize(u);
let u = i.zigzag();
let converted_i = u.zigzag();
assert_eq!(converted_i, i);
}
#[test]
fn zagzig(u: usize) {
let i = to_isize(u);
let converted_u = to_usize(i);
let i = u.zigzag();
let converted_u = i.zigzag();
assert_eq!(converted_u, u);
}
}