Sulkta-OSS/pallas
3
0
Fork 0
Code Issues 1 Pull requests 4 Projects Releases Packages Wiki Activity Actions

fix(addresses): check length before decoding (#377)

Browse source
This commit is contained in:
Harper 2024-02-11 15:55:01 +00:00 • committed by GitHub
parent 7c287296ee
commit 3b148dc672
1 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
pallas-addresses/src/lib.rs
View file

@ -50,6 +50,9 @@ pub enum Error {
#[error("invalid hash size {0}")] #[error("invalid hash size {0}")]
InvalidHashSize(usize), InvalidHashSize(usize),
#[error("invalid address length {0}")]
InvalidAddressLength(usize),
#[error("invalid pointer data")] #[error("invalid pointer data")]
InvalidPointerData, InvalidPointerData,
@ -319,6 +322,10 @@ fn parse_network(header: u8) -> Network {
macro_rules! parse_shelley_fn { macro_rules! parse_shelley_fn {
($name:tt, $payment:tt, pointer) => { ($name:tt, $payment:tt, pointer) => {
fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> { fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> {
if payload.len() < 29 {
return Err(Error::InvalidAddressLength(payload.len()));
}
let net = parse_network(header); let net = parse_network(header);
let h1 = slice_to_hash(&payload[0..=27])?; let h1 = slice_to_hash(&payload[0..=27])?;
let p1 = ShelleyPaymentPart::$payment(h1); let p1 = ShelleyPaymentPart::$payment(h1);
@ -330,6 +337,10 @@ macro_rules! parse_shelley_fn {
}; };
($name:tt, $payment:tt, $delegation:tt) => { ($name:tt, $payment:tt, $delegation:tt) => {
fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> { fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> {
if payload.len() != 56 {
return Err(Error::InvalidAddressLength(payload.len()));
}
let net = parse_network(header); let net = parse_network(header);
let h1 = slice_to_hash(&payload[0..=27])?; let h1 = slice_to_hash(&payload[0..=27])?;
let p1 = ShelleyPaymentPart::$payment(h1); let p1 = ShelleyPaymentPart::$payment(h1);
@ -342,6 +353,10 @@ macro_rules! parse_shelley_fn {
}; };
($name:tt, $payment:tt) => { ($name:tt, $payment:tt) => {
fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> { fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> {
if payload.len() != 28 {
return Err(Error::InvalidAddressLength(payload.len()));
}
let net = parse_network(header); let net = parse_network(header);
let h1 = slice_to_hash(&payload[0..=27])?; let h1 = slice_to_hash(&payload[0..=27])?;
let p1 = ShelleyPaymentPart::$payment(h1); let p1 = ShelleyPaymentPart::$payment(h1);
@ -355,6 +370,10 @@ macro_rules! parse_shelley_fn {
macro_rules! parse_stake_fn { macro_rules! parse_stake_fn {
($name:tt, $type:tt) => { ($name:tt, $type:tt) => {
fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> { fn $name(header: u8, payload: &[u8]) -> Result<Address, Error> {
if payload.len() != 28 {
return Err(Error::InvalidAddressLength(payload.len()));
}
let net = parse_network(header); let net = parse_network(header);
let p1 = StakePayload::$type(&payload[0..=27])?; let p1 = StakePayload::$type(&payload[0..=27])?;
let addr = StakeAddress(net, p1); let addr = StakeAddress(net, p1);