Sulkta-OSS/rustypipe
Archived
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: improve VecLogErr messages

Browse source
This commit is contained in:
ThetaDev 2023-11-24 17:40:05 +01:00
parent 87c8308246
commit 3d1b31bdde
1 changed files with 10 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/serializer/vec_log_err.rs
View file

@ -20,13 +20,6 @@ where
where where
D: serde::Deserializer<'de>, D: serde::Deserializer<'de>,
{ {
#[derive(serde::Deserialize)]
#[serde(untagged)]
enum GoodOrError<T> {
Good(T),
Error(serde_json::Value),
}
struct SeqVisitor<T>(PhantomData<T>); struct SeqVisitor<T>(PhantomData<T>);
impl<'de, T> Visitor<'de> for SeqVisitor<T> impl<'de, T> Visitor<'de> for SeqVisitor<T>
@ -46,16 +39,14 @@ where
let mut values = Vec::with_capacity(seq.size_hint().unwrap_or_default()); let mut values = Vec::with_capacity(seq.size_hint().unwrap_or_default());
let mut warnings = Vec::new(); let mut warnings = Vec::new();
while let Some(value) = seq.next_element()? { loop {
match value { match seq.next_element::<T>() {
GoodOrError::<T>::Good(value) => { Ok(val) => match val {
values.push(value); Some(val) => values.push(val),
} None => break,
GoodOrError::<T>::Error(value) => { },
warnings.push(format!( Err(e) => {
"error deserializing item: {}", warnings.push(format!("error deserializing item: {e}"));
serde_json::to_string(&value).unwrap_or_default()
));
} }
} }
} }
@ -186,8 +177,8 @@ mod tests {
insta::assert_debug_snapshot!(res.items.warnings, @r###" insta::assert_debug_snapshot!(res.items.warnings, @r###"
[ [
"error deserializing item: {\"xyz\":\"i2\"}", "error deserializing item: missing field `name` at line 1 column 40",
"error deserializing item: {\"namra\":\"i4\"}", "error deserializing item: missing field `name` at line 1 column 73",
] ]
"###); "###);
} }