test: add downloader test

downloader/src/error.rs

@@ -0,0 +1,54 @@
+use std::{borrow::Cow, path::PathBuf};
+
+use rustypipe::client::ClientType;
+
+/// Error from the video downloader
+#[derive(thiserror::Error, Debug)]
+#[non_exhaustive]
+pub enum DownloadError {
+    /// RustyPipe error
+    #[error("{0}")]
+    RustyPipe(#[from] rustypipe::error::Error),
+    /// Error from the HTTP client
+    #[error("http error: {0}")]
+    Http(#[from] reqwest::Error),
+    /// 403 error trying to download video
+    #[error("YouTube returned 403 error")]
+    Forbidden(ClientType),
+    /// File IO error
+    #[error(transparent)]
+    Io(#[from] std::io::Error),
+    /// FFmpeg returned an error
+    #[error("FFmpeg error: {0}")]
+    Ffmpeg(Cow<'static, str>),
+    /// Error parsing ranges for progressive download
+    #[error("Progressive download error: {0}")]
+    Progressive(Cow<'static, str>),
+    /// Video could not be downloaded because of invalid player data
+    #[error("input error: {0}")]
+    Input(Cow<'static, str>),
+    /// Download target already exists
+    #[error("file {0} already exists")]
+    Exists(PathBuf),
+    #[cfg(feature = "audiotag")]
+    /// Audio tagging error
+    #[error("Audio tag error: {0}")]
+    AudioTag(Cow<'static, str>),
+    /// Other error
+    #[error("error: {0}")]
+    Other(Cow<'static, str>),
+}
+
+#[cfg(feature = "audiotag")]
+impl From<lofty::error::LoftyError> for DownloadError {
+    fn from(value: lofty::error::LoftyError) -> Self {
+        Self::AudioTag(value.to_string().into())
+    }
+}
+
+#[cfg(feature = "audiotag")]
+impl From<image::ImageError> for DownloadError {
+    fn from(value: image::ImageError) -> Self {
+        Self::AudioTag(value.to_string().into())
+    }
+}

downloader/src/lib.rs

@@ -1,6 +1,7 @@
 #![doc = include_str!("../README.md")]
 #![warn(missing_docs, clippy::todo, clippy::dbg_macro)]
 
+mod error;
 mod util;
 
 use std::{
@@ -42,7 +43,7 @@ use rustypipe::model::{richtext::ToPlaintext, VideoDetails, VideoPlayerDetails};
 #[cfg(feature = "audiotag")]
 use time::{Date, OffsetDateTime};
 
-pub use util::DownloadError;
+pub use error::DownloadError;
 
 type Result<T> = core::result::Result<T, DownloadError>;
 

downloader/src/util.rs

@@ -1,58 +1,8 @@
-use std::{borrow::Cow, collections::BTreeMap, path::PathBuf};
+use std::collections::BTreeMap;
 
 use reqwest::Url;
-use rustypipe::client::ClientType;
 
-/// Error from the video downloader
-#[derive(thiserror::Error, Debug)]
-#[non_exhaustive]
-pub enum DownloadError {
-    /// RustyPipe error
-    #[error("{0}")]
-    RustyPipe(#[from] rustypipe::error::Error),
-    /// Error from the HTTP client
-    #[error("http error: {0}")]
-    Http(#[from] reqwest::Error),
-    /// 403 error trying to download video
-    #[error("YouTube returned 403 error")]
-    Forbidden(ClientType),
-    /// File IO error
-    #[error(transparent)]
-    Io(#[from] std::io::Error),
-    /// FFmpeg returned an error
-    #[error("FFmpeg error: {0}")]
-    Ffmpeg(Cow<'static, str>),
-    /// Error parsing ranges for progressive download
-    #[error("Progressive download error: {0}")]
-    Progressive(Cow<'static, str>),
-    /// Video could not be downloaded because of invalid player data
-    #[error("input error: {0}")]
-    Input(Cow<'static, str>),
-    /// Download target already exists
-    #[error("file {0} already exists")]
-    Exists(PathBuf),
-    #[cfg(feature = "audiotag")]
-    /// Audio tagging error
-    #[error("Audio tag error: {0}")]
-    AudioTag(Cow<'static, str>),
-    /// Other error
-    #[error("error: {0}")]
-    Other(Cow<'static, str>),
-}
-
-#[cfg(feature = "audiotag")]
-impl From<lofty::error::LoftyError> for DownloadError {
-    fn from(value: lofty::error::LoftyError) -> Self {
-        Self::AudioTag(value.to_string().into())
-    }
-}
-
-#[cfg(feature = "audiotag")]
-impl From<image::ImageError> for DownloadError {
-    fn from(value: image::ImageError) -> Self {
-        Self::AudioTag(value.to_string().into())
-    }
-}
+use crate::DownloadError;
 
 /// Split an URL into its base string and parameter map
 ///