Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 11 Projects Releases Packages Wiki Activity Actions

Merge pull request #12699 from Zer0tier/issue#12499

Browse source 
Fix Long Audio/Dubs text label puses UI Controls on Player Off Screen in Portrait mode.
This commit is contained in:
Tobi 2025-10-14 04:21:56 -07:00 • committed by GitHub
commit 06036a035a
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java
View file

@ -289,6 +289,7 @@ public final class MainPlayerUi extends VideoPlayerUi implements View.OnLayoutCh
binding.topControls.setClickable(true); binding.topControls.setClickable(true);
binding.topControls.setFocusable(true); binding.topControls.setFocusable(true);
binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
} }
@ -934,6 +935,7 @@ public final class MainPlayerUi extends VideoPlayerUi implements View.OnLayoutCh
} }
fragmentListener.onFullscreenStateChanged(isFullscreen); fragmentListener.onFullscreenStateChanged(isFullscreen);
binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
binding.playerCloseButton.setVisibility(isFullscreen ? View.GONE : View.VISIBLE); binding.playerCloseButton.setVisibility(isFullscreen ? View.GONE : View.VISIBLE);

7
app/src/main/res/layout/player.xml
View file

@ -123,7 +123,7 @@
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="6dp" android:layout_marginTop="6dp"
android:layout_marginRight="8dp" android:layout_marginEnd="8dp"
android:layout_weight="1" android:layout_weight="1"
android:gravity="top" android:gravity="top"
android:orientation="vertical" android:orientation="vertical"
@ -160,12 +160,15 @@
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView
android:id="@+id/audioTrackTextView" android:id="@+id/audioTrackTextView"
android:layout_width="wrap_content" android:layout_width="0dp"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:layout_weight="1"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:gravity="center" android:gravity="center"
android:minWidth="0dp" android:minWidth="0dp"
android:singleLine="true"
android:ellipsize="end"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textStyle="bold" android:textStyle="bold"