Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 11 Projects Releases Packages Wiki Activity Actions

Prevent IllegalArgumentException when closing popup

Browse source
This commit is contained in:
Stypox 2021-01-17 14:04:07 +01:00
parent 9bf5049aa1
commit 1522eae016
2 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/java/org/schabi/newpipe/player/Player.java
View file

@ -1349,14 +1349,24 @@ public final class Player implements
public void removePopupFromView() { public void removePopupFromView() {
if (windowManager != null) { if (windowManager != null) {
final boolean isCloseOverlayHasParent = closeOverlayBinding != null // wrap in try-catch since it could sometimes generate errors randomly
&& closeOverlayBinding.closeButton.getParent() != null; try {
if (popupHasParent()) { if (popupHasParent()) {
windowManager.removeView(binding.getRoot()); windowManager.removeView(binding.getRoot());
} }
if (isCloseOverlayHasParent) { } catch (final IllegalArgumentException e) {
Log.w(TAG, "Failed to remove popup from window manager", e);
}
try {
final boolean closeOverlayHasParent = closeOverlayBinding != null
&& closeOverlayBinding.getRoot().getParent() != null;
if (closeOverlayHasParent) {
windowManager.removeView(closeOverlayBinding.getRoot()); windowManager.removeView(closeOverlayBinding.getRoot());
} }
} catch (final IllegalArgumentException e) {
Log.w(TAG, "Failed to remove popup overlay from window manager", e);
}
} }
} }