Sulkta-OSS/straw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent exception from being serialized in ErrorInfo

Browse source 
The wrong @Decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
This commit is contained in:
Stypox 2021-12-01 10:28:35 +01:00
parent 09d137f740
commit 397f93b079
No known key found for this signature in database
GPG key ID: 4BDF1B40A49FDD23
7 changed files with 19 additions and 123 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/src/main/java/org/schabi/newpipe/player/playererror/PlayerErrorHandler.java
View file

@ -12,7 +12,6 @@ import androidx.preference.PreferenceManager;
import com.google.android.exoplayer2.ExoPlaybackException;
import org.schabi.newpipe.R;
import org.schabi.newpipe.error.EnsureExceptionSerializable;
import org.schabi.newpipe.error.ErrorInfo;
import org.schabi.newpipe.error.ErrorUtil;
import org.schabi.newpipe.error.UserAction;
@ -70,7 +69,7 @@ public class PlayerErrorHandler {
ErrorUtil.createNotification(
context,
new ErrorInfo(
EnsureExceptionSerializable.ensureSerializable(exception),
exception,
UserAction.PLAY_STREAM,
"Player error[type=" + exception.type + "] occurred while playing: "
+ info.getUrl(),