Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 8 Projects Releases Packages Wiki Activity Actions

Improved downloading experience (#10407)

Browse source 
* added LoadingDialog for improving download experience

* [LoadingDialog] Apply some review comments and make title customizable.

* removed permission handling from loading Dialog

* fix checks

* remove <p> Tag from first sentence

---------

Co-authored-by: rishabaggarwal <Rishabaggarwal@sharechat.com>
Co-authored-by: TobiGr <tobigr@users.noreply.github.com>
This commit is contained in:
Rishab Aggarwal 2023-09-18 05:24:03 +05:30 • committed by GitHub
parent b1ab261890
commit 7e2ab0d384
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 117 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
app/src/main/res/layout/download_loading_dialog.xml Normal file
View file

@ -0,0 +1,18 @@
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent">
<include
android:id="@+id/toolbar_layout"
layout="@layout/toolbar_layout" />
<ProgressBar
android:id="@+id/loader"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="150dp"
android:layout_marginBottom="100dp"
android:layout_centerHorizontal="true"
android:indeterminate="true" />
</RelativeLayout>

1
app/src/main/res/values/strings.xml
View file

@ -167,6 +167,7 @@
<string name="duration_live">Live</string>
<string name="downloads">Downloads</string>
<string name="downloads_title">Downloads</string>
<string name="loading_metadata_title">Loading Metadata…</string>
<string name="error_report_title">Error report</string>
<string name="all">All</string>
<string name="channels">Channels</string>