Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Use vector drawables instead of PNGs for material icons

Browse source 
For all manually-created images PNG have been kept.
- rename all icon attrs to have a `ic_` prefix
- always use `_24dp` icons, because there is no real difference, since they are vector drawables
- always use the original name found on material.io for icon drawables, as to not create confusion and possibly duplicates. Icon names can still be different from real drawable names, though I have made some of them compliant to this or maybe more meaningul.
- remove duplicate `getIconByAttr()` in ThemeHelper (use `resolveResourceIdFromAttr()`
- use standard icons for `expand_more` and `expand_less` instead of triangles
- use `play_button_outline` instead of custom PNG as play button in VideoDetailFragment (questionable, as there is no shadow anymore)
This commit is contained in:
Stypox 2020-03-25 16:23:47 +01:00
parent b5f508b309
commit c80aba9a88
758 changed files with 1165 additions and 730 deletions
Download patch file Download diff file Expand all files Collapse all files

74
app/src/main/res/values/attrs.xml
View file

@ -1,34 +1,33 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<!--TODO: preffix these with "ic_"-->
<attr name="thumbs_up" format="reference"/>
<attr name="thumbs_down" format="reference"/>
<attr name="info" format="reference"/>
<attr name="audio" format="reference"/>
<attr name="download" format="reference"/>
<attr name="share" format="reference"/>
<attr name="cast" format="reference"/>
<attr name="rss" format="reference"/>
<attr name="search" format="reference"/>
<attr name="close" format="reference"/>
<attr name="filter" format="reference"/>
<attr name="popup" format="reference"/>
<attr name="expand" format="reference"/>
<attr name="collapse" format="reference"/>
<attr name="volume_off" format="reference"/>
<attr name="volume_on" format="reference"/>
<attr name="clear_history" format="reference" />
<attr name="palette" format="reference"/>
<attr name="language" format="reference"/>
<attr name="history" format="reference"/>
<attr name="drag_handle" format="reference"/>
<attr name="selected" format="reference"/>
<attr name="search_add" format="reference"/>
<attr name="options" format="reference"/>
<attr name="play" format="reference"/>
<attr name="pause" format="reference"/>
<attr name="bug" format="reference"/>
<attr name="settings" format="reference"/>
<attr name="ic_thumb_up" format="reference"/>
<attr name="ic_thumb_down" format="reference"/>
<attr name="ic_info_outline" format="reference"/>
<attr name="ic_headset" format="reference"/>
<attr name="ic_file_download" format="reference"/>
<attr name="ic_share" format="reference"/>
<attr name="ic_cast" format="reference"/>
<attr name="ic_rss" format="reference"/>
<attr name="ic_search" format="reference"/>
<attr name="ic_close" format="reference"/>
<attr name="ic_filter_list" format="reference"/>
<attr name="ic_popup" format="reference"/>
<attr name="ic_expand_more" format="reference"/>
<attr name="ic_expand_less" format="reference"/>
<attr name="ic_volume_off" format="reference"/>
<attr name="ic_volume_up" format="reference"/>
<attr name="ic_clear_history" format="reference" />
<attr name="ic_palette" format="reference"/>
<attr name="ic_language" format="reference"/>
<attr name="ic_history" format="reference"/>
<attr name="ic_drag_handle" format="reference"/>
<attr name="ic_selected" format="reference"/>
<attr name="ic_search_add" format="reference"/>
<attr name="ic_options" format="reference"/>
<attr name="ic_play_arrow" format="reference"/>
<attr name="ic_pause" format="reference"/>
<attr name="ic_bug_report" format="reference"/>
<attr name="ic_settings" format="reference"/>
<attr name="ic_hot" format="reference"/>
<attr name="ic_kiosk_local" format="reference"/>
<attr name="ic_kiosk_recent" format="reference"/>
@ -49,7 +48,7 @@
<attr name="ic_settings_update" format="reference"/>
<attr name="ic_done" format="reference"/>
<attr name="ic_computer" format="reference"/>
<attr name="ic_videogame" format="reference"/>
<attr name="ic_videogame_asset" format="reference"/>
<attr name="ic_music_note" format="reference"/>
<attr name="ic_stars" format="reference"/>
<attr name="ic_sports" format="reference"/>
@ -57,7 +56,7 @@
<attr name="ic_person" format="reference"/>
<attr name="ic_people" format="reference"/>
<attr name="ic_heart" format="reference"/>
<attr name="ic_kids" format="reference"/>
<attr name="ic_child_care" format="reference"/>
<attr name="ic_fastfood" format="reference"/>
<attr name="ic_car" format="reference"/>
<attr name="ic_motorcycle" format="reference"/>
@ -67,7 +66,7 @@
<attr name="ic_smile" format="reference"/>
<attr name="ic_edit" format="reference"/>
<attr name="ic_explore" format="reference"/>
<attr name="ic_fitness" format="reference"/>
<attr name="ic_fitness_center" format="reference"/>
<attr name="ic_restaurant" format="reference"/>
<attr name="ic_mic" format="reference"/>
<attr name="ic_radio" format="reference"/>
@ -82,14 +81,15 @@
<attr name="ic_megaphone" format="reference"/>
<attr name="ic_sort" format="reference"/>
<attr name="ic_help" format="reference"/>
<attr name="ic_arrow_back" format="reference"/>
<attr name="progress_horizontal_drawable" format="reference"/>
<!-- Can't refer to colors directly in drawable's xml-->
<attr name="toolbar_shadow_drawable" format="reference"/>
<attr name="selector_drawable" format="reference"/>
<attr name="checked_selector_drawable" format="reference"/>
<attr name="focused_selector_drawable" format="reference"/>
<attr name="dashed_border_drawable" format="reference"/>
<attr name="toolbar_shadow" format="reference"/>
<attr name="selector" format="reference"/>
<attr name="checked_selector" format="reference"/>
<attr name="focused_selector" format="reference"/>
<attr name="dashed_border" format="reference"/>
<attr name="separator_color" format="color"/>
<attr name="queue_background_color" format="color"/>