Sulkta-OSS/straw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed SonarLint problems

Browse source 
* Removed alphaRelativeDuration as there is no use for it
This commit is contained in:
litetex 2021-12-31 21:22:02 +01:00
parent 345ba74d58
commit f8c52c4dac
3 changed files with 14 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

15
app/src/main/java/org/schabi/newpipe/player/Player.java
View file

@ -600,22 +600,24 @@ public final class Player implements
}
@Override
public Boolean shouldFastForward(@NonNull final DisplayPortion portion) {
public Optional<Boolean> shouldFastForward(
@NonNull final DisplayPortion portion
) {
// Null indicates an invalid area or condition e.g. the middle portion
// or video start or end was reached during double tap seeking
if (invalidSeekConditions()) {
playerGestureListener.endMultiDoubleTap();
return null;
return Optional.empty();
}
if (portion == DisplayPortion.LEFT
// Small puffer to eliminate infinite rewind seeking
&& simpleExoPlayer.getCurrentPosition() > 500L) {
return false;
return Optional.of(false);
} else if (portion == DisplayPortion.RIGHT) {
return true;
return Optional.of(true);
}
/* portion == DisplayPortion.MIDDLE */
return null;
return Optional.empty();
}
@Override
@ -630,7 +632,8 @@ public final class Player implements
private boolean invalidSeekConditions() {
return exoPlayerIsNull()
|| simpleExoPlayer.getPlaybackState() == SimpleExoPlayer.STATE_ENDED
|| simpleExoPlayer.getPlaybackState()
== com.google.android.exoplayer2.Player.STATE_ENDED
|| simpleExoPlayer.getCurrentPosition() >= simpleExoPlayer.getDuration()
|| currentState == STATE_COMPLETED;
}