Commit graph

2749 commits

Author SHA1 Message Date
Tobi
01c7041d6f Merge pull request #7056 from TeamNewPipe/fix/playOnPopup
Fix handling exception in `playOnPopup` and toggle description tab
2021-09-10 18:21:41 +02:00
thefalsedev
33a13651f9 Change player progress bar update from 500 ms to 1 s
Just like in the issue 7062, https://github.com/TeamNewPipe/NewPipe/issues/7062, this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
2021-09-07 00:04:05 +02:00
TobiGr
5a257f9ebb Fix a few SonarLint warnings 2021-09-05 19:54:28 +02:00
TobiGr
e4dc4c0049 Fix OnErrorNotImplementedException in SearchFragment.initSuggestionObserver()
Hopefully also fix the cause of the original error.
2021-09-05 19:54:28 +02:00
TobiGr
70ec9bcfc0 Fix OnErrorNotImplementedException in playOnPopup 2021-09-05 19:54:28 +02:00
TobiGr
f9410ec0f1 Fix updating the wrong tabs when changing settings while running the minimized player in VideoDetailFragment
The comments tab was updated although the settings for the description tab were changed.
2021-09-04 22:36:47 +02:00
Tobi
cf157515a5 Merge pull request #7043 from Stypox/optimize-resources
Remove unused resources
2021-09-04 20:57:07 +02:00
Stypox
e2af6c6bc9 Remove unused resources 2021-09-02 21:13:54 +02:00
Stypox
a551cc72f6 Move fullscreen-related comments to javadocs 2021-09-01 20:13:27 +02:00
Stypox
d330da58a8 Fix null pointer exception in player initialization 2021-09-01 20:13:27 +02:00
Stypox
e825e9db55 Completely close player when changing stream w/o autoplay 2021-09-01 20:13:27 +02:00
Stypox
e5e654043a Open fullscreen when switching from popup to main player 2021-09-01 20:13:24 +02:00
Stypox
635cd7e493 Fix bottom sheet state after automatic fullscreen 2021-09-01 20:12:14 +02:00
Stypox
70e8065ea6 Fix opening directly fullscreen on tablets 2021-09-01 20:12:09 +02:00
Stypox
b2e0859e8a Extract isLandscape and isInMultiWindow to DeviceUtils 2021-09-01 20:09:08 +02:00
Stypox
28c1384391 Add option to directly open fullscreen when the main player starts 2021-09-01 20:08:37 +02:00
Stypox
90e6621eb7 Merge pull request #7004 from litetex/fix-showTextError-and-rework-ErrorPanel
Reworked the ErrorPanel
2021-08-31 18:26:51 +02:00
Robin
c76ebb21f5 Merge pull request #6993 from Redirion/closeaudioeffectsession
Close audio effect control session properly
2021-08-31 12:37:20 +02:00
Stypox
ef08fce9f1 Merge pull request #6955 from ktprograms/queue-long-press-menu
Show popup menu when long pressing in play queue (Full screen player)
2021-08-31 12:22:59 +02:00
Stypox
eb8dfe2a44 Merge pull request #6882 from talanc/dev
Add support for CSV+ZIP subscriptions (Google Takeout)
2021-08-31 12:10:12 +02:00
Stypox
114f9e1cce Improve mime type deduction on subscription import 2021-08-31 12:07:34 +02:00
talanc
fb0cb7d982 Added support for CSV+ZIP subscriptions
Updated import instructions string
2021-08-31 12:07:34 +02:00
Stypox
bde378618d Merge pull request #7024 from Stypox/string-fixes
Never use ``android.R.string``s; remove unused ``add`` string
2021-08-31 12:00:07 +02:00
Stypox
3d393f2bb9 Merge pull request #6985 from litetex/set-seekbarjump-when-using-dpad-to-seek-duration-from-preferences
Set ``KeyProgressIncrement`` manually / Fix long seekbar jumps when using a DPad
2021-08-30 23:36:29 +02:00
Tobi
0c8bd5416a Merge pull request #6986 from litetex/fix-build-problems-update-kotlin
Fix build problems and updated kotlin
2021-08-30 21:20:45 +02:00
Stypox
d87d418ce4 Always use our strings, not android ones 2021-08-30 16:37:01 +02:00
Stypox
14ebb41264 Rename string finish to ok, as its content was "OK" 2021-08-30 16:36:57 +02:00
Robin
329c021e19 Merge pull request #6634 from Isira-Seneviratne/Use_PackageInfoCompat
Use PackageInfoCompat.getSignatures().
2021-08-29 23:13:12 +02:00
litetex
8ee0352f66 Fixed double tapping the replay button 2021-08-29 17:53:09 +02:00
Robin
1b10aa685c Merge pull request #6515 from Redirion/buffersharmonization
Use ExoPlayer default values for buffers
2021-08-29 17:44:43 +02:00
Agnieszka C
a34805ea3a Added plural forms for download related strings (#6930)
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
2021-08-29 13:28:01 +02:00
litetex
fe18216b62 Reworked the ErrorPanel
* All element on the error panel are now hidden by default (expect for the ``errorTextView``) as they are only optional shown
  * Added a method to ensure the above
  * This deduplicates a lot of code
* Fixed format of some LoC
* Added new method: ``showAndSetErrorButtonAction``
* Fixed  ``showTextError``
* Named buttons more logically: ``errorButtonAction`` -> ``errorActionButton``
2021-08-28 17:05:12 +02:00
acti0
5be652c340 Re-add sharing of the content name with the "Share" command (#6957)
The title of the content is re-added as the EXTRA_SUBJECT of the share intent.
2021-08-27 19:26:32 +02:00
litetex
40facc312e Suppressed warning
There seems to be a bug in the kotlin plugin as it tells you when building that this can't be null:
"Condition 'throwable != null' is always 'true'"
However it can indeed be null as seen in https://github.com/TeamNewPipe/NewPipe/pull/6986#issuecomment-906822218
2021-08-27 16:32:59 +02:00
Robin
6242d3f28d close audio effect control session properly 2021-08-27 10:53:44 +02:00
Tobi
d9d1b73e80 Merge pull request #6820 from Stypox/picker-mime-type
Provide mime type to file picker to gray out unselectable files
2021-08-26 21:39:35 +02:00
litetex
9ecec58bbc Changed package as the old one is deprecated 2021-08-26 18:09:27 +02:00
litetex
cb15d97cf9 Set `KeyProgressIncrement` manually
* Set ``KeyProgressIncrement`` manually to the value of the seek duration in the settings so that it works when using the DPad
* consolidated code inside a new method to avoid duplication
2021-08-26 17:16:51 +02:00
ktprograms
b448f87b99 Remove TAG parameter, refactor method calls 2021-08-25 17:04:15 +08:00
ktprograms
6cc6ad2346 Move opening popup menu to utility class 2021-08-25 09:30:40 +08:00
ktprograms
cf1f0cf2da Remove Details option in Main Player Queue menu 2021-08-25 08:56:26 +08:00
ktprograms
0abbbe7b59 Change type of themeWrapper to ContextThemeWrapper 2021-08-25 08:56:26 +08:00
ktprograms
26f80ceaef Show popup menu when long pressing in play queue (Full screen player) 2021-08-25 08:56:26 +08:00
Stypox
b975de39f0 Do not show suggestions error snackbar for interrupted I/O
Fix formatting
2021-08-24 18:16:17 +02:00
Stypox
b75b6c0c3f First run migrations, then setDefaultValues, since the latter requires the correct types 2021-08-24 18:16:17 +02:00
Stypox
acf56fce82 Allow choosing which types of search suggestions to show
local, remote, both, none
Replacing the old on-off setting
2021-08-24 18:16:16 +02:00
Stypox
2f78a6cacb Merge pull request #6919 from ktprograms/channel-details-all-places
Add Show Channel Details where it's missing
2021-08-24 16:43:21 +02:00
ktprograms
7286bb7961 Fix checkstyle ParenPad error 2021-08-24 21:17:08 +08:00
Stypox
5fb360a36e Remove placeholder image while loading thumbnails 2021-08-24 10:56:25 +02:00
Stypox
12ad678d14 Apply review: move thumbnail loading out of Player 2021-08-24 10:56:25 +02:00