Commit graph

416 commits

Author SHA1 Message Date
Stypox
04dcb5b74b Fix disposables handling for text linkifier
also use differently Markwon methods to convert plain text to markdown
2021-06-11 12:12:12 +02:00
Stypox
dbbca9085c Improve text linkifier function parameters 2021-06-11 12:12:11 +02:00
TiA4f8R
0a4f2b50b9 Annotate params and methods with NonNull 2021-06-11 12:12:10 +02:00
TiA4f8R
0844e448a3 Fix an error and add a new method in the ShareUtils class
Fix the error due to the rebase on the dev branch of this branch
Add a shareText method in the ShareUtils class which has 3 parameters and calls
the original shareText method with an empty string for the
imagePreviewUrl param.
2021-06-11 12:12:09 +02:00
TiA4f8R
b0bd0656ed Initial work: use disposables for timestamps parsing in YouTube video descriptions and YouTube comments 2021-06-11 12:12:08 +02:00
TiA4f8R
5aefab981f Split handleUrl method into two methods
Split handleURL method, now private, into two methods:
handleUrlCommentsTimestamp and handleUrlDescriptionTimestamp. Code is
now more proper.
2021-06-11 12:12:07 +02:00
TiA4f8R
63966a1c2f Adress requested changes and try some cleanup in handleUrl method of InternalUrlsHandler class 2021-06-11 12:12:06 +02:00
TiA4f8R
0dcd1360a9 Don't use a chooser for other intents than opening a content in a browser or sharing a content to other apps
Use an ACTION_CHOOSER intent has a negative impact for user experience, because user cannot set as default an activity for an intent
2021-06-11 12:12:05 +02:00
TiA4f8R
373fed5152 Initial work: add support for opening hashtags in plain text descriptions
This commit adds supports for opening hashtags in plain text descriptions, using the same logic as timestamps.
Every hashtag opens a search on the current service with the text in the hashtag.
Also use a better regular expression for parsing timestamps.
2021-06-11 12:12:04 +02:00
TiA4f8R
a23dff74a3 Move some classes to a new subpackage and adress requested changes
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
Remove unused param showPreviewText in shareText method of ShareUtils class.
Add initial work to be able to display an image preview of the content shared (not for downloads).
Use a better regular expression to parse timestamps in plain text descriptions.
2021-06-11 12:12:02 +02:00
TiA4f8R
1d615df928 Initial work to add the image of the content in the share sheet
Also do some fixes when sharing a file in downloads and some improvements in JavaDocs of ShareUtils class.
2021-06-11 12:12:00 +02:00
TiA4f8R
ae6f77d0dc Fix title of the subject when sharing an URL 2021-06-11 12:11:59 +02:00
TiA4f8R
122fa1f729 Apply suggested changes and fix some warnings 2021-06-11 12:11:58 +02:00
TiA4f8R
c3a6a2755e Fix toast shown when falling back to Google Play Store URL and the action of Open with Kodi button in the player
Add a boolean param, showToast, in ShareUtils.openIntentInApp and only show toast "No app on your device can open this" if this boolean is true.
Fix the action of play with Kodi button by applying the fix provided in #5599 (adding the flag Intent.FLAG_ACTIVITY_NEW_TASK to the intent in NavigationHelper.playWithKore method).
Do also some cleanup in viewWithFileProvider and shareFile methods of MissionAdapter class.
2021-06-11 12:11:56 +02:00
TiA4f8R
27687b18e8 Initial work: add support for opening timestamps in plain text descriptions
This commit adds support for opening plain text timestamps by parsing the description text using a regular expression, add a click listener for each timestamp which opens the popup player at the indicated time in the timestamp.
In order to do this, playOnPopup method of the URLHandler class. Also, handleUrl method of this class has been renamed to canHandleUrl.
2021-06-11 12:11:55 +02:00
TiA4f8R
2f9ffe61db Open recognized timestamps in the description of contents in the popup player
This commit adds support of opening recognized timestamps in the popup
player instead of starting an intent which opens the YouTube website with
the video timestamp.
2021-06-11 12:11:44 +02:00
wb9688
28f070b6da Only ask for storage permissions when not using SAF 2021-06-08 10:40:45 +02:00
wb9688
995264e5e2 Move Stored(File|Directory)Helper into NewPipe 2021-06-08 10:40:44 +02:00
wb9688
4e133a3599 Support SAF properly 2021-06-08 10:40:44 +02:00
Stypox
84709eb620 Revert all commits related to ContentSettingsFragment
Revert "Annotate methode parameters as NonNull"
This reverts commit af92c3ed4f.

Revert "Commit path immediately when import backup"
This reverts commit c3d9c4bb3f.

Revert "Set ImportExportDataPath only on successful import"
This reverts commit a4bc61a7d0.

Revert "Set ImportExportDataPath only on successful export"
This reverts commit 372d7a7832.

Revert "Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability"
This reverts commit 2877c43ecb.

Revert "Move ContentSettingsFragment.isValidPath to helpers and add unit test for it."
This reverts commit 15873d53c4.

Revert "Save backup import/export location for feature import/exports"
This reverts commit 01f05e2f46.

Remove FilePathHelperTest file
2021-06-08 10:40:44 +02:00
TobiGr
d0a76d7e60 Use reqireContext(), requireActivity() instead of getters 2021-06-05 16:13:12 +02:00
TiA4f8R
14883367f6 Fix Play with Kodi button in Player always prompts to install Kore 2021-06-05 12:48:34 +02:00
TiA4f8R
5bcd91b3c4 Add Open in browser option to long-press menu
Add Open in browser option to long-press menu when long pressing a stream and a subscription
2021-06-03 13:15:08 +02:00
Alireza Tofighi
15873d53c4 Move ContentSettingsFragment.isValidPath to helpers and add unit test for it. 2021-05-21 20:21:58 +04:30
Davide Beatrici
829e6170a7 Disable media tunneling on cvt_mt5886_eu_1g (#6024)
* Disable media tunneling on cvt_mt5886_eu_1g

Follow-up to fb49dda602.
2021-04-08 05:21:57 +02:00
wangear
c1afc5fcc4 Fix NullPointerException: Attempt to get length of null array in MainActivity (#5999)
* Fixed Unable to start activity ComponentInfo{org.schabi.newpipe/org.schabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to get length of null array #5996
issue : #5996
changed :
- Checked null
2021-04-06 14:13:13 +02:00
krlvm
ef0999b9c3 Merge branch 'dev' into daynight 2021-04-03 00:08:26 +03:00
Fynn Godau
36177cefaa Rename related streams to related items 2021-03-31 22:33:22 +02:00
Tobi
1d5b2e9038 Merge pull request #5969 from Redirion/tnnlwrkarnd
Disable media tunneling on Hi3798MV200
2021-03-31 19:02:00 +02:00
camo0112
3e232ba4d3 IssueFixed#5968 2021-03-31 20:48:02 +05:30
Robin
fb49dda602 Disabled tunneling on Hi3798MV200 2021-03-31 16:38:50 +02:00
krlvm
1b5061c36b Fix ErrorActivity colors 2021-03-29 22:48:28 +03:00
Mohammed Anas
a613b17990 Add channel details option to long-press menu (#5851)
Add dialog item to open channel details
Use `List` as type of `entries`
Put channel details item last
Only show channel option when channel is present
2021-03-28 18:32:40 +02:00
krlvm
0e452320ef Remove ThemeHelper.resolveResourceIdFromAttr 2021-03-28 12:23:52 +03:00
krlvm
a8de222577 Fix Dark elements in Light Theme 2021-03-27 17:46:05 +03:00
krlvm
c509ecac47 Migrate to DayNight Theme 2021-03-26 23:08:25 +03:00
Stypox
d605441320 Fix settings switches are not red anymore
Reverts part of e8baee2a5e
2021-03-24 10:16:24 +01:00
Stypox
e8baee2a5e Refactor ThemeHelper 2021-03-18 12:39:29 +01:00
bopol
eb4b54afec Use a list for night themes
Also remove unused strings
2021-03-18 12:12:04 +01:00
bopol
e8967c157a Use a switch preference to follow device theme 2021-03-18 11:23:55 +01:00
bopol
49aef64cd6 Add settings for device theme (dark & black)
fix bugs related to isLightThemeSelected not handling device themes
such as license having dark background when it should be white
2021-03-18 11:17:06 +01:00
Isira Seneviratne
220bf61e8e Use PrettyTime's new formatUnrounded(OffsetDateTime) method.
Also change the types of the relevant variables from Calendar to OffsetDateTime.
2021-03-18 06:38:12 +05:30
TobiGr
3d713a27a5 Fix bottom controls being out of the screen
This was caused by too large end screen thumbnails enlarging the whole palyer. Fixed by scaling the thumbnail.

Ensure that the player does not use the whole screen height in detail fragment to keep the additional content like title, comments, etc. available.
2021-03-14 17:52:15 +01:00
Fynn Godau
ae2dd20795 Bandcamp support 2021-03-14 17:52:15 +01:00
Stypox
c401e8ad76 Hide meta info panel in search when starting a new search 2021-03-12 23:21:54 +01:00
Stypox
0ea6b4928c Add report/solve-recaptcha button in error panel
It will be shown even when nothing could be loaded not due to a network error, and the user can choose to ignore or report it.

Also improve error reporting arguments
Also completely refactor error activity
Also improve some code here and there
2021-03-12 23:21:49 +01:00
Stypox
bb398189d6 Move all error-related classes into error package 2021-03-07 17:49:28 +01:00
TiA4f8R
78e37c1705 Add different error messages for SoundCloud and YouTube unavailable contents
Add new error strings for the six new exceptions created in the extractor and catch these exceptions. Extractor is, of course, updated with this PR.
2021-03-07 15:33:25 +01:00
TiA4f8R
6b5b6218c8 Fix some things in ShareUtils.java and do little improvements
Fix a bug in which NewPipe doesn't fall back to Google Play Store web url in InstallApp
Fusion getDefaultBrowserPackageName and getDefaultAppPackageName, rename openInDefaultApp to openAppChooser
Update some JavaDocs
2021-01-30 15:55:44 +01:00
TiA4f8R
26690d6233 Fix crash when no browser is present and use an ACTION_CHOOSER intent in the app update notification (#5429)
Fix crash when no browser is present and use an ACTION_CHOOSER intent for app update notification
Show a Toast when no app is present on user's device to open a content in an app and in a browser and use an ACTION_CHOOSER intent with the ACTION_VIEW intent put as an extra intent in the update notification.
2021-01-18 21:45:36 +01:00