Commit graph

2799 commits

Author SHA1 Message Date
TiA4f8R
098f781b05 Add JavaDocs on created views 2021-10-16 13:41:04 +02:00
TiA4f8R
ddc3916437 Use a custom EditText everywhere to be able to share with ShareUtils the selected text
This EditText class extends the AppCompatEditText class from androidx.

These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:41:03 +02:00
TiA4f8R
a6bebe7b54 Use a custom TextView everywhere to be able to share with ShareUtils the selected text
This TextView class extends the AppCompatTextView class from androidx.

These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:40:54 +02:00
litetex
660408e35b Merge pull request #7222 from ktprograms/queue-menu-channel-details
Added the 'Show Channel Details' menu item to the Queue long press menu
2021-10-15 20:28:18 +02:00
litetex
4989c06916 Fixed format of code 2021-10-15 20:18:52 +02:00
litetex
63b6e074a7 Improved documentation 2021-10-15 20:16:34 +02:00
ktprograms
d33d390250 Add reasoning for separate openChannelFragmentUsingIntent method 2021-10-14 09:51:25 +08:00
litetex
617cde9930 Merge pull request #7194 from KalleStruik/add-to-playlist-in-share
Add a "add to playlist" option in the share menu
2021-10-13 20:34:07 +02:00
TobiGr
2affa4a1c3 Merge branch 'master' into dev 2021-10-12 20:03:42 +02:00
litetex
446a9bb0ea Merge pull request #7224 from vhouriet/vhouriet_fix_check-background-player-type
Check if background player already active before displaying player toast
2021-10-12 19:47:50 +02:00
TobiGr
d17ece226a Move checking for new version to MainAcitvity
When the service is started from the Application class, the app might be still in the background. This is definetly not the case when MainActivity.onCreate() is called.

Fixes #7227
2021-10-12 16:45:01 +02:00
litetex
891867b38e Merge pull request #7215 from litetex/code-cleanup-drawer-main-activity
Deduplicated drawer code in MainActivity
2021-10-11 21:29:42 +02:00
litetex
1470d4d43e Merge pull request #7202 from vhouriet/vhouriet_bug_issue-6662
Fix clicking timestamp shows Toast "Playing in popup mode"
2021-10-11 21:20:26 +02:00
vhouriet
cbe10ab3ea Check player type before displaying background player toast 2021-10-11 19:41:22 +02:00
ktprograms
ea6e99eff9 Added the 'Show Channel Details' menu item to the Queue long press menu
Created a method in NavigationHelper that opens the channel fragment using an Intent to MainActivity instead of replacing fragments.
2021-10-11 14:47:37 +08:00
TobiGr
3a7f39d684 Simplify code and add annotations 2021-10-10 20:33:05 +02:00
Kalle Struik
5ab0946c70 Fix cursor color in PlaylistCreationDialog 2021-10-10 12:32:57 +02:00
litetex
3c4e392ce1 Add to playlist - Showing toast that this may take a moment 2021-10-09 18:47:36 +02:00
litetex
2361d32f75 Cleaned up PlaylistDialog-related code 2021-10-09 18:46:20 +02:00
litetex
f9f59642f3 Deduplicated drawer code in MainActivity 2021-10-09 16:37:34 +02:00
Robin
cf7cd4551e Fix crash on missing title when sharing livestream 2021-10-08 21:42:01 +02:00
vhouriet
fc5e090d03 Fix clicking timestamp shows Toast "Playing in popup mode"
Fixes #6662
2021-10-05 18:15:36 +02:00
litetex
bcf9ceaa83 Use the correct TAG in NavigationHelper 2021-10-03 22:04:34 +02:00
Kalle Struik
ff82c0e585 Set the theme for PlaylistCreationDialog explicitly. 2021-10-03 14:25:50 +02:00
Kalle Struik
6a97942a6e Rename the "append_playlist" string to "add_to_playlist" 2021-10-03 13:27:24 +02:00
Kalle Struik
dc999b4f71 Add a add to playlist option in the share menu. 2021-10-02 19:21:25 +02:00
Tobi
c1444b75cd Merge pull request #7176 from litetex/fix-progress-bar-end-not-synced
Fixed seekbar not completed after video end
2021-10-02 09:24:59 +02:00
Tobi
c95ac17837 Merge pull request #6980 from bravenewpipe/check-for-update-after-toggle-and-restart
resets the expire date for checking for updates
2021-10-02 09:07:05 +02:00
Tobi
2c50cc29f2 Add a comment 2021-10-02 08:53:03 +02:00
litetex
163ff5737b Merge pull request #7150 from TacoTheDank/groupieBump
Update Groupie library to 2.9.0
2021-09-30 21:26:58 +02:00
Tobi
d195c11bc5 Merge pull request #7178 from Redirion/dsblmdtnnelrealtekatv
Disable media tunneling on RealtekATV
2021-09-28 07:53:11 +02:00
Robin
18128ce364 Merge pull request #7166 from litetex/various-fixes-for-mediasession-player
Various fixes related to MediasessionManager
2021-09-27 23:45:38 +02:00
Robin
d1089d6252 Disable media tunneling on RealtekATV 2021-09-27 13:21:04 +02:00
Laksh
5d827623e2 Make requested changes 2021-09-27 01:45:33 +05:30
litetex
e9669884f5 Referenced issue in code 2021-09-26 20:58:49 +02:00
litetex
085990c609 Fixed progress bar not completing after video end 2021-09-26 20:50:24 +02:00
Laksh
4aa77b0145 Fix Settings import 2021-09-25 15:37:07 +05:30
litetex
9aaa75fd3d Improved streamType check and documentation 2021-09-25 10:31:42 +02:00
litetex
45a1900b27 Removed useless check for livestreams 2021-09-25 00:04:53 +02:00
litetex
2f5f052aa4 Reformatted MediaSessionManager code 2021-09-24 23:55:06 +02:00
litetex
b44e9ccd7f Fixed performance problems with mediaSessionManager
* Built on top of Redirons changes
* MediaSessionManager-Metadata get's only update when metadata changes - not every second as it only changes when the metadata changes
* Reworked mediasessionmanager
2021-09-24 23:40:12 +02:00
Robin
52a83f3f47 Two fixes for setMetadata 2021-09-24 23:28:55 +02:00
TacoTheDank
b23e7a4134 Regenerate some drawables to their latest design 2021-09-22 23:38:01 -04:00
TacoTheDank
513c5da106 Update Groupie to 2.9.0 2021-09-22 19:08:03 -04:00
Stypox
890b5b3895 Merge branch 'master' into dev 2021-09-19 22:37:00 +02:00
Stypox
b2a2984ffb Fix restoring orientation in onBack 2021-09-19 19:09:11 +02:00
z3r0r4
ac3a8214b2 Add play next to long press menu & refactor enqueue methods (#6872)
* added mvp play next button in long press menu; new intent handling, new long press dialog entry, new dialog functions, new strings

* changed line length for checkstyle pass

* cleaned comments, moved strings

* Update app/src/main/res/values/strings.xml

to make long press entry more descriptive

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>

* Update app/src/main/res/values/strings.xml

Co-authored-by: Stypox <stypox@pm.me>

* replace redundant nextOnVideoPlayer methods

Co-authored-by: Stypox <stypox@pm.me>

* add enqueueNextOnPlayer and enqueueOnPlayer without selectOnAppend and RESUME_PLAYBACK/ deprecate enqueueNextOn*Player and enqueueOn*Player methods
add getPlayerIntent, getPlayerEnqueueIntent and getPlayerEnqueueNextIntent without selectOnAppend and RESUME_PLAYBACK/ deprecate those with
add section comments

* removed deprecated methods
removed redundant methods

* removed deprecated methods
removed redundant methods

* replaced APPEND_ONLY, removed SELECT_ON_APPEND / replaced remaining enqueueOn*Player methods

* now works with playlists

* renamed dialog entry

* checking for >1 items in the queue using the PlayerHolder

* making enqueue*OnPlayer safe to call when no video is playing (defaulting to audio)

* corrected strings

* improve getQueueSize in PlayerHolder

* long press to enqueue only if queue isnt empty

* add Whitespace

Co-authored-by: Stypox <stypox@pm.me>

* clarify comments / add spaces

* PlayerType as parameter of the enqueueOnPlayer method
add Helper method

* using the helper function everywhere (except for the background and popup long-press actions (also on playlists, history, ...)), so basically nowhere
/ passing checkstyle

* assimilated the enqueue*OnPlayer methods

* removed redundant comment, variable

* simplify code line

Co-authored-by: Stypox <stypox@pm.me>

* move if

* replace workaround for isPlayerOpen()

Co-authored-by: Stypox <stypox@pm.me>

* replaced workarounds (getType), corrected static access with getInstance

* remove unused imports

* changed method call to original, new method doesnt exist yet.

* Use getter method instead of property access syntax.

* improve conditional for play next entry

Co-authored-by: Stypox <stypox@pm.me>

* show play next btn in feed fragment

Co-authored-by: Stypox <stypox@pm.me>

* add play next to local playlist and statistics fragment

Co-authored-by: Stypox <stypox@pm.me>

* formating

Co-authored-by: Stypox <stypox@pm.me>

* correcting logic

Co-authored-by: Stypox <stypox@pm.me>

* remove 2 year old unused string, formating

Co-authored-by: Stypox <stypox@pm.me>

* correct enqueue (next) conditionals, default to background if no player is open. Dont generally default to background play.

* remove player open checks from button long press enqueue actions

* improve log msg

* Rename next to enqueue_next

* Refactor kotlin

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2021-09-18 11:22:49 +02:00
Tobi
adca165238 Merge pull request #7068 from litetex/fix-restart
Fixed restarting not working properly
2021-09-11 12:51:38 +02:00
Tobi
01c7041d6f Merge pull request #7056 from TeamNewPipe/fix/playOnPopup
Fix handling exception in `playOnPopup` and toggle description tab
2021-09-10 18:21:41 +02:00
thefalsedev
33a13651f9 Change player progress bar update from 500 ms to 1 s
Just like in the issue 7062, https://github.com/TeamNewPipe/NewPipe/issues/7062, this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
2021-09-07 00:04:05 +02:00