Commit graph

903 commits

Author SHA1 Message Date
TobiGr
3359bf20bf Fix inconsistency when LocalPlaylist is used as MainFragment tab 2023-10-02 02:56:30 +02:00
Yingwei Zheng
63558cf206 Fix inconsistency between user interaction and database commit order when re-adding videos to the playlist 2023-10-02 02:56:30 +02:00
Stypox
b5b5017224 Make question mark localizable 2023-09-22 10:14:45 +02:00
Stypox
7828cd233d Separate imageListToDbUrl from choosePreferredImage
imageListToDbUrl should be used if the URL is going to be saved to the database, to avoid saving nothing in case at the moment of saving the user preference is to not show images.
2023-09-22 10:14:44 +02:00
Stypox
e97da723fc Add documentation and fix SonarCloud issue 2023-09-22 10:14:44 +02:00
Stypox
3f39514e3b Display all thumbnails in description tab 2023-09-22 10:14:44 +02:00
Stypox
4164bf36f6 Implement better image selection strategy 2023-09-22 10:14:44 +02:00
Stypox
a6a7c2271a Add image quality preference 2023-09-22 10:14:43 +02:00
Stypox
46109ff3b9 Support obtaining multiple images from the extractor 2023-09-22 09:57:33 +02:00
TobiGr
ce58a60397 Add comments and annotations 2023-09-20 15:41:21 +02:00
TobiGr
4bbcfdc3e5 Fix three memory leaks
Add documentation to BaseFragment.initViews(View, Bundle) and BaseFragment.initListeners()
2023-09-19 00:13:16 +02:00
TobiGr
529bdb1aae Fix previous ActionBar title visible for a few miliseconds when opening ChannelFragment 2023-09-18 23:22:32 +02:00
TobiGr
60a97b0486 Apply review
Co-Authored-By:  Audric V <74829229+AudricV@users.noreply.github.com>
2023-09-18 23:22:32 +02:00
TobiGr
b134d75549 Deduplicate code to initialize ClickListeners on playlist controls
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.

The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
2023-09-18 23:22:32 +02:00
AudricV
5af4db41ae Hide the upload date element on the About tab
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
2023-09-18 23:22:32 +02:00
AudricV
88419ec7b1 Always show the About tab and support having no description 2023-09-18 23:22:32 +02:00
TobiGr
2f65b4f823 Add missing @Override annotations to setupMetadata() implementations 2023-09-18 23:22:32 +02:00
Stypox
43097e4486 Update NewPipeExtractor and adapt imports 2023-09-18 23:22:32 +02:00
Stypox
b26c5a7d5c Improve placeholder channel banner handling
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
2023-09-18 23:22:32 +02:00
Stypox
486664f293 Add avatar and bannner URLs to channel About tab 2023-09-18 23:22:32 +02:00
Stypox
5613a89099 Add space above channel description (About tab) 2023-09-18 23:22:32 +02:00
ThetaDev
8f7cbc93ef feat: add playlist controls to channel tab 2023-09-18 23:22:32 +02:00
Stypox
b900ddaadf Fix some code smells 2023-09-18 23:22:32 +02:00
Stypox
fc402a8742 Fix channel tabs in main page setting title themselves 2023-09-18 23:22:32 +02:00
Stypox
aa4ec2f39e Channels are now an Info
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
2023-09-18 23:22:32 +02:00
ThetaDev
6c60ef9a9c fix: notification menu option disappears when switching tabs 2023-09-18 23:22:32 +02:00
Stypox
559a1a46e1 Move channel header to collapsible app bar 2023-09-18 23:22:32 +02:00
ThetaDev
7a99f4910d fix: NPE in ChannelFragment::onSaveInstanceState 2023-09-18 23:22:32 +02:00
ThetaDev
59426378f1 refactor: rename ChannelInfo to ChannelAbout
fix: localize about tab name
2023-09-18 23:22:32 +02:00
ThetaDev
397234a40f cleanup: remove empty constructor from ChannelFragment 2023-09-18 23:22:31 +02:00
ThetaDev
13496f4533 refactor: common code from ChannelInfo/Description -> BaseInfoFragment 2023-09-18 23:22:31 +02:00
ThetaDev
773a6a8c7e fix: channel tab title not being set 2023-09-18 23:22:31 +02:00
ThetaDev
72968fbefe fix: ChannelFragment: save last tab 2023-09-18 23:22:31 +02:00
ThetaDev
cd797a6bef refactor: adjustments to updated tab extractor API 2023-09-18 23:22:31 +02:00
ThetaDev
ca9102dd4c fix: cache channel data 2023-09-18 23:22:31 +02:00
ThetaDev
5ce45cd4f2 fix: remember selected channel tab on screen rotation 2023-09-18 23:22:31 +02:00
ThetaDev
1b0528870a feat: add option to hide channel tabs 2023-09-18 23:22:31 +02:00
ThetaDev
5d3bf427a3 feat: prettier channel info page 2023-09-18 23:22:31 +02:00
ThetaDev
c32feb3624 fix: handle unsupported content 2023-09-18 23:22:31 +02:00
ThetaDev
4e6b72dc8e fix: get notified menu option on all tabs 2023-09-18 23:22:31 +02:00
ThetaDev
11f83b8e24 feat: add channel tabs 2023-09-18 23:22:31 +02:00
Stypox
e2bb7b42e8 Update app/src/main/java/org/schabi/newpipe/fragments/list/BaseListInfoFragment.java 2023-08-06 10:07:13 +02:00
TobiGr
2839babfb3 Adjust empty state message for ListInfoFragments depending on Info stream type
Show "no streams" for SoundClound.
Show "no live streams" for MeidaCCCLiveStreamKiosk.
Otherwise show "no videos"
2023-08-05 03:50:28 +02:00
Tobi
395e1ce83e Merge pull request #9719 from Marius1501/tabs_on_bottom
Added bottom main-tabs feature
2023-07-18 22:03:47 +02:00
TacoTheDank
fc320354b1 Clean up AlertDialogs 2023-07-11 21:54:10 -04:00
Stypox
3e8b074fff Fix uploader and subchannel avatars swapped 2023-05-03 10:35:28 +02:00
AudricV
f073060d97 Add Open in browser button to audio external players dialog
This change makes the dialog consistent with the video one.
2023-05-02 00:18:46 +02:00
ThetaDev
bd9c130fef Merge branch 'dev' of github.com:TeamNewPipe/NewPipe into alang-selector 2023-04-05 14:06:14 +02:00
Marius Wagner
efbb06fd84 Update app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Co-authored-by: Stypox <stypox@pm.me>
2023-04-04 09:57:06 +02:00
ge78fug
f8bd9ac05f Changed the naming 2023-04-04 09:57:06 +02:00