Commit graph

154 commits

Author SHA1 Message Date
ix5
393491281e Downloader: Deleter: Dismiss previous Snackbars
Bug:
In Downloader view, while deleting items, Snackbars at the
bottom of the UI keep queuing up. You need to wait for all
of them to dismiss themselves for files to actually be
deleted. If you close NewPipe before all snackbars are
dismissed, your files will not be deleted and show up again
next time you start NewPipe.

Fix:
When running append(), trigger the commit() action
immediately and cancel all delayed callbacks for commit().

This prevents Snackbars from stacking up in reverse order.

Fixes: https://github.com/TeamNewPipe/NewPipe/issues/5660
2021-05-04 19:44:09 +02:00
TacoTheDank
7640aa85c3 Migrate rest of AlertDialogs to AppCompat 2021-04-04 10:26:38 -04:00
krlvm
a8de222577 Fix Dark elements in Light Theme 2021-03-27 17:46:05 +03:00
Stypox
22c92f1fb3 Completely remove return activity, now outdated 2021-03-12 23:21:54 +01:00
Stypox
0ea6b4928c Add report/solve-recaptcha button in error panel
It will be shown even when nothing could be loaded not due to a network error, and the user can choose to ignore or report it.

Also improve error reporting arguments
Also completely refactor error activity
Also improve some code here and there
2021-03-12 23:21:49 +01:00
Stypox
bb398189d6 Move all error-related classes into error package 2021-03-07 17:49:28 +01:00
TiA4f8R
e44495af9a Apply the requested changes and little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.

Apply the requested changes and do little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
2021-01-16 13:23:42 +01:00
TiA4f8R
d2cb003585 External sharing improvements
Improve NewPipe's share on some devices + fix crash when no browser is set on some devices

Catching ActivityNotFoundException when trying to open the default browser
Use an ACTION_CHOOSER intent and put as an extra intent the intent to
open an URI / share an URI when no default app is set.

Add a LinkHelper class which set a custom action when clicking web links
in the description of a content. This class also helps to implement a confirmation dialog when trying to open web links in an external app.
2021-01-16 13:23:06 +01:00
Isira Seneviratne
55c770cd1b Use Objects.requireNonNull(). 2021-01-02 09:36:33 +05:30
Isira Seneviratne
da095794a4 Use ServiceCompat.stopForeground(). 2020-12-19 16:52:17 +05:30
Isira Seneviratne
288a9ce2af Use a notification instead of a ProgressDialog in MissionAdapter. 2020-12-13 05:21:38 +05:30
Tobias Groza
2796608428 Merge pull request #4961 from TeamNewPipe/lint
Fix some Lint errors
2020-12-07 11:19:01 +01:00
Stypox
57c28a9a9c Fix ktlint errors 2020-11-22 14:03:10 +01:00
Stypox
34dd7c0fbf Update most dependencies 2020-11-22 14:03:10 +01:00
TobiGr
397ca000e3 Fix typos 2020-11-22 10:39:00 +01:00
TobiGr
40d32034dd Fix Lint: Inconsistent line separators 2020-11-22 10:16:27 +01:00
Isira Seneviratne
a2500345d6 Use try-with-resources. 2020-11-21 13:47:13 +05:30
Isira Seneviratne
39a008db6e Convert ErrorInfo to Kotlin and use the Parcelize annotation. 2020-11-21 12:47:35 +05:30
Isira Seneviratne
4556af1b67 Convert MissionRecoveryInfo to Kotlin and use the Parcelize annotation. 2020-11-21 12:47:29 +05:30
TacoTheDank
04f9272706 Lint: Inner class may be static 2020-11-18 18:02:33 -05:00
TacoTheDank
c1aca23fa4 Lint: Redundant 'new' expression in constant array creation 2020-11-18 17:52:30 -05:00
TacoTheDank
497e145c70 Lint: Make a bunch of stuff final 2020-11-18 17:50:00 -05:00
Stypox
129ca6c2e2 Merge pull request #4784 from bd0n4lds/Dont-Use-Float-Type-For-Loop-Indices
Change loop index from float to int
2020-11-09 13:04:17 +01:00
Bri@n
8f8429d575 Change loop index from float to int 2020-11-09 12:55:59 +01:00
Isira Seneviratne
1f4469f1dc Use RxJava instead of AsyncTask in MissionAdapter. 2020-11-05 11:06:51 +05:30
Isira Seneviratne
9a367f4d46 Use Collection.removeIf() instead of using Iterator.remove() to remove elements conditionally. 2020-11-01 14:44:07 +05:30
Isira Seneviratne
bda8caa510 Use Comparator's comparing(), nullsLast() and reversed() methods. 2020-11-01 14:44:04 +05:30
TacoTheDank
166cdd50f4 Push conditionals inside branch expressions 2020-10-31 15:57:26 -04:00
TacoTheDank
b8ab82d148 Replace a ContextCompat with LayoutInflater.from 2020-10-31 15:54:19 -04:00
Isira Seneviratne
3da55d9f40 Use ContextCompat.getSystemService() and the Context.getSystemService() extension function. 2020-10-09 08:52:05 +05:30
Stypox
b08501d0f3 Merge pull request #3794 from budde25/download-same-file-crash
Fixes crash when a file is deleted then redownloaded
2020-09-09 15:41:06 +02:00
TacoTheDank
7db90c0561 Clean up SDK version checks 2020-09-06 12:55:30 +02:00
TacoTheDank
0ef2e07cf4 Some general-purpose lint cleanup 2020-09-06 12:55:26 +02:00
TacoTheDank
61c10ad427 Use AndroidX preference 2020-09-06 12:52:42 +02:00
mhmdanas
308eac4e13 Use SubtitlesStream#getUrl instead of getURL 2020-08-26 23:04:18 +03:00
Avently
aef78ace88 Merged the latest changes 2020-07-13 04:17:21 +03:00
Avently
60fd42dfa3 Changes for review 2020-06-27 06:25:50 +03:00
Ethan Budd
d020258294 Fixes crash when a file is deleted then redownloaded 2020-06-18 22:43:06 -05:00
Stypox
c80aba9a88 Use vector drawables instead of PNGs for material icons
For all manually-created images PNG have been kept.
- rename all icon attrs to have a `ic_` prefix
- always use `_24dp` icons, because there is no real difference, since they are vector drawables
- always use the original name found on material.io for icon drawables, as to not create confusion and possibly duplicates. Icon names can still be different from real drawable names, though I have made some of them compliant to this or maybe more meaningul.
- remove duplicate `getIconByAttr()` in ThemeHelper (use `resolveResourceIdFromAttr()`
- use standard icons for `expand_more` and `expand_less` instead of triangles
- use `play_button_outline` instead of custom PNG as play button in VideoDetailFragment (questionable, as there is no shadow anymore)
2020-05-21 15:39:35 +02:00
wb9688
205c5ff2ca Optimize imports 2020-05-01 20:13:01 +02:00
kapodamy
43a95447f8 fix integer overflows
* available() method in ChunkFileInputStream.java
* free "ahead space" calculation in CircularFileWriter.java
2020-04-01 15:30:33 -03:00
kapodamy
c19447b559 fix integer overflow 2020-03-25 16:13:36 -03:00
Xiang Rong Lin
02bb6494dc Fix bug causing crashes when sharing a downloaded file. 2020-02-03 10:43:08 +01:00
bopol
649e188b67 Merge remote-tracking branch 'upstream/dev' into dev
merging dev
2020-02-01 15:11:01 +01:00
bopol
a74f0873a3 fix wrong language shown many popup dialogs
Changed android.R.string.ok, which is "OK", into R.string.finish, which is also OK, but from our strings
Then for a small amount of languages that don't have Android translation, it will show the good string.
2020-02-01 09:44:49 +01:00
Markus Richter
b6108a45bd fixes #3021, see also https://github.com/TeamNewPipe/NewPipe-legacy/pull/21 2020-01-29 13:48:02 +01:00
Tobias Groza
8322c7c496 Merge pull request #2958 from kapodamy/android5-temp-dir-issue
fix #2889
2020-01-26 11:04:45 +01:00
kapodamy
3ed183a7a6 android 5 (lollipop) fixup
this commit attempts to fix the pickAvailableTemporalDir() method in ROMS that not are CTS compliant.
2020-01-14 00:05:34 -03:00
kapodamy
3877cec0ff ttml to srt conversion
rewrite SubtitleConverter (use JSoup library instead, remove unused methods)
2020-01-14 00:04:16 -03:00
TobiGr
30c9d97d1a Use Integer value directly for formatted string
a
2020-01-13 20:25:32 +01:00