Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions
10249 commits 2 branches 0 tags 50 MiB
Commit graph

3345 commits

Author SHA1 Message Date
Tobi
3a3faed2a5 Merge pull request #9065 from devlearner/fix-spannable-cast 
Fix potential cast exception in comments text
 2022-10-10 10:51:32 +02:00
Tobi
9b0c7c24bf Merge pull request #8734 from Stypox/feed-group-factory 
Improve `FeedGroupDialogViewModel` factory
 2022-10-09 19:35:47 +02:00
Tobi
372243db8d Merge pull request #8934 from Isira-Seneviratne/LinkifyCompat 
Use LinkifyCompat.
 2022-10-09 12:07:50 +02:00
Tobi
d697191086 Merge pull request #8946 from HybridAU/add_play_queue_button_to_video_details_fragment 
Add play queue button to video details fragment
 2022-10-06 18:55:50 +02:00
devlearner
c7a98b9ca8 Fix potential cast exception 
when casting to `Spannable` in `CommentTextOnTouchListener`
 2022-10-04 17:31:35 +08:00
Stypox
f2fa9e7e21 Fix feed menu tooltips (silly copy-paste error) 2022-09-19 11:21:42 +02:00
Stypox
7f0a4a33af Merge pull request #8972 from Stypox/fix-suggestions-listadapter 
Fix various issues in the search suggestions list
 2022-09-19 08:54:55 +02:00
Stypox
d13852d128 Merge pull request #8966 from Stypox/feed-menuitem-tooltip 
Show correct tooltips for actions in feed
 2022-09-19 08:54:06 +02:00
HybridAU
dcca274ecc Add play queue button to video details fragment 
* Add play queue button to video details fragment

* Use existing ic_list icon

* Still open play queue even when queue is empty

* Change app:srcCompat to android:src
 2022-09-14 21:00:44 +08:00
Stypox
d78207f6e0 Fix scroll issues in suggestion list 
Before if the list before updating contained item 'test' at position 0 and after updating that value went to the bottom, the list would incorrectly scroll to the bottom to follow that item. Now the scrolling is done after the list is updated.
 2022-09-14 14:39:32 +02:00
Stypox
d6bbb9528b Disable suggestion list animations: not meaningful 
The animations were just in the way and did not help in choosing items, since the suggestion items keep changing too much.
 2022-09-14 14:04:22 +02:00
Stypox
93761a8346 Fix wrong icons being set on suggestion items 
The diff util wrongly considered as equal two items with the same text but with different `fromHistory` value
 2022-09-14 14:01:59 +02:00
Stypox
4c537a7dbc Show correct tooltips for actions in feed 2022-09-13 15:26:04 +02:00
Isira Seneviratne
c7bf092611 Use LinkifyCompat. 2022-09-06 09:27:50 +05:30
Stypox
0e5ad2ec3a Only update notification large icon when it changes 2022-08-28 23:14:02 +02:00
Stypox
3cdc9154ea Use player.getThumbnail() instead of field in VideoPlayerUi 2022-08-28 18:35:21 +02:00
Stypox
9d45c80324 Remove thumbnail before sync, if outdated 
Also refactor onPlaybackSynchronize and add comments
 2022-08-28 18:32:27 +02:00
Stypox
2fd24b745d Unify onThumbnailLoaded calls to ensure UIs always updated 2022-08-28 17:24:51 +02:00
Stypox
b950969250 Prevent tapping on thumbnail if video details are not loaded 2022-08-26 18:54:51 +02:00
Stypox
f5fd7216fd Avoid setting invalid states to bottom sheet callback 2022-08-26 18:54:51 +02:00
Stypox
5bf2971b62 Fix regression in screen rotation animation 2022-08-26 18:54:51 +02:00
Stypox
c224821487 Fix surface view not resizing video correctly 
Also fix yet another random null pointer exception that could happen when adding the video player view
 2022-08-26 18:54:51 +02:00
litetex
cac64a9964 Fixed sonar detected problems 
+ Automatically fixed code style (imports)
 2022-08-25 17:02:53 +02:00
Stypox
624292abe4 Review suggestions 2022-08-25 17:02:53 +02:00
Stypox
ce1b88eeec Keep strong reference to Picasso thumbnail loading target 
Before the Target would sometimes be garbage collected before being called with the loaded thumbnail, since Picasso holds weak references to targets
 2022-08-25 17:02:52 +02:00
Stypox
573b4ff8bc Merge MediaSessionManager into MediaSessionPlayerUi 2022-08-25 17:02:52 +02:00
Stypox
c8066c6eb7 Let exoplayer decide when to update metadata 
Though still make sure metadata is updated after the thumbnail is loaded.
This fixes the wrong seekbar properties (duration and current position) being shown in the notification sometimes.
 2022-08-25 17:02:52 +02:00
Stypox
a4c5d1ee3b Remove useless checks before updating metadata 
A while ago NewPipe called the metadata update function very often, so checks were needed to ensure not wasting time updating metadata if it were already up to date. Now, instead, the metadata update function is called exactly when needed, i.e. when metadata changes, so such checks are not needed anymore (and were probably also a little resource-heavy).
 2022-08-25 17:02:51 +02:00
Stypox
1a4e886d4b Even when thumbnails should not be shown, set it to null in notification 
This makes sure the thumbnail is removed from the notification if the user disables thumbnails
 2022-08-25 17:02:51 +02:00
Stypox
9fe370cda1 Fix sometimes seeing outdated thumbnail in notification 
Before the thumbnail finishes loading for the new video the player is now playing, the old thumbnail was being used, leading to wrong thumbnails set in the media session and the notification.
 2022-08-25 17:02:51 +02:00
Stypox
356fa3f12d Fix thumbnail sometimes not set to media session metadata 
The thumbnail was not being updated in the media session metadata after it was loaded, since there was no metadata update in that case, only a notification update.
 2022-08-25 17:00:41 +02:00
Stypox
97892be897 Remove useless MediaSessionCallback 
The player is now passed directly, it made no sense to wrap around it in a callback that was not really a callback but rather, actually, a wrapper.
 2022-08-25 17:00:41 +02:00
Stypox
aa0a1cd70e Create MediaSessionPlayerUi 2022-08-25 17:00:41 +02:00
Stypox
9bfea8082c Keep strong references to Picasso notification icon loading targets 
Before the Target would sometimes be garbage collected before being called with the loaded channel icon, since Picasso holds weak references to targets. This meant that sometimes a new streams notification  would not be shown, because the lambda that should have shown it had already been garbage collected.
 2022-08-25 16:41:51 +02:00
Isira Seneviratne
77f19bd26f Use ListAdapter in PreferenceSearchAdapter. 2022-08-18 19:52:51 +05:30
Isira Seneviratne
91d4bded3d Use ListAdapter in SuggestionListAdapter. 2022-08-18 19:52:51 +05:30
Isira Seneviratne
6b3bdb04ce Use ListAdapter in PeertubeInstanceListFragment. 2022-08-15 07:26:02 +05:30
Stypox
327ee1bc5a Merge pull request #8666 from TacoTheDank/filepicker 
Update FilePicker to our custom fork and disable Jetifier
 2022-08-12 09:15:34 +02:00
Stypox
647f099b30 Merge pull request #8740 from Isira-Seneviratne/Cleanup_methods 
Remove some unused methods.
 2022-08-06 22:45:40 +02:00
Stypox
5bc82ad0f9 Merge pull request #8738 from Isira-Seneviratne/Collectors_joining 
Use Collectors.joining().
 2022-08-06 22:31:31 +02:00
Stypox
05a8939e7e Merge pull request #8728 from Isira-Seneviratne/Comparator_factory 
Use Comparator factory methods.
 2022-08-06 11:56:44 +02:00
Stypox
43fd5a75bf Improve comment 2022-08-06 11:56:00 +02:00
Stypox
2fac881694 Merge pull request #8724 from Isira-Seneviratne/toArray_improvements 
Use toArray() with zero-length arrays.
 2022-08-06 11:33:05 +02:00
Stypox
735b050c4e Merge pull request #8737 from Isira-Seneviratne/Fix_coerceIn 
Replace coerceIn() with MathUtils.clamp().
 2022-08-06 11:16:06 +02:00
Stypox
1a32c35951 Merge pull request #8708 from Isira-Seneviratne/Reduce_View.kt_size 
Reduce View.kt size.
 2022-08-06 10:59:10 +02:00
Isira Seneviratne
fa9cd7f6e3 Remove unused method. 2022-08-06 06:54:21 +05:30
Isira Seneviratne
1e0abb2f80 Use Collectors.joining(). 2022-08-06 06:54:21 +05:30
Isira Seneviratne
cf52c320fc Remove unused methods in HistoryRecordManager. 2022-08-06 05:09:54 +05:30
Isira Seneviratne
fbf3df2c60 Applied code review changes. 2022-08-05 06:54:03 +05:30
Isira Seneviratne
b49b8f325d Use toArray() with zero-length arrays. 2022-08-05 06:50:55 +05:30