Commit graph

2776 commits

Author SHA1 Message Date
TobiGr
3a7f39d684 Simplify code and add annotations 2021-10-10 20:33:05 +02:00
Robin
cf7cd4551e Fix crash on missing title when sharing livestream 2021-10-08 21:42:01 +02:00
litetex
bcf9ceaa83 Use the correct TAG in NavigationHelper 2021-10-03 22:04:34 +02:00
Tobi
c1444b75cd Merge pull request #7176 from litetex/fix-progress-bar-end-not-synced
Fixed seekbar not completed after video end
2021-10-02 09:24:59 +02:00
Tobi
c95ac17837 Merge pull request #6980 from bravenewpipe/check-for-update-after-toggle-and-restart
resets the expire date for checking for updates
2021-10-02 09:07:05 +02:00
Tobi
2c50cc29f2 Add a comment 2021-10-02 08:53:03 +02:00
litetex
163ff5737b Merge pull request #7150 from TacoTheDank/groupieBump
Update Groupie library to 2.9.0
2021-09-30 21:26:58 +02:00
Tobi
d195c11bc5 Merge pull request #7178 from Redirion/dsblmdtnnelrealtekatv
Disable media tunneling on RealtekATV
2021-09-28 07:53:11 +02:00
Robin
18128ce364 Merge pull request #7166 from litetex/various-fixes-for-mediasession-player
Various fixes related to MediasessionManager
2021-09-27 23:45:38 +02:00
Robin
d1089d6252 Disable media tunneling on RealtekATV 2021-09-27 13:21:04 +02:00
Laksh
5d827623e2 Make requested changes 2021-09-27 01:45:33 +05:30
litetex
e9669884f5 Referenced issue in code 2021-09-26 20:58:49 +02:00
litetex
085990c609 Fixed progress bar not completing after video end 2021-09-26 20:50:24 +02:00
Laksh
4aa77b0145 Fix Settings import 2021-09-25 15:37:07 +05:30
litetex
9aaa75fd3d Improved streamType check and documentation 2021-09-25 10:31:42 +02:00
litetex
45a1900b27 Removed useless check for livestreams 2021-09-25 00:04:53 +02:00
litetex
2f5f052aa4 Reformatted MediaSessionManager code 2021-09-24 23:55:06 +02:00
litetex
b44e9ccd7f Fixed performance problems with mediaSessionManager
* Built on top of Redirons changes
* MediaSessionManager-Metadata get's only update when metadata changes - not every second as it only changes when the metadata changes
* Reworked mediasessionmanager
2021-09-24 23:40:12 +02:00
Robin
52a83f3f47 Two fixes for setMetadata 2021-09-24 23:28:55 +02:00
TacoTheDank
b23e7a4134 Regenerate some drawables to their latest design 2021-09-22 23:38:01 -04:00
TacoTheDank
513c5da106 Update Groupie to 2.9.0 2021-09-22 19:08:03 -04:00
Stypox
890b5b3895 Merge branch 'master' into dev 2021-09-19 22:37:00 +02:00
Stypox
b2a2984ffb Fix restoring orientation in onBack 2021-09-19 19:09:11 +02:00
z3r0r4
ac3a8214b2 Add play next to long press menu & refactor enqueue methods (#6872)
* added mvp play next button in long press menu; new intent handling, new long press dialog entry, new dialog functions, new strings

* changed line length for checkstyle pass

* cleaned comments, moved strings

* Update app/src/main/res/values/strings.xml

to make long press entry more descriptive

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>

* Update app/src/main/res/values/strings.xml

Co-authored-by: Stypox <stypox@pm.me>

* replace redundant nextOnVideoPlayer methods

Co-authored-by: Stypox <stypox@pm.me>

* add enqueueNextOnPlayer and enqueueOnPlayer without selectOnAppend and RESUME_PLAYBACK/ deprecate enqueueNextOn*Player and enqueueOn*Player methods
add getPlayerIntent, getPlayerEnqueueIntent and getPlayerEnqueueNextIntent without selectOnAppend and RESUME_PLAYBACK/ deprecate those with
add section comments

* removed deprecated methods
removed redundant methods

* removed deprecated methods
removed redundant methods

* replaced APPEND_ONLY, removed SELECT_ON_APPEND / replaced remaining enqueueOn*Player methods

* now works with playlists

* renamed dialog entry

* checking for >1 items in the queue using the PlayerHolder

* making enqueue*OnPlayer safe to call when no video is playing (defaulting to audio)

* corrected strings

* improve getQueueSize in PlayerHolder

* long press to enqueue only if queue isnt empty

* add Whitespace

Co-authored-by: Stypox <stypox@pm.me>

* clarify comments / add spaces

* PlayerType as parameter of the enqueueOnPlayer method
add Helper method

* using the helper function everywhere (except for the background and popup long-press actions (also on playlists, history, ...)), so basically nowhere
/ passing checkstyle

* assimilated the enqueue*OnPlayer methods

* removed redundant comment, variable

* simplify code line

Co-authored-by: Stypox <stypox@pm.me>

* move if

* replace workaround for isPlayerOpen()

Co-authored-by: Stypox <stypox@pm.me>

* replaced workarounds (getType), corrected static access with getInstance

* remove unused imports

* changed method call to original, new method doesnt exist yet.

* Use getter method instead of property access syntax.

* improve conditional for play next entry

Co-authored-by: Stypox <stypox@pm.me>

* show play next btn in feed fragment

Co-authored-by: Stypox <stypox@pm.me>

* add play next to local playlist and statistics fragment

Co-authored-by: Stypox <stypox@pm.me>

* formating

Co-authored-by: Stypox <stypox@pm.me>

* correcting logic

Co-authored-by: Stypox <stypox@pm.me>

* remove 2 year old unused string, formating

Co-authored-by: Stypox <stypox@pm.me>

* correct enqueue (next) conditionals, default to background if no player is open. Dont generally default to background play.

* remove player open checks from button long press enqueue actions

* improve log msg

* Rename next to enqueue_next

* Refactor kotlin

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2021-09-18 11:22:49 +02:00
Tobi
adca165238 Merge pull request #7068 from litetex/fix-restart
Fixed restarting not working properly
2021-09-11 12:51:38 +02:00
Tobi
01c7041d6f Merge pull request #7056 from TeamNewPipe/fix/playOnPopup
Fix handling exception in `playOnPopup` and toggle description tab
2021-09-10 18:21:41 +02:00
thefalsedev
33a13651f9 Change player progress bar update from 500 ms to 1 s
Just like in the issue 7062, https://github.com/TeamNewPipe/NewPipe/issues/7062, this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
2021-09-07 00:04:05 +02:00
litetex
6f0ea582d9 Fixed the app restarting not working properly
* Using [``process-phoenix``](https://github.com/JakeWharton/ProcessPhoenix)
2021-09-06 20:47:44 +02:00
TobiGr
5a257f9ebb Fix a few SonarLint warnings 2021-09-05 19:54:28 +02:00
TobiGr
e4dc4c0049 Fix OnErrorNotImplementedException in SearchFragment.initSuggestionObserver()
Hopefully also fix the cause of the original error.
2021-09-05 19:54:28 +02:00
TobiGr
70ec9bcfc0 Fix OnErrorNotImplementedException in playOnPopup 2021-09-05 19:54:28 +02:00
TobiGr
f9410ec0f1 Fix updating the wrong tabs when changing settings while running the minimized player in VideoDetailFragment
The comments tab was updated although the settings for the description tab were changed.
2021-09-04 22:36:47 +02:00
Tobi
cf157515a5 Merge pull request #7043 from Stypox/optimize-resources
Remove unused resources
2021-09-04 20:57:07 +02:00
Stypox
e2af6c6bc9 Remove unused resources 2021-09-02 21:13:54 +02:00
evermind
666b6a8323 check immediately for updates if user enables 'check for updates setting'
- Convert CheckForNewAppVersion to IntentService
- reset expire date to 0 after user enables check for updates setting
2021-09-02 07:20:35 +02:00
Stypox
a551cc72f6 Move fullscreen-related comments to javadocs 2021-09-01 20:13:27 +02:00
Stypox
d330da58a8 Fix null pointer exception in player initialization 2021-09-01 20:13:27 +02:00
Stypox
e825e9db55 Completely close player when changing stream w/o autoplay 2021-09-01 20:13:27 +02:00
Stypox
e5e654043a Open fullscreen when switching from popup to main player 2021-09-01 20:13:24 +02:00
Stypox
635cd7e493 Fix bottom sheet state after automatic fullscreen 2021-09-01 20:12:14 +02:00
Stypox
70e8065ea6 Fix opening directly fullscreen on tablets 2021-09-01 20:12:09 +02:00
Stypox
b2e0859e8a Extract isLandscape and isInMultiWindow to DeviceUtils 2021-09-01 20:09:08 +02:00
Stypox
28c1384391 Add option to directly open fullscreen when the main player starts 2021-09-01 20:08:37 +02:00
Stypox
90e6621eb7 Merge pull request #7004 from litetex/fix-showTextError-and-rework-ErrorPanel
Reworked the ErrorPanel
2021-08-31 18:26:51 +02:00
Robin
c76ebb21f5 Merge pull request #6993 from Redirion/closeaudioeffectsession
Close audio effect control session properly
2021-08-31 12:37:20 +02:00
Stypox
ef08fce9f1 Merge pull request #6955 from ktprograms/queue-long-press-menu
Show popup menu when long pressing in play queue (Full screen player)
2021-08-31 12:22:59 +02:00
Stypox
eb8dfe2a44 Merge pull request #6882 from talanc/dev
Add support for CSV+ZIP subscriptions (Google Takeout)
2021-08-31 12:10:12 +02:00
Stypox
114f9e1cce Improve mime type deduction on subscription import 2021-08-31 12:07:34 +02:00
talanc
fb0cb7d982 Added support for CSV+ZIP subscriptions
Updated import instructions string
2021-08-31 12:07:34 +02:00
Stypox
bde378618d Merge pull request #7024 from Stypox/string-fixes
Never use ``android.R.string``s; remove unused ``add`` string
2021-08-31 12:00:07 +02:00