Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions
9587 commits 21 branches 0 tags 50 MiB
Commit graph

363 commits

Author SHA1 Message Date
TobiGr
40103c07d2 Apply feedback 
Return this in InfoIrtemDialog.Builder methoods.
Move null checks for InfoIrtemDialog.Builder into constructor.
Fix and add some more docs.
 2022-02-20 20:17:04 +01:00
TobiGr
c0ab407cf6 Use identical method names for creating the InfoItemDialog in Fragments 2022-02-20 20:17:04 +01:00
TobiGr
df28deb880 Use Context instead of Activity 
Improve docs
 2022-02-20 20:17:04 +01:00
TobiGr
f9ad08d977 Add default entries automatically 2022-02-20 20:17:04 +01:00
TobiGr
597192ce99 Extract entries into beginning and end category 2022-02-20 20:17:04 +01:00
TobiGr
9f3031bc3a Refactor generating InfoItemDialog's 
This commit refactors the way `InfoItemDialog`s are generated. This is necessary because the old way used  the `StreamDialogEntry` enum for most of the dialogs' content generation process. This required static variables and methods to store the entries which are used for the dialog to be build (See e.g.`enabledEntries` and methods like `generateCommands()`). In other words, `StreamDialogEntry` wasn't an enumeration anymore.

To address this issue, a `Builder` is introduced for the `InfoItemDialog`'s genration. The builder also comes with some default entries and and a specific order. Both can be used, but are not enforced. 

A second problem that introduced a structure which was atypical for an enumeration was the usage of non-final attributes within `StreamDialogEntry` instances. These were needed, because the default actions needed to overriden in some cases.

To address this problem, the `StreamDialogEntry` enumeration was renamed to `StreamDialogDefaultEntry` and a new `StreamDialogEntry` class is used instead.
 2022-02-20 20:17:04 +01:00
Stypox
a9f6c8d726 Do not show enqueue button if play queue not ready 2022-01-27 17:11:16 +01:00
mhmdanas
f87a5ecead Fix false warning 2022-01-18 07:40:59 +03:00
TobiGr
778f57b422 Small improvements to code quality and readability 
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
 2021-12-21 20:55:41 +01:00
litetex
3ecaf66e1a Merge pull request #7452 from litetex/show-alert-when-file-manager-not-found 
Show an alert-dialog when no appropriate file-manager was found
 2021-12-14 20:01:02 +01:00
litetex
960cd67321 Merge pull request #7482 from TeamNewPipe/unify-error-reporting 
Unify error reporting and add error notification
 2021-12-14 19:58:41 +01:00
XiangRongLin
561819e68c Merge pull request #7491 from Stypox/fix-search-order 
Fix order of local search results
 2021-12-14 09:07:17 -05:00
Stypox
de83cff1e1 Fix order of local search results 2021-12-08 13:59:32 +01:00
TacoTheDank
9ccd358cb8 Update ktlint to 0.43.2 2021-12-04 21:22:29 -05:00
Stypox
9ac1add14c Prevent exception from being serialized in ErrorInfo 
The wrong @Decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
 2021-12-04 10:36:36 +01:00
Stypox
5583f71a8e Replace ErrorActivity with ErrorUtil 2021-12-04 10:36:36 +01:00
litetex
625ffba8b7 Refactoring + deduplicated code 2021-11-28 14:07:45 +01:00
litetex
273e0e7f06 Fixed typos 2021-11-27 23:39:17 +01:00
litetex
9285958b4f Show an alert/dialog when no appropriate file-manager was found 2021-11-27 15:52:54 +01:00
Stypox
3427253824 Merge pull request #7412 from litetex/code-cleanup 
Some code cleanup(s)
 2021-11-23 08:59:34 +01:00
litetex
d0126265df Fixed typo 2021-11-15 20:24:40 +01:00
TacoTheDank
44552ae2ee Update Groupie to 2.9.0 2021-11-15 20:24:39 +01:00
litetex
a45c9329d5 Improved highlighting in FeedFragment 
Now keeps the ``selectableItemBackground`` when highligthing an item.
 2021-11-15 20:22:23 +01:00
litetex
3b62d45f38 Fixed default visibility of "new feed items" button 
Fixed/Avoid NPEs
 2021-11-15 20:22:22 +01:00
litetex
97767eb990 Removed unnecessary layout 
Moved the feed button up a bit
 2021-11-15 20:22:21 +01:00
litetex
9a42a3a2c6 Used more understandable kotlin methods 2021-11-15 20:22:20 +01:00
litetex
e8727b36c7 Fixed feed when animations are off 
Introduced a check if corresponding animations on the devices are enabled
 2021-11-15 20:22:20 +01:00
litetex
44d3d8b201 Made `hideNewItemsLoaded` more null safe 2021-11-15 20:22:19 +01:00
litetex
047535b665 Make new feed items bold 2021-11-15 20:22:18 +01:00
litetex
1b42543351 Implemented UI highlighting and "new feed items"-notification 
Fixed format
 2021-11-15 20:22:17 +01:00
litetex
0dfbcb8c04 No more reaction to unnecessary feed db-changes 
This caused duplicate events (https://github.com/TeamNewPipe/NewPipe/pull/6686#issuecomment-909575283) and unnecessary processing of items
 2021-11-15 20:21:23 +01:00
Stypox
f27bd764ec Merge pull request #7160 from nschulzke/mark-as-watched-everywhere 
Enable Mark as Watched in all the other playlist fragments.
 2021-11-13 20:37:59 +01:00
Nathan Schulzke
517a98bdf9 Factor out shouldAddMarkAsWatched as a shared function 2021-11-13 10:18:17 -07:00
litetex
1c615bc292 Fixed toggle not in sync with list after app restart + refactored the code a bit 2021-11-11 19:46:15 +01:00
Baji Shaik
2df6708f50 moved preference key from viewmodel to settings_keys.xml 2021-11-10 16:16:17 -05:00
Baji Shaik
412453d067 added show watched items toggle preference 
default sharedpreference is used to persist and retrieve show watched menu option toggle state
 2021-11-07 23:11:10 -05:00
litetex
9080d3d6dd Removed `e.printStacktrace` and used an proper logger 2021-11-05 18:04:49 +01:00
litetex
623dff5c2a Merge pull request #7261 from TacoTheDank/bumpRecyclerView 
Update RecyclerView & Groupie libraries
 2021-10-24 21:22:04 +02:00
TacoTheDank
8f7a36dc48 Update RecyclerView & Groupie 2021-10-19 17:31:59 -04:00
TacoTheDank
53cc6737bc Get rid of setUserVisibleHint 2021-10-16 15:33:45 -04:00
litetex
617cde9930 Merge pull request #7194 from KalleStruik/add-to-playlist-in-share 
Add a "add to playlist" option in the share menu
 2021-10-13 20:34:07 +02:00
TobiGr
3a7f39d684 Simplify code and add annotations 2021-10-10 20:33:05 +02:00
Kalle Struik
5ab0946c70 Fix cursor color in PlaylistCreationDialog 2021-10-10 12:32:57 +02:00
litetex
2361d32f75 Cleaned up PlaylistDialog-related code 2021-10-09 18:46:20 +02:00
Kalle Struik
ff82c0e585 Set the theme for PlaylistCreationDialog explicitly. 2021-10-03 14:25:50 +02:00
Kalle Struik
dc999b4f71 Add a add to playlist option in the share menu. 2021-10-02 19:21:25 +02:00
litetex
163ff5737b Merge pull request #7150 from TacoTheDank/groupieBump 
Update Groupie library to 2.9.0
 2021-09-30 21:26:58 +02:00
Robin
18128ce364 Merge pull request #7166 from litetex/various-fixes-for-mediasession-player 
Various fixes related to MediasessionManager
 2021-09-27 23:45:38 +02:00
litetex
9aaa75fd3d Improved streamType check and documentation 2021-09-25 10:31:42 +02:00
Nathan Schulzke
dfe72e0db1 Enable Mark as Watched in all the other playlist fragments. 2021-09-23 21:39:47 -06:00