Commit graph

75 commits

Author SHA1 Message Date
litetex
3e23aa0071 Fixed "Changing the seeks duration does not update the displayed seconds" 2022-01-25 20:44:49 +01:00
litetex
a0dda12849 Code cleanup 2022-01-21 22:49:25 +01:00
litetex
4651c242cc Fixed SonarLint problems
* Removed alphaRelativeDuration as there is no use for it
2022-01-21 22:49:24 +01:00
litetex
1921583ff0 Fixed naming 2022-01-21 22:49:24 +01:00
litetex
5fa27439e3 Respect disabled animations 2022-01-21 22:49:24 +01:00
litetex
f0de6c73b7 Removed all animations to be consistent with the current behavior 2022-01-21 22:49:23 +01:00
litetex
f56439e568 Code cleanup and minimization
* Deduplicated and simplified a lot of code
* Fixed ``invalidSeekConditions`` so that it's possible to seek while the player is loading (like currently the case)
2022-01-21 22:49:23 +01:00
Stypox
0506b94257 Convert SecondsView from kotlin synthetics to view binding 2022-01-21 22:49:22 +01:00
vkay94
de2e6a2d8c SeekOverlay: Switch to merge for SecondsView and other adjustments 2022-01-21 22:49:21 +01:00
vkay94
6252704bbc SeekOverlay: Add seek overlay logic to player 2022-01-21 22:49:21 +01:00
vkay94
f7e7ebfbe0 SeekOverlay: Add Views 2022-01-21 22:49:21 +01:00
TiA4f8R
35401c0103 Adress requested changes and remove an unused return value in NewPipeTextViewHelper 2021-10-16 13:41:05 +02:00
TiA4f8R
4cd970fc97 Merge the Share process of the two classes into one
A new class has been added in the util package: NewPipeTextViewHelper.
It shares the selected text of a TextView with ShareUtils#shareText (with the created shareSelectedTextWithShareUtils static method).
Only this static method can be used by other classes, other methods are private.
2021-10-16 13:41:04 +02:00
TiA4f8R
1cfd513e25 Improve code of created views
Use the same logic as Android TextViews
2021-10-16 13:41:04 +02:00
TiA4f8R
098f781b05 Add JavaDocs on created views 2021-10-16 13:41:04 +02:00
TiA4f8R
ddc3916437 Use a custom EditText everywhere to be able to share with ShareUtils the selected text
This EditText class extends the AppCompatEditText class from androidx.

These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:41:03 +02:00
TiA4f8R
a6bebe7b54 Use a custom TextView everywhere to be able to share with ShareUtils the selected text
This TextView class extends the AppCompatTextView class from androidx.

These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:40:54 +02:00
TiA4f8R
e44495af9a Apply the requested changes and little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.

Apply the requested changes and do little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
2021-01-16 13:23:42 +01:00
Isira Seneviratne
0f66853a9a Convert AnimationUtils functions to extension functions. 2021-01-16 14:49:37 +05:30
TacoTheDank
04f9272706 Lint: Inner class may be static 2020-11-18 18:02:33 -05:00
TacoTheDank
497e145c70 Lint: Make a bunch of stuff final 2020-11-18 17:50:00 -05:00
TacoTheDank
dfefb90d26 Fix some version checks to use android.os.Build 2020-10-31 15:54:02 -04:00
Avently
73eca41204 Fixed player's ZOOM mode for KitKat devices 2020-09-27 04:25:06 +03:00
Avently
771edd0916 Added a comment and excluded automatic switch of orientation on tablets and Android TVs 2020-09-19 17:21:01 +03:00
Avently
d8d4fa6afe Fix for multiple listeners of insets 2020-09-16 04:49:26 +03:00
Avently
0d5cc050ef Reimagined player positioning 2020-09-15 14:43:43 +03:00
TacoTheDank
7db90c0561 Clean up SDK version checks 2020-09-06 12:55:30 +02:00
TacoTheDank
537a87c3f8 Use enhanced 'for' loops 2020-09-06 12:52:43 +02:00
wb9688
25b56bf5e4 Use final where possible 2020-08-16 10:25:09 +02:00
Avently
24e7a11067 Merged the latest code 2020-07-25 04:18:41 +03:00
Avently
39de879c32 Android TV: ability to select all buttons in the main player, as well as in the main fragment 2020-07-25 04:14:29 +03:00
Alexander--
8cf76f7515 Add @NonNull annotation to method argument
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
2020-07-22 07:57:04 -04:00
Alexander--
05dc8280d4 Use View.isShown() to avoid focus overlay glitches
A View can become focused while being invisible, if it's
parent is invisible. Use global draw listener and
View.isShown() to catch such cases.
2020-07-22 06:21:25 +06:59
Avently
5cd7ca5dab AndroidTvUtils -> DeviceUtils 2020-07-21 01:43:49 +03:00
Avently
a6894644d1 Made checkStyle happy 2020-07-14 20:21:32 +03:00
Avently
aef78ace88 Merged the latest changes 2020-07-13 04:17:21 +03:00
Avently
b99b756435 Marked many (too many) variables as final 2020-07-12 03:59:47 +03:00
Avently
60fd42dfa3 Changes for review 2020-06-27 06:25:50 +03:00
wb9688
205c5ff2ca Optimize imports 2020-05-01 20:13:01 +02:00
Alexander--
cfb5c56800 When drawer opens, always place focus at it's start 2020-04-12 09:39:32 +06:59
Alexander--
a5e28105ac Comply with Checkstyle rules 2020-04-11 09:02:22 +06:59
Alexander--
2cac8a739d Merge remote-tracking branch 'newpipe/dev' into rebase 2020-04-11 08:24:05 +06:59
wb9688
9c8349a8ed Move things back to its original place 2020-04-02 15:57:50 +02:00
wb9688
ac264464ef Improve code style to be more consistent 2020-04-02 15:57:50 +02:00
Alexander--
5c86e436a3 Prevent foocus from escaping open navigation drawer
When contents of NewPipe navigation drawer change, NavigationMenuView
(which is actually a RecyclerView) removes and re-adds all its adapter
children, which leads to temporary loss of focus on currently focused drawer
child. This situation was not anticipated by developers of original
support library DrawerLayout: while NavigationMenuView itself is able
to keep focus from escaping via onRequestFocusInDescendants(),
the implementation of that method in DrawerLayout does not pass focus
to previously focused View. In fact it does not pass focus correctly at all
because the AOSP implementation of that method does not call addFocusables()
and simply focuses the first available VISIBLE View, without regard
to state of drawers.
2020-03-15 09:37:29 +06:59
Alexander--
d37706f814 Fix navigating to action bar buttons on API 28
Keyboard focus clusters prevent that from working, so
we simply remove all focus clusters.

While they are generally a good idea, focus clusters were created
with Chrome OS and it's keyboard-driven interface in mind - there is no
documented way to move focus between clusters using only IR remote.
As such, there are no negative consequences to disabling them on Android TV.
2020-03-14 14:47:02 +06:59
Alexander--
06e987dafd Fix focus getting stuck by cycling within the same list item 2020-03-12 05:29:37 +06:59
Alexander--
5559898332 NewPipeRecyclerView should allow scrolling down by default 2020-02-26 06:40:46 +06:59
Avently
c7c4c2172a Mini player, ExpandableSurfaceView with ZOOM support, popup
- mini player's title, image and author information will be updated in many situations but the main idea is that the info will be the same as currently playing stream. If nothing played then you'll see the info about currently opened stream in fragment. When MainPlayer service stops the info updates too
- made ExpandableSurfaceView to replace AspectRatioFrameLayout. The reason for that is to make possible to use aspect ratio mode ZOOM. It's impossible to show a stream inside AspectRatioFrameLayout with ZOOM mode and to fit the video view to a screen space at the same time. Now the new view able to do that and to show vertical videos in a slightly wide space for them
- refactored some methods to make the code more understandable
- made fixes for player view for landscape-to-landscape orientation change
- added Java docs
- adapted swipe tracking inside bottom sheet
- fixed PlayQueue crashes on clearing
- paddings for popup player now as small as possible
2020-02-05 08:59:30 +03:00
Alexander--
909d1bbccc Rename FireTvUtils to AndroidTvUtils and isFireTv() to isTV()
Because those methods are no longer exclusive to Amazon devices
2020-01-29 03:16:33 +06:59